From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 03/18] xen: introduce 'xen-qdisk' Date: Thu, 29 Nov 2018 16:05:41 +0000 Message-ID: <20181129160541.GG14786__38302.4848335937$1543507530$gmane$org@perard.uk.xensource.com> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-4-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gSOpy-0000ck-Lb for xen-devel@lists.xenproject.org; Thu, 29 Nov 2018 16:06:46 +0000 Content-Disposition: inline In-Reply-To: <20181121151211.15997-4-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBOb3YgMjEsIDIwMTggYXQgMDM6MTE6NTZQTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+IFRoaXMgcGF0Y2ggYWRkcyBhIG5ldyBYZW5EZXZpY2U6ICd4ZW4tcWRpc2snIFsxXS4g VGhpcyB3aWxsIGV2ZW50dWFsbHkKPiByZXBsYWNlIHRoZSAneGVuX2Rpc2snIGxlZ2FjeSBQViBi YWNrZW5kIGJ1dCBpdCBpcyBpbGx1c3RyYXRpdmUgdG8gYnVpbGQKPiB1cCB0aGUgaW1wbGVtZW50 YXRpb24gaW5jcmVtZW50YWxseSwgYWxvbmcgd2l0aCB0aGUgWGVuQnVzL1hlbkRldmljZQo+IGZy YW1ld29yay4gU3Vic2VxdWVudCBwYXRjaGVzIHdpbGwgdGhlcmVmb3JlIGFkZCB0byB0aGlzIGRl dmljZSdzCj4gaW1wbGVtZW50YXRpb24gYXMgbmV3IGZlYXR1cmVzIGFyZSBhZGRlZCB0byB0aGUg ZnJhbWV3b3JrLgo+IAo+IEFmdGVyIHRoaXMgcGF0Y2ggaGFzIGJlZW4gYXBwbGllZCBpdCBpcyBw b3NzaWJsZSB0byBpbnN0YW50aWF0ZSBhIG5ldwo+ICd4ZW4tcWRpc2snIGRldmljZSB3aXRoIGEg c2luZ2xlICd2ZGV2JyBwYXJhbWV0ZXIsIHdoaWNoIGFjY2VwdHMgdmFsdWVzCj4gYWRoZXJpbmcg dG8gdGhlIFhlbiBWQkQgbmFtaW5nIHNjaGVtZSBbMl0uIEZvciBleGFtcGxlLCBhIGNvbW1hbmQt bGluZQo+IGluc3RhbnRpYXRpb24gb2YgYSB4ZW4tcWRpc2sgY2FuIGJlIGRvbmUgd2l0aCBhbiBh cmd1bWVudCBzaW1pbGFyIHRvIHRoZQo+IGZvbGxvd2luZzoKPiAKPiAtZGV2aWNlIHhlbi1xZGlz ayx2ZGV2PWhkYQoKVGhhdCB3b3JrcyB3aGVuIFFFTVUgYm9vdCwgYnV0IGRvaW5nIHRoZSBzYW1l IHRoaW5nIG9uY2UgdGhlIGd1ZXN0IGhhdmUKYm9vdGVkLCB2aWEgUU1QLCBkb2Vzbid0LiBIZXJl IGlzIHRoZSByZXN1bHQgKHRlc3RlZCBpbiBxbXAtc2hlbGwpOgoKKFFFTVUpIGRldmljZV9hZGQg ZHJpdmVyPXhlbi1xZGlzayB2ZGV2PWhkYQp7CiAgICAiZXJyb3IiOiB7CiAgICAgICAgImNsYXNz IjogIkdlbmVyaWNFcnJvciIsIAogICAgICAgICJkZXNjIjogIkJ1cyAneGVuLWJ1cy4wJyBkb2Vz IG5vdCBzdXBwb3J0IGhvdHBsdWdnaW5nIgogICAgfQp9CgpUaGF0J3MgcHJvYmFibHkgd2h5IEkn dmUgYXNrZWQgYWJvdXQgdGhlIGhvdHBsdWcgY2FwYWJpbGl0eSBvbiB0aGUKcHJldmlvdXMgcGF0 Y2guCgo+IFRoZSBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgdmRldiBwYXJhbWV0ZXIgZm9ybXVsYXRl cyB0aGUgYXBwcm9wcmlhdGUgVkJECj4gbnVtYmVyIGZvciB1c2UgaW4gdGhlIFBWIHByb3RvY29s Lgo+IAo+IFsxXSBUaGUgbmFtZSAncWRpc2snIGFzIGFsd2F5cyBiZWVuIHRoZSBuYW1lIGdpdmVu IHRvIHRoZSBRRU1VCj4gICAgIGltcGxlbWVudGF0aW9uIG9mIHRoZSBYZW4gUFYgYmxvY2sgcHJv dG9jb2wgYmFja2VuZCBpbXBsZW1lbnRhdGlvbgo+IFsyXSBodHRwOi8veGVuYml0cy54ZW4ub3Jn L2dpdHdlYi8/cD14ZW4uZ2l0O2E9YmxvYjtmPWRvY3MvbWFuL3hlbi12YmQtaW50ZXJmYWNlLm1h cmtkb3duLjcKCk1heWJlIGEgbGluayB0byB0aGUgZ2VuZXJhdGVkIGRvY3Mgd291bGQgYmUgYmV0 dGVyOgpodHRwczovL3hlbmJpdHMueGVuLm9yZy9kb2NzL3Vuc3RhYmxlL21hbi94ZW4tdmJkLWlu dGVyZmFjZS43Lmh0bWwKCkFsc28sIGl0IHdvdWxkIGJlIHVzZWZ1bCB0byBoYXZlIHRoZSBzYW1l IGxpbmsgaW4gdGhlIHNvdXJjZSBjb2RlLgoKPiBkaWZmIC0tZ2l0IGEvaHcvYmxvY2sveGVuLXFk aXNrLmMgYi9ody9ibG9jay94ZW4tcWRpc2suYwo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5k ZXggMDAwMDAwMDAwMC4uNzIxMjIwNzNmNwo+IC0tLSAvZGV2L251bGwKPiArKysgYi9ody9ibG9j ay94ZW4tcWRpc2suYwpbLi4uXQo+ICtzdGF0aWMgY2hhciAqZGlza190b192YmRfbmFtZSh1bnNp Z25lZCBpbnQgZGlzaykKPiArewo+ICsgICAgdW5zaWduZWQgaW50IGxlbiA9IERJVl9ST1VORF9V UChkaXNrLCAyNik7Cj4gKyAgICBjaGFyICpuYW1lID0gZ19tYWxsb2MwKGxlbiArIDEpOwo+ICsK PiArICAgIGRvIHsKPiArICAgICAgICBuYW1lW2xlbi0tXSA9ICdhJyArIChkaXNrICUgMjYpOwo+ ICsgICAgICAgIGRpc2sgLz0gMjY7Cj4gKyAgICB9IHdoaWxlIChkaXNrICE9IDApOwo+ICsgICAg YXNzZXJ0KGxlbiA9PSAwKTsKPiArCj4gKyAgICByZXR1cm4gbmFtZTsKPiArfQoKVGhhdCBmdW5j dGlvbiBkb2Vzbid0IHdvcmsuCgpGb3IgYSBzaW1wbGUgeHZkcCwgKHNvIGRpc2s9PTE1KSwgaXQg cmV0dXJuICIiLCBJIG1lYW4gIlwwcCIuCgpGb3IgYSBtb3JlIGNvbXBsaWNhdGVkICd4dmRiaHd6 YScsIHdlIGhhdmUgbGVuID09IDIyOTAxLiBBbmQgdGhlIGFzc2VydCBmYWlsZWQuCgpNYXliZSB0 aGUgcmVjdXJzaW5nIGFsZ28gaW4gbGlieGwgd291bGQgYmUgZmluZSwgd2l0aCBhIGJ1ZmZlciB0 aGF0IGlzCmJpZyBlbm91Z2gsIGFuZCBjb3VsZCBwcm9iYWJseSBiZSBvbiB0aGUgc3RhY2sgKGlu IF9nZXRfdmRldikuCgo+ICsKPiArICAgIHN3aXRjaCAodmRldi0+dHlwZSkgewo+ICsgICAgY2Fz ZSBYRU5fUURJU0tfVkRFVl9UWVBFX0RQOgo+ICsgICAgY2FzZSBYRU5fUURJU0tfVkRFVl9UWVBF X1hWRDoKPiArICAgICAgICBpZiAodmRldi0+ZGlzayA8ICgxIDw8IDQpICYmIHZkZXYtPnBhcnRp dGlvbiA8ICgxIDw8IDQpKSB7Cj4gKyAgICAgICAgICAgIHZkZXYtPm51bWJlciA9ICgyMDIgPDwg OCkgfCAodmRldi0+ZGlzayA8PCA0KSB8Cj4gKyAgICAgICAgICAgICAgICB2ZGV2LT5wYXJ0aXRp b247Cj4gKyAgICAgICAgfSBlbHNlIGlmICh2ZGV2LT5kaXNrIDwgKDEgPDwgMjApICYmIHZkZXYt PnBhcnRpdGlvbiA8ICgxIDw8IDgpKSB7Cj4gKyAgICAgICAgICAgIHZkZXYtPm51bWJlciA9ICgx IDw8IDI4KSB8ICh2ZGV2LT5kaXNrIDw8IDgpIHwKPiArICAgICAgICAgICAgICAgIHZkZXYtPnBh cnRpdGlvbjsKPiArICAgICAgICB9IGVsc2Ugewo+ICsgICAgICAgICAgICBnb3RvIGludmFsaWQ7 Cj4gKyAgICAgICAgfQo+ICsgICAgICAgIGJyZWFrOwo+ICsKPiArICAgIGNhc2UgWEVOX1FESVNL X1ZERVZfVFlQRV9IRDoKPiArICAgICAgICBpZiAoKHZkZXYtPmRpc2sgPT0gMCB8fCB2ZGV2LT5k aXNrID09IDEpICYmCj4gKyAgICAgICAgICAgIHZkZXYtPnBhcnRpdGlvbiA8ICgxIDw8IDQpKSB7 CgpJIHRoaW5rIHRoYXQgc2hvdWxkIGJlOgoKICAgIHZkZXYtPnBhcnRpdGlvbiA8ICgxIDw8IDYp CgpCZWNhdXNlIGhkIGRpc2sgaGF2ZSAwLi42MyBwYXJ0aXRpb25zLgoKPiArICAgICAgICAgICAg dmRldi0+bnVtYmVyID0gKDMgPDwgOCkgfCAodmRldi0+ZGlzayA8PCA2KSB8IHZkZXYtPnBhcnRp dGlvbjsKPiArICAgICAgICB9IGVsc2UgaWYgKCh2ZGV2LT5kaXNrID09IDIgfHwgdmRldi0+ZGlz ayA9PSAzKSAmJgo+ICsgICAgICAgICAgICAgICAgICAgdmRldi0+cGFydGl0aW9uIDwgKDEgPDwg NCkpIHsKCnNhbWUgaGVyZS4KCj4gKyAgICAgICAgICAgIHZkZXYtPm51bWJlciA9ICgyMiA8PCA4 KSB8ICgodmRldi0+ZGlzayAtIDIpIDw8IDYpIHwKPiArICAgICAgICAgICAgICAgIHZkZXYtPnBh cnRpdGlvbjsKPiArICAgICAgICB9IGVsc2Ugewo+ICsgICAgICAgICAgICBnb3RvIGludmFsaWQ7 Cj4gKyAgICAgICAgfQo+ICsgICAgICAgIGJyZWFrOwo+ICsKPiArICAgIGNhc2UgWEVOX1FESVNL X1ZERVZfVFlQRV9TRDoKPiArICAgICAgICBpZiAodmRldi0+ZGlzayA8ICgxIDw8IDQpICYmIHZk ZXYtPnBhcnRpdGlvbiA8ICgxIDw8IDQpKSB7Cj4gKyAgICAgICAgICAgIHZkZXYtPm51bWJlciA9 ICg4IDw8IDgpIHwgKHZkZXYtPmRpc2sgPDwgNCkgfCB2ZGV2LT5wYXJ0aXRpb247Cj4gKyAgICAg ICAgfSBlbHNlIHsKPiArICAgICAgICAgICAgZ290byBpbnZhbGlkOwo+ICsgICAgICAgIH0KPiAr ICAgICAgICBicmVhazsKPiArCj4gKyAgICBkZWZhdWx0Ogo+ICsgICAgICAgIGdvdG8gaW52YWxp ZDsKPiArICAgIH0KPiArCj4gKyAgICBnX2ZyZWUoc3RyKTsKPiArICAgIHZkZXYtPnZhbGlkID0g dHJ1ZTsKPiArICAgIHJldHVybjsKPiArCj4gK2ludmFsaWQ6Cj4gKyAgICBlcnJvcl9zZXRnKGVy cnAsICJpbnZhbGlkIHZpcnR1YWwgZGlzayBzcGVjaWZpZXIiKTsKPiArICAgIGdfZnJlZShzdHIp OwoKOigsIGdfZnJlZSBpcyBjYWxsZWQgdHdpY2UuCgptYXliZSB3ZSBjb3VsZCBoYXZlOgogICAg dmRldi0+dmFsaWQ9dHJ1ZTsKICAgIG91dDoKICAgICAgaWYgKCF2ZGV2LT52YWxpZCkKICAgICAg ICBlcnJvcl9zZXRnKC4uLik7CiAgICAgIGdfZnJlZTsKCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv aHcveGVuL3hlbi1xZGlzay5oIGIvaW5jbHVkZS9ody94ZW4veGVuLXFkaXNrLmgKPiBuZXcgZmls ZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAuLmFkZTA4NjYwMzcKPiAtLS0gL2Rldi9u dWxsCj4gKysrIGIvaW5jbHVkZS9ody94ZW4veGVuLXFkaXNrLmgKPiBAQCAtMCwwICsxLDM4IEBA Cj4gKy8qCj4gKyAqIENvcHlyaWdodCAoYykgQ2l0cml4IFN5c3RlbXMgSW5jLgo+ICsgKiBBbGwg cmlnaHRzIHJlc2VydmVkLgo+ICsgKi8KPiArCj4gKyNpZm5kZWYgSFdfWEVOX1FESVNLX0gKPiAr I2RlZmluZSBIV19YRU5fUURJU0tfSAo+ICsKPiArI2luY2x1ZGUgImh3L3hlbi94ZW4tYnVzLmgi Cj4gKwo+ICt0eXBlZGVmIGVudW0gWGVuUWRpc2tWZGV2VHlwZSB7Cj4gKyAgICBYRU5fUURJU0tf VkRFVl9UWVBFX0RQLAoKTWF5YmUgd2UgY291bGQgc2V0IHR5cGVfZHAgdmFsdWUgdG8gMSwgc28g dGhhdCwgd2hlbiB2ZGV2LT50eXBlIGlzbid0CnNldCwgd2UgY2FuIGRldGVjdCBpdCBsYXRlci4K Cgo+ICsgICAgWEVOX1FESVNLX1ZERVZfVFlQRV9YVkQsCj4gKyAgICBYRU5fUURJU0tfVkRFVl9U WVBFX0hELAo+ICsgICAgWEVOX1FESVNLX1ZERVZfVFlQRV9TRCwKPiArICAgIFhFTl9RRElTS19W REVWX1RZUEVfX01BWAo+ICt9IFhlblFkaXNrVmRldlR5cGU7CgpUaGFua3MsCgotLSAKQW50aG9u eSBQRVJBUkQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0 dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=