From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Zhao Yan <yan.y.zhao@intel.com>
Cc: anthony.perard@citrix.com, xen-devel@lists.xenproject.org,
sstabellini@kernel.org, qemu-devel@nongnu.org,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [Qemu-devel] [PATCH v3] xen/pt: allow passthrough of devices with bogus interrupt pin
Date: Tue, 4 Dec 2018 10:30:18 +0100 [thread overview]
Message-ID: <20181204093018.d6vhfdwg276pf7ja@mac> (raw)
In-Reply-To: <20181204075049.10285-1-yan.y.zhao@intel.com>
On Tue, Dec 04, 2018 at 02:50:49AM -0500, Zhao Yan wrote:
> For some pci device, even its PCI_INTERRUPT_PIN is not 0, it actually
> doesn't support INTx mode, so its machine irq read from host sysfs is 0.
> In that case, report PCI_INTERRUPT_PIN as 0 to guest and let passthrough
> continue.
>
> Cc: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Jan Beulich <JBeulich@suse.com>
> Signed-off-by: Zhao Yan <yan.y.zhao@intel.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
One nit below.
>
> ---
> v2: fix some coding style issue
> v3:
> 1. let subject be more descriptive (roger)
> 2. disable INTx assertion if machine irq is 0.(roger)
> 3. in xen_pt_irqpin_reg_init(), drop the else branch as the default
> value for *data is 0. (roger)
> ---
> hw/xen/xen_pt.c | 7 +++++++
> hw/xen/xen_pt_config_init.c | 4 +++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
> index e5a6eff..b563837 100644
> --- a/hw/xen/xen_pt.c
> +++ b/hw/xen/xen_pt.c
> @@ -847,6 +847,13 @@ static void xen_pt_realize(PCIDevice *d, Error **errp)
> }
>
> machine_irq = s->real_device.irq;
> + if (machine_irq == 0) {
> + XEN_PT_LOG(d, "machine irq is 0\n");
> + cmd |= PCI_COMMAND_INTX_DISABLE;
> + s->machine_irq = 0;
AFAICT this is already initialized to 0, so you can drop setting
machine_irq.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next parent reply other threads:[~2018-12-04 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181204075049.10285-1-yan.y.zhao@intel.com>
2018-12-04 9:30 ` Roger Pau Monné [this message]
2018-12-05 4:59 ` [Qemu-devel] [PATCH v3] xen/pt: allow passthrough of devices with bogus interrupt pin Zhao Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204093018.d6vhfdwg276pf7ja@mac \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).