From: Wei Liu <wei.liu2@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Olaf Hering <olaf@aepfle.de>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: how to disable build of pv-shim?
Date: Mon, 13 May 2019 16:28:12 +0100 [thread overview]
Message-ID: <20190513152812.GC3977@zion.uk.xensource.com> (raw)
In-Reply-To: <20190513152005.jojtolhh5wdguvg6@Air-de-Roger>
On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> > tools/firmware/Makefile? From my understanding there is no way to influence
> > its value from outside, which means the build always enters xen-dir/.
>
> I think the following should do the trick.
>
> Let me know if that works for you and I will submit it formally.
>
> Thanks!
>
> ---8<---
> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index 98245f63c9..84ddb1a542 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -75,3 +75,5 @@ TINFO_LIBS := @TINFO_LIBS@
> ARGP_LDFLAGS := @argp_ldflags@
>
> FILE_OFFSET_BITS := @FILE_OFFSET_BITS@
> +
> +CONFIG_PV_SHIM := @pvshim@
> diff --git a/tools/configure.ac b/tools/configure.ac
> index c9fd69ddfa..8df2fd604b 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>
> AC_SUBST(ninepfs)
>
> +AC_ARG_ENABLE([pvshim],
> + AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> + [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> + case "$host_cpu" in
> + i[[3456]]86|x86_64)
> + pvshim="y";;
Since xen doesn't build on 32bit anymore you may want to exclude
i[3456]86 here?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu2@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Olaf Hering <olaf@aepfle.de>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [Xen-devel] how to disable build of pv-shim?
Date: Mon, 13 May 2019 16:28:12 +0100 [thread overview]
Message-ID: <20190513152812.GC3977@zion.uk.xensource.com> (raw)
Message-ID: <20190513152812.1INsOVNqvqwFrYDtyZMXQ8pisgz4SbBPte7jE93SPaA@z> (raw)
In-Reply-To: <20190513152005.jojtolhh5wdguvg6@Air-de-Roger>
On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> > tools/firmware/Makefile? From my understanding there is no way to influence
> > its value from outside, which means the build always enters xen-dir/.
>
> I think the following should do the trick.
>
> Let me know if that works for you and I will submit it formally.
>
> Thanks!
>
> ---8<---
> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index 98245f63c9..84ddb1a542 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -75,3 +75,5 @@ TINFO_LIBS := @TINFO_LIBS@
> ARGP_LDFLAGS := @argp_ldflags@
>
> FILE_OFFSET_BITS := @FILE_OFFSET_BITS@
> +
> +CONFIG_PV_SHIM := @pvshim@
> diff --git a/tools/configure.ac b/tools/configure.ac
> index c9fd69ddfa..8df2fd604b 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>
> AC_SUBST(ninepfs)
>
> +AC_ARG_ENABLE([pvshim],
> + AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> + [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> + case "$host_cpu" in
> + i[[3456]]86|x86_64)
> + pvshim="y";;
Since xen doesn't build on 32bit anymore you may want to exclude
i[3456]86 here?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-13 15:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 14:53 how to disable build of pv-shim? Olaf Hering
2019-05-13 14:53 ` [Xen-devel] " Olaf Hering
2019-05-13 15:07 ` Wei Liu
2019-05-13 15:07 ` [Xen-devel] " Wei Liu
2019-05-13 15:20 ` Roger Pau Monné
2019-05-13 15:20 ` [Xen-devel] " Roger Pau Monné
2019-05-13 15:28 ` Wei Liu [this message]
2019-05-13 15:28 ` Wei Liu
2019-05-14 8:55 ` Roger Pau Monné
2019-05-14 8:55 ` [Xen-devel] " Roger Pau Monné
2019-05-14 9:23 ` Wei Liu
2019-05-14 9:23 ` [Xen-devel] " Wei Liu
2019-05-14 9:37 ` Andrew Cooper
2019-05-14 9:37 ` [Xen-devel] " Andrew Cooper
2019-05-14 9:52 ` Jan Beulich
2019-05-14 9:52 ` [Xen-devel] " Jan Beulich
2019-05-14 10:35 ` Roger Pau Monné
2019-05-14 10:35 ` [Xen-devel] " Roger Pau Monné
2019-05-14 9:26 ` Jan Beulich
2019-05-14 9:26 ` [Xen-devel] " Jan Beulich
2019-05-14 11:11 ` Roger Pau Monné
2019-05-14 11:11 ` [Xen-devel] " Roger Pau Monné
2019-05-14 11:21 ` Jan Beulich
2019-05-14 11:21 ` [Xen-devel] " Jan Beulich
2019-05-14 10:34 ` Olaf Hering
2019-05-14 10:34 ` [Xen-devel] " Olaf Hering
2019-05-14 10:42 ` Roger Pau Monné
2019-05-14 10:42 ` [Xen-devel] " Roger Pau Monné
2019-05-15 10:18 ` Olaf Hering
2019-05-15 10:18 ` [Xen-devel] " Olaf Hering
2019-08-14 7:51 ` Olaf Hering
2019-08-14 7:57 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513152812.GC3977@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=olaf@aepfle.de \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).