From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] libxc: elf_kernel loader: Remove check for shstrtab Date: Wed, 15 May 2019 13:09:56 +0100 Message-ID: <20190515120956.GS2798@zion.uk.xensource.com> References: <20190515114015.25492-1-anthony.perard@citrix.com> <651154bc-9710-5e03-23a2-d04a894853cc@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQsjP-0006us-Pl for xen-devel@lists.xenproject.org; Wed, 15 May 2019 12:09:59 +0000 Content-Disposition: inline In-Reply-To: <651154bc-9710-5e03-23a2-d04a894853cc@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBNYXkgMTUsIDIwMTkgYXQgMDE6MDc6MDNQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBPbiAxNS8wNS8yMDE5IDEyOjQwLCBBbnRob255IFBFUkFSRCB3cm90ZToKPiA+IFRo aXMgd2FzIHByb2JhYmx5IHVzZWZ1bCB0byBsb2FkIEVMRiBOb3RlLCBidXQgbm93IEVMRiBub3Rl cwo+ID4gInNob3VsZCBsaXZlIGluIGEgUFRfTk9URSBzZWdtZW50IiAoZWxmbm90ZS5oKS4KPiA+ Cj4gPiBXaXRoIG5vdGVzIGxpdmluZyBpbiBzZWdtZW50LCB0aGVyZSBhcmUgbm8gbmVlZCBmb3Ig c2VjdGlvbnMsIHNvIHRoZXJlCj4gPiBpcyBub3RoaW5nIHRvIGJlIHN0b3JlZCBpbiB0aGUgc2hz dHJ0YWIuCj4gPgo+ID4gVGhpcyBwYXRjaCB3b3VsZCBhbGxvdyB0byB3cml0ZSBhIHNpbXBsZXIg RUxGIGhlYWRlciBmb3IgYW4gT1ZNRiBibG9iCj4gPiAod2hpY2ggaXNuJ3QgYW4gRUxGKSBhbmQg YWxsb3cgaXQgdG8gYmUgbG9hZGVkIGFzIGEgUFZIIGtlcm5lbC4gVGhlCj4gPiBoZWFkZXIgb25s eSBuZWVkcyB0byBkZWNsYXJlIHR3byBwcm9ncmFtIHNlZ21lbnRzOgo+ID4gLSBvbmUgdG8gdGVs bCBhbiBFTEYgbG9hZGVyIHdoZXJlIHRvIHB1dCB0aGUgYmxvYiwKPiA+IC0gb25lIGZvciBhIFhl biBFTEZOT1RFLgo+ID4KPiA+IFRoZSBFTEZOT1RFIGlzIHRvIGNvbXBseSB0byB0aGUgcHZoIGRl c2lnbiB3aGljaCB3YW50cyB0aGUKPiA+IFhFTl9FTEZOT1RFX1BIWVMzMl9FTlRSWSB0byBkZWNs YXJlIGEgYmxvYiBhcyBjb21wYXB0aWJsZSB3aXRoIHRoZSBQVkgKPiA+IGJvb3QgQUJJLgo+ID4K PiA+IE5vdGUgdGhhdCB3aXRob3V0IHRoZSBFTEZOT1RFLCBsaWJ4YyB3aWxsIGxvYWQgYW4gRUxG IGJ1dCB3aXRoCj4gPiB0aGUgcGxhaW4gRUxGIGxvYWRlciwgd2hpY2ggZG9lc24ndCBjaGVjayBm b3Igc2hzdHJ0YWIuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhv bnkucGVyYXJkQGNpdHJpeC5jb20+Cj4gPiAtLS0KPiA+ICB0b29scy9saWJ4Yy94Y19kb21fZWxm bG9hZGVyLmMgfCA5IC0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA5IGRlbGV0aW9ucygt KQo+ID4KPiA+IGRpZmYgLS1naXQgYS90b29scy9saWJ4Yy94Y19kb21fZWxmbG9hZGVyLmMgYi90 b29scy9saWJ4Yy94Y19kb21fZWxmbG9hZGVyLmMKPiA+IGluZGV4IDgyYjVmMmVlNzkuLmIzMjdk YjIxOWQgMTAwNjQ0Cj4gPiAtLS0gYS90b29scy9saWJ4Yy94Y19kb21fZWxmbG9hZGVyLmMKPiA+ ICsrKyBiL3Rvb2xzL2xpYnhjL3hjX2RvbV9lbGZsb2FkZXIuYwo+ID4gQEAgLTE2NSwxNSArMTY1 LDYgQEAgc3RhdGljIGVsZl9uZWdlcnJub3ZhbCB4Y19kb21fcGFyc2VfZWxmX2tlcm5lbChzdHJ1 Y3QgeGNfZG9tX2ltYWdlICpkb20pCj4gPiAgICAgICAgICByZXR1cm4gcmM7Cj4gPiAgICAgIH0K PiA+ICAKPiA+IC0gICAgLyogRmluZCB0aGUgc2VjdGlvbi1oZWFkZXIgc3RyaW5ncyB0YWJsZS4g Ki8KPiA+IC0gICAgaWYgKCBFTEZfUFRSVkFMX0lOVkFMSUQoZWxmLT5zZWNfc3RydGFiKSApCj4g PiAtICAgIHsKPiA+IC0gICAgICAgIHhjX2RvbV9wYW5pYyhkb20tPnhjaCwgWENfSU5WQUxJRF9L RVJORUwsICIlczogRUxGIGltYWdlIgo+ID4gLSAgICAgICAgICAgICAgICAgICAgICIgaGFzIG5v IHNoc3RydGFiIiwgX19GVU5DVElPTl9fKTsKPiA+IC0gICAgICAgIHJjID0gLUVJTlZBTDsKPiA+ IC0gICAgICAgIGdvdG8gb3V0Owo+ID4gLSAgICB9Cj4gCj4gVGhpcyBtaWdodCBiZSBmaW5lIGZv ciBuZXdlciBiaW5hcmllcywgYnV0IHlvdSdsbCBicmVhayBvbGRlciBvbmVzLgo+IAo+IEluc3Rl YWQsIHlvdSBzaG91bGQgc2tpcCBzZWFyY2hpbmcgZm9yIHN0cnRhYiBpZiB3ZSd2ZSBhbHJlYWR5 IGxvY2F0ZWQKPiB0aGUgWGVuIG5vdGVzLgoKQUlVSSBvbGQgYmluYXJpZXMgYWx3YXlzIGhhdmUg c2hzdHJ0YWIgd2hpbGUgaXQgaXNuJ3QgYWx3YXlzIHRydWUgZm9yCm5ldyBvbmVzLgoKVW5mb3J0 dW5hdGVseSBteSBhdHRlbXB0IHRvIGZpZ3VyZSBvdXQgdGhlIGhpc3Rvcnkgb2YgdGhpcyBwaWVj ZSBvZiBjb2RlCmlzIGZ1dGlsZS4KCldlaS4KCj4gCj4gfkFuZHJldwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB1DBC04E53 for ; Wed, 15 May 2019 12:10:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4DF120657 for ; Wed, 15 May 2019 12:10:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4DF120657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQsjQ-0006uy-FH; Wed, 15 May 2019 12:10:00 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQsjP-0006us-Pl for xen-devel@lists.xenproject.org; Wed, 15 May 2019 12:09:59 +0000 X-Inumbo-ID: 5bd7efd5-770a-11e9-8980-bc764e045a96 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 5bd7efd5-770a-11e9-8980-bc764e045a96; Wed, 15 May 2019 12:09:58 +0000 (UTC) Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=wei.liu2@citrix.com; spf=SoftFail smtp.mailfrom=wei.liu2@citrix.com; spf=None smtp.helo=postmaster@MIAPEX02MSOL01.citrite.net Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of wei.liu2@citrix.com) identity=pra; client-ip=23.29.105.83; receiver=esa2.hc3370-68.iphmx.com; envelope-from="wei.liu2@citrix.com"; x-sender="wei.liu2@citrix.com"; x-conformance=sidf_compatible Received-SPF: SoftFail (esa2.hc3370-68.iphmx.com: domain of wei.liu2@citrix.com is inclined to not designate 23.29.105.83 as permitted sender) identity=mailfrom; client-ip=23.29.105.83; receiver=esa2.hc3370-68.iphmx.com; envelope-from="wei.liu2@citrix.com"; x-sender="wei.liu2@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 mx include:spf.citrix.com include:spf2.citrix.com include:ironport.citrix.com include:_spf.salesforce.com ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@MIAPEX02MSOL01.citrite.net) identity=helo; client-ip=23.29.105.83; receiver=esa2.hc3370-68.iphmx.com; envelope-from="wei.liu2@citrix.com"; x-sender="postmaster@MIAPEX02MSOL01.citrite.net"; x-conformance=sidf_compatible IronPort-SDR: APMhprVAcWr9UgIPP1D1uFoDhCrYHF0Yn9TkKwxuvI89dfGEH2ntaJO43OpjVuE36CMJ9iUV42 Xp9G8n4bd2ic1XCBvW3K1aKQqWnP7RaEnUZ3lg6vMFwwfUe4RSCNhp70kH7CqKblBzd2+fAD63 A0hu1ewu6uLnFiLvMsj2nGoZFV0IaIWByHFXy9rzKA/E+Gl8MxR1ImvaZ5OQDJVDeeHIK99WZs B7/aXF/LLZDeDuJFSfVch1LqjYx7AP0iEwE4xMnQppIpjl2WsZIUFrv8zb1qKuIirfRCncRfkH 15s= X-SBRS: 2.7 X-MesageID: 454511 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 23.29.105.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.60,472,1549947600"; d="scan'208";a="454511" Date: Wed, 15 May 2019 13:09:56 +0100 From: Wei Liu To: Andrew Cooper Message-ID: <20190515120956.GS2798@zion.uk.xensource.com> References: <20190515114015.25492-1-anthony.perard@citrix.com> <651154bc-9710-5e03-23a2-d04a894853cc@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <651154bc-9710-5e03-23a2-d04a894853cc@citrix.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Wei Liu , Ian Jackson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190515120956.F2W7CC4f3b4MVO-g4pAw4zINT_DORpdYgjWavKincsw@z> T24gV2VkLCBNYXkgMTUsIDIwMTkgYXQgMDE6MDc6MDNQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBPbiAxNS8wNS8yMDE5IDEyOjQwLCBBbnRob255IFBFUkFSRCB3cm90ZToKPiA+IFRo aXMgd2FzIHByb2JhYmx5IHVzZWZ1bCB0byBsb2FkIEVMRiBOb3RlLCBidXQgbm93IEVMRiBub3Rl cwo+ID4gInNob3VsZCBsaXZlIGluIGEgUFRfTk9URSBzZWdtZW50IiAoZWxmbm90ZS5oKS4KPiA+ Cj4gPiBXaXRoIG5vdGVzIGxpdmluZyBpbiBzZWdtZW50LCB0aGVyZSBhcmUgbm8gbmVlZCBmb3Ig c2VjdGlvbnMsIHNvIHRoZXJlCj4gPiBpcyBub3RoaW5nIHRvIGJlIHN0b3JlZCBpbiB0aGUgc2hz dHJ0YWIuCj4gPgo+ID4gVGhpcyBwYXRjaCB3b3VsZCBhbGxvdyB0byB3cml0ZSBhIHNpbXBsZXIg RUxGIGhlYWRlciBmb3IgYW4gT1ZNRiBibG9iCj4gPiAod2hpY2ggaXNuJ3QgYW4gRUxGKSBhbmQg YWxsb3cgaXQgdG8gYmUgbG9hZGVkIGFzIGEgUFZIIGtlcm5lbC4gVGhlCj4gPiBoZWFkZXIgb25s eSBuZWVkcyB0byBkZWNsYXJlIHR3byBwcm9ncmFtIHNlZ21lbnRzOgo+ID4gLSBvbmUgdG8gdGVs bCBhbiBFTEYgbG9hZGVyIHdoZXJlIHRvIHB1dCB0aGUgYmxvYiwKPiA+IC0gb25lIGZvciBhIFhl biBFTEZOT1RFLgo+ID4KPiA+IFRoZSBFTEZOT1RFIGlzIHRvIGNvbXBseSB0byB0aGUgcHZoIGRl c2lnbiB3aGljaCB3YW50cyB0aGUKPiA+IFhFTl9FTEZOT1RFX1BIWVMzMl9FTlRSWSB0byBkZWNs YXJlIGEgYmxvYiBhcyBjb21wYXB0aWJsZSB3aXRoIHRoZSBQVkgKPiA+IGJvb3QgQUJJLgo+ID4K PiA+IE5vdGUgdGhhdCB3aXRob3V0IHRoZSBFTEZOT1RFLCBsaWJ4YyB3aWxsIGxvYWQgYW4gRUxG IGJ1dCB3aXRoCj4gPiB0aGUgcGxhaW4gRUxGIGxvYWRlciwgd2hpY2ggZG9lc24ndCBjaGVjayBm b3Igc2hzdHJ0YWIuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhv bnkucGVyYXJkQGNpdHJpeC5jb20+Cj4gPiAtLS0KPiA+ICB0b29scy9saWJ4Yy94Y19kb21fZWxm bG9hZGVyLmMgfCA5IC0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA5IGRlbGV0aW9ucygt KQo+ID4KPiA+IGRpZmYgLS1naXQgYS90b29scy9saWJ4Yy94Y19kb21fZWxmbG9hZGVyLmMgYi90 b29scy9saWJ4Yy94Y19kb21fZWxmbG9hZGVyLmMKPiA+IGluZGV4IDgyYjVmMmVlNzkuLmIzMjdk YjIxOWQgMTAwNjQ0Cj4gPiAtLS0gYS90b29scy9saWJ4Yy94Y19kb21fZWxmbG9hZGVyLmMKPiA+ ICsrKyBiL3Rvb2xzL2xpYnhjL3hjX2RvbV9lbGZsb2FkZXIuYwo+ID4gQEAgLTE2NSwxNSArMTY1 LDYgQEAgc3RhdGljIGVsZl9uZWdlcnJub3ZhbCB4Y19kb21fcGFyc2VfZWxmX2tlcm5lbChzdHJ1 Y3QgeGNfZG9tX2ltYWdlICpkb20pCj4gPiAgICAgICAgICByZXR1cm4gcmM7Cj4gPiAgICAgIH0K PiA+ICAKPiA+IC0gICAgLyogRmluZCB0aGUgc2VjdGlvbi1oZWFkZXIgc3RyaW5ncyB0YWJsZS4g Ki8KPiA+IC0gICAgaWYgKCBFTEZfUFRSVkFMX0lOVkFMSUQoZWxmLT5zZWNfc3RydGFiKSApCj4g PiAtICAgIHsKPiA+IC0gICAgICAgIHhjX2RvbV9wYW5pYyhkb20tPnhjaCwgWENfSU5WQUxJRF9L RVJORUwsICIlczogRUxGIGltYWdlIgo+ID4gLSAgICAgICAgICAgICAgICAgICAgICIgaGFzIG5v IHNoc3RydGFiIiwgX19GVU5DVElPTl9fKTsKPiA+IC0gICAgICAgIHJjID0gLUVJTlZBTDsKPiA+ IC0gICAgICAgIGdvdG8gb3V0Owo+ID4gLSAgICB9Cj4gCj4gVGhpcyBtaWdodCBiZSBmaW5lIGZv ciBuZXdlciBiaW5hcmllcywgYnV0IHlvdSdsbCBicmVhayBvbGRlciBvbmVzLgo+IAo+IEluc3Rl YWQsIHlvdSBzaG91bGQgc2tpcCBzZWFyY2hpbmcgZm9yIHN0cnRhYiBpZiB3ZSd2ZSBhbHJlYWR5 IGxvY2F0ZWQKPiB0aGUgWGVuIG5vdGVzLgoKQUlVSSBvbGQgYmluYXJpZXMgYWx3YXlzIGhhdmUg c2hzdHJ0YWIgd2hpbGUgaXQgaXNuJ3QgYWx3YXlzIHRydWUgZm9yCm5ldyBvbmVzLgoKVW5mb3J0 dW5hdGVseSBteSBhdHRlbXB0IHRvIGZpZ3VyZSBvdXQgdGhlIGhpc3Rvcnkgb2YgdGhpcyBwaWVj ZSBvZiBjb2RlCmlzIGZ1dGlsZS4KCldlaS4KCj4gCj4gfkFuZHJldwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==