* [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
@ 2019-05-31 3:18 Baodong Chen
2019-05-31 3:18 ` [Xen-devel] " Baodong Chen
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Baodong Chen @ 2019-05-31 3:18 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, Jan Beulich, Baodong Chen
Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
---
xen/include/xen/sched-if.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
index 92bc7a0..f0cf210 100644
--- a/xen/include/xen/sched-if.h
+++ b/xen/include/xen/sched-if.h
@@ -213,9 +213,9 @@ static inline void sched_free_domdata(const struct scheduler *s,
struct cpupool
{
int cpupool_id;
+ unsigned int n_dom;
cpumask_var_t cpu_valid; /* all cpus assigned to pool */
struct cpupool *next;
- unsigned int n_dom;
struct scheduler *sched;
atomic_t refcnt;
};
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Xen-devel] [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-05-31 3:18 [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id' Baodong Chen
@ 2019-05-31 3:18 ` Baodong Chen
2019-05-31 10:52 ` Julien Grall
2019-06-17 15:19 ` Jan Beulich
2 siblings, 0 replies; 12+ messages in thread
From: Baodong Chen @ 2019-05-31 3:18 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, Jan Beulich, Baodong Chen
Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
---
xen/include/xen/sched-if.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
index 92bc7a0..f0cf210 100644
--- a/xen/include/xen/sched-if.h
+++ b/xen/include/xen/sched-if.h
@@ -213,9 +213,9 @@ static inline void sched_free_domdata(const struct scheduler *s,
struct cpupool
{
int cpupool_id;
+ unsigned int n_dom;
cpumask_var_t cpu_valid; /* all cpus assigned to pool */
struct cpupool *next;
- unsigned int n_dom;
struct scheduler *sched;
atomic_t refcnt;
};
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-05-31 3:18 [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id' Baodong Chen
2019-05-31 3:18 ` [Xen-devel] " Baodong Chen
@ 2019-05-31 10:52 ` Julien Grall
2019-05-31 10:52 ` [Xen-devel] " Julien Grall
2019-06-03 1:48 ` chenbaodong
2019-06-17 15:19 ` Jan Beulich
2 siblings, 2 replies; 12+ messages in thread
From: Julien Grall @ 2019-05-31 10:52 UTC (permalink / raw)
To: Baodong Chen, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Jan Beulich
Hi,
On 5/31/19 4:18 AM, Baodong Chen wrote:
> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
I am happy with the change, although AFAIK cpupool is not instantiated
that often. Are you planning to have more instantiation of it?
Cheers,
>
> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
> ---
> xen/include/xen/sched-if.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
> index 92bc7a0..f0cf210 100644
> --- a/xen/include/xen/sched-if.h
> +++ b/xen/include/xen/sched-if.h
> @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const struct scheduler *s,
> struct cpupool
> {
> int cpupool_id;
> + unsigned int n_dom;
> cpumask_var_t cpu_valid; /* all cpus assigned to pool */
> struct cpupool *next;
> - unsigned int n_dom;
> struct scheduler *sched;
> atomic_t refcnt;
> };
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-05-31 10:52 ` Julien Grall
@ 2019-05-31 10:52 ` Julien Grall
2019-06-03 1:48 ` chenbaodong
1 sibling, 0 replies; 12+ messages in thread
From: Julien Grall @ 2019-05-31 10:52 UTC (permalink / raw)
To: Baodong Chen, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Jan Beulich
Hi,
On 5/31/19 4:18 AM, Baodong Chen wrote:
> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
I am happy with the change, although AFAIK cpupool is not instantiated
that often. Are you planning to have more instantiation of it?
Cheers,
>
> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
> ---
> xen/include/xen/sched-if.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
> index 92bc7a0..f0cf210 100644
> --- a/xen/include/xen/sched-if.h
> +++ b/xen/include/xen/sched-if.h
> @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const struct scheduler *s,
> struct cpupool
> {
> int cpupool_id;
> + unsigned int n_dom;
> cpumask_var_t cpu_valid; /* all cpus assigned to pool */
> struct cpupool *next;
> - unsigned int n_dom;
> struct scheduler *sched;
> atomic_t refcnt;
> };
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-05-31 10:52 ` Julien Grall
2019-05-31 10:52 ` [Xen-devel] " Julien Grall
@ 2019-06-03 1:48 ` chenbaodong
2019-06-03 1:48 ` [Xen-devel] " chenbaodong
2019-06-03 9:30 ` Julien Grall
1 sibling, 2 replies; 12+ messages in thread
From: chenbaodong @ 2019-06-03 1:48 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Jan Beulich
On 5/31/19 18:52, Julien Grall wrote:
> Hi,
>
> On 5/31/19 4:18 AM, Baodong Chen wrote:
>> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
>
> I am happy with the change, although AFAIK cpupool is not instantiated
> that often. Are you planning to have more instantiation of it?
>
> Cheers,
>
No, I'm not planning to create lots of cpupool instance.
I'm studying xen for a few weeks and my plan is:
run xen for embeded automotive use case with dom0less, null scheduler,
small code base for safety certified maybe a plus(not sure whether can
do this).
>>
>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
>> ---
>> xen/include/xen/sched-if.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
>> index 92bc7a0..f0cf210 100644
>> --- a/xen/include/xen/sched-if.h
>> +++ b/xen/include/xen/sched-if.h
>> @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const
>> struct scheduler *s,
>> struct cpupool
>> {
>> int cpupool_id;
>> + unsigned int n_dom;
>> cpumask_var_t cpu_valid; /* all cpus assigned to pool */
>> struct cpupool *next;
>> - unsigned int n_dom;
>> struct scheduler *sched;
>> atomic_t refcnt;
>> };
>>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-06-03 1:48 ` chenbaodong
@ 2019-06-03 1:48 ` chenbaodong
2019-06-03 9:30 ` Julien Grall
1 sibling, 0 replies; 12+ messages in thread
From: chenbaodong @ 2019-06-03 1:48 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Jan Beulich
On 5/31/19 18:52, Julien Grall wrote:
> Hi,
>
> On 5/31/19 4:18 AM, Baodong Chen wrote:
>> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
>
> I am happy with the change, although AFAIK cpupool is not instantiated
> that often. Are you planning to have more instantiation of it?
>
> Cheers,
>
No, I'm not planning to create lots of cpupool instance.
I'm studying xen for a few weeks and my plan is:
run xen for embeded automotive use case with dom0less, null scheduler,
small code base for safety certified maybe a plus(not sure whether can
do this).
>>
>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
>> ---
>> xen/include/xen/sched-if.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
>> index 92bc7a0..f0cf210 100644
>> --- a/xen/include/xen/sched-if.h
>> +++ b/xen/include/xen/sched-if.h
>> @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const
>> struct scheduler *s,
>> struct cpupool
>> {
>> int cpupool_id;
>> + unsigned int n_dom;
>> cpumask_var_t cpu_valid; /* all cpus assigned to pool */
>> struct cpupool *next;
>> - unsigned int n_dom;
>> struct scheduler *sched;
>> atomic_t refcnt;
>> };
>>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-06-03 1:48 ` chenbaodong
2019-06-03 1:48 ` [Xen-devel] " chenbaodong
@ 2019-06-03 9:30 ` Julien Grall
2019-06-03 9:30 ` [Xen-devel] " Julien Grall
2019-06-03 10:06 ` chenbaodong
1 sibling, 2 replies; 12+ messages in thread
From: Julien Grall @ 2019-06-03 9:30 UTC (permalink / raw)
To: chenbaodong, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Jan Beulich
Hi,
On 03/06/2019 02:48, chenbaodong wrote:
>
> On 5/31/19 18:52, Julien Grall wrote:
>> Hi,
>>
>> On 5/31/19 4:18 AM, Baodong Chen wrote:
>>> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
>>
>> I am happy with the change, although AFAIK cpupool is not instantiated that
>> often. Are you planning to have more instantiation of it?
>>
>> Cheers,
>>
> No, I'm not planning to create lots of cpupool instance.
>
> I'm studying xen for a few weeks and my plan is:
>
> run xen for embeded automotive use case with dom0less, null scheduler, small
> code base for safety certified maybe a plus(not sure whether can do this).
FWIW, there are discussion to get Xen safety certified. They are captured on [1].
Cheers,
[1] https://wiki.xenproject.org/wiki/Category:Safety_Certification/FuSa_SIG
>
>
>>>
>>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
>>> ---
>>> xen/include/xen/sched-if.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
>>> index 92bc7a0..f0cf210 100644
>>> --- a/xen/include/xen/sched-if.h
>>> +++ b/xen/include/xen/sched-if.h
>>> @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const struct
>>> scheduler *s,
>>> struct cpupool
>>> {
>>> int cpupool_id;
>>> + unsigned int n_dom;
>>> cpumask_var_t cpu_valid; /* all cpus assigned to pool */
>>> struct cpupool *next;
>>> - unsigned int n_dom;
>>> struct scheduler *sched;
>>> atomic_t refcnt;
>>> };
>>>
>>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-06-03 9:30 ` Julien Grall
@ 2019-06-03 9:30 ` Julien Grall
2019-06-03 10:06 ` chenbaodong
1 sibling, 0 replies; 12+ messages in thread
From: Julien Grall @ 2019-06-03 9:30 UTC (permalink / raw)
To: chenbaodong, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Jan Beulich
Hi,
On 03/06/2019 02:48, chenbaodong wrote:
>
> On 5/31/19 18:52, Julien Grall wrote:
>> Hi,
>>
>> On 5/31/19 4:18 AM, Baodong Chen wrote:
>>> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
>>
>> I am happy with the change, although AFAIK cpupool is not instantiated that
>> often. Are you planning to have more instantiation of it?
>>
>> Cheers,
>>
> No, I'm not planning to create lots of cpupool instance.
>
> I'm studying xen for a few weeks and my plan is:
>
> run xen for embeded automotive use case with dom0less, null scheduler, small
> code base for safety certified maybe a plus(not sure whether can do this).
FWIW, there are discussion to get Xen safety certified. They are captured on [1].
Cheers,
[1] https://wiki.xenproject.org/wiki/Category:Safety_Certification/FuSa_SIG
>
>
>>>
>>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
>>> ---
>>> xen/include/xen/sched-if.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
>>> index 92bc7a0..f0cf210 100644
>>> --- a/xen/include/xen/sched-if.h
>>> +++ b/xen/include/xen/sched-if.h
>>> @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const struct
>>> scheduler *s,
>>> struct cpupool
>>> {
>>> int cpupool_id;
>>> + unsigned int n_dom;
>>> cpumask_var_t cpu_valid; /* all cpus assigned to pool */
>>> struct cpupool *next;
>>> - unsigned int n_dom;
>>> struct scheduler *sched;
>>> atomic_t refcnt;
>>> };
>>>
>>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-06-03 9:30 ` Julien Grall
2019-06-03 9:30 ` [Xen-devel] " Julien Grall
@ 2019-06-03 10:06 ` chenbaodong
2019-06-03 10:06 ` [Xen-devel] " chenbaodong
1 sibling, 1 reply; 12+ messages in thread
From: chenbaodong @ 2019-06-03 10:06 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Jan Beulich
On 6/3/19 17:30, Julien Grall wrote:
> Hi,
>
> On 03/06/2019 02:48, chenbaodong wrote:
>>
>> On 5/31/19 18:52, Julien Grall wrote:
>>> Hi,
>>>
>>> On 5/31/19 4:18 AM, Baodong Chen wrote:
>>>> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
>>>
>>> I am happy with the change, although AFAIK cpupool is not
>>> instantiated that often. Are you planning to have more instantiation
>>> of it?
>>>
>>> Cheers,
>>>
>> No, I'm not planning to create lots of cpupool instance.
>>
>> I'm studying xen for a few weeks and my plan is:
>>
>> run xen for embeded automotive use case with dom0less, null
>> scheduler, small code base for safety certified maybe a plus(not sure
>> whether can do this).
>
> FWIW, there are discussion to get Xen safety certified. They are
> captured on [1].
>
> Cheers,
>
> [1]
> https://wiki.xenproject.org/wiki/Category:Safety_Certification/FuSa_SIG
Hello Julien, Thanks for your info.
I will follow the wiki link and see what i can do about safety
certification.
>
>>
>>
>>>>
>>>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
>>>> ---
>>>> xen/include/xen/sched-if.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
>>>> index 92bc7a0..f0cf210 100644
>>>> --- a/xen/include/xen/sched-if.h
>>>> +++ b/xen/include/xen/sched-if.h
>>>> @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const
>>>> struct scheduler *s,
>>>> struct cpupool
>>>> {
>>>> int cpupool_id;
>>>> + unsigned int n_dom;
>>>> cpumask_var_t cpu_valid; /* all cpus assigned to pool */
>>>> struct cpupool *next;
>>>> - unsigned int n_dom;
>>>> struct scheduler *sched;
>>>> atomic_t refcnt;
>>>> };
>>>>
>>>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-06-03 10:06 ` chenbaodong
@ 2019-06-03 10:06 ` chenbaodong
0 siblings, 0 replies; 12+ messages in thread
From: chenbaodong @ 2019-06-03 10:06 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Jan Beulich
On 6/3/19 17:30, Julien Grall wrote:
> Hi,
>
> On 03/06/2019 02:48, chenbaodong wrote:
>>
>> On 5/31/19 18:52, Julien Grall wrote:
>>> Hi,
>>>
>>> On 5/31/19 4:18 AM, Baodong Chen wrote:
>>>> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
>>>
>>> I am happy with the change, although AFAIK cpupool is not
>>> instantiated that often. Are you planning to have more instantiation
>>> of it?
>>>
>>> Cheers,
>>>
>> No, I'm not planning to create lots of cpupool instance.
>>
>> I'm studying xen for a few weeks and my plan is:
>>
>> run xen for embeded automotive use case with dom0less, null
>> scheduler, small code base for safety certified maybe a plus(not sure
>> whether can do this).
>
> FWIW, there are discussion to get Xen safety certified. They are
> captured on [1].
>
> Cheers,
>
> [1]
> https://wiki.xenproject.org/wiki/Category:Safety_Certification/FuSa_SIG
Hello Julien, Thanks for your info.
I will follow the wiki link and see what i can do about safety
certification.
>
>>
>>
>>>>
>>>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
>>>> ---
>>>> xen/include/xen/sched-if.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
>>>> index 92bc7a0..f0cf210 100644
>>>> --- a/xen/include/xen/sched-if.h
>>>> +++ b/xen/include/xen/sched-if.h
>>>> @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const
>>>> struct scheduler *s,
>>>> struct cpupool
>>>> {
>>>> int cpupool_id;
>>>> + unsigned int n_dom;
>>>> cpumask_var_t cpu_valid; /* all cpus assigned to pool */
>>>> struct cpupool *next;
>>>> - unsigned int n_dom;
>>>> struct scheduler *sched;
>>>> atomic_t refcnt;
>>>> };
>>>>
>>>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-05-31 3:18 [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id' Baodong Chen
2019-05-31 3:18 ` [Xen-devel] " Baodong Chen
2019-05-31 10:52 ` Julien Grall
@ 2019-06-17 15:19 ` Jan Beulich
2019-06-17 15:22 ` Juergen Gross
2 siblings, 1 reply; 12+ messages in thread
From: Jan Beulich @ 2019-06-17 15:19 UTC (permalink / raw)
To: George Dunlap, Baodong Chen, Dario Faggioli
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
Andrew Cooper, Ian Jackson, Tim Deegan, Julien Grall, xen-devel
>>> On 31.05.19 at 05:18, <chenbaodong@mxnavi.com> wrote:
> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
>
> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
> ---
> xen/include/xen/sched-if.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've just noticed that this file isn't part of the SCHEDULING
maintainer group. Therefore
Acked-by: Jan Beulich <jbeulich@suse.com>
I'm wondering though whether maintainership of the file shouldn't be
adjusted, preferably by moving this (supposedly private) header into
xen/common/. I realize there may be some further cleanup needed
for this to actually be possible. If there was general consensus about
such a step, I could see about actually carrying it out.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id'
2019-06-17 15:19 ` Jan Beulich
@ 2019-06-17 15:22 ` Juergen Gross
0 siblings, 0 replies; 12+ messages in thread
From: Juergen Gross @ 2019-06-17 15:22 UTC (permalink / raw)
To: Jan Beulich, George Dunlap, Baodong Chen, Dario Faggioli
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
Andrew Cooper, Tim Deegan, Julien Grall, xen-devel, Ian Jackson
On 17.06.19 17:19, Jan Beulich wrote:
>>>> On 31.05.19 at 05:18, <chenbaodong@mxnavi.com> wrote:
>> Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system.
>>
>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
>> ---
>> xen/include/xen/sched-if.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I've just noticed that this file isn't part of the SCHEDULING
> maintainer group. Therefore
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> I'm wondering though whether maintainership of the file shouldn't be
> adjusted, preferably by moving this (supposedly private) header into
> xen/common/. I realize there may be some further cleanup needed
> for this to actually be possible. If there was general consensus about
> such a step, I could see about actually carrying it out.
I am planning a big scheduling cleanup series after my core scheduling
series has been processed. sched-if.h is part of that work.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-06-17 15:23 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-31 3:18 [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id' Baodong Chen
2019-05-31 3:18 ` [Xen-devel] " Baodong Chen
2019-05-31 10:52 ` Julien Grall
2019-05-31 10:52 ` [Xen-devel] " Julien Grall
2019-06-03 1:48 ` chenbaodong
2019-06-03 1:48 ` [Xen-devel] " chenbaodong
2019-06-03 9:30 ` Julien Grall
2019-06-03 9:30 ` [Xen-devel] " Julien Grall
2019-06-03 10:06 ` chenbaodong
2019-06-03 10:06 ` [Xen-devel] " chenbaodong
2019-06-17 15:19 ` Jan Beulich
2019-06-17 15:22 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).