From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DFB2C3A59E for ; Mon, 26 Aug 2019 06:59:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C303217F4 for ; Mon, 26 Aug 2019 06:59:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C303217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i28yJ-0005iR-4Q; Mon, 26 Aug 2019 06:59:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i28yI-0005iM-7D for xen-devel@lists.xenproject.org; Mon, 26 Aug 2019 06:59:22 +0000 X-Inumbo-ID: 0665c5ec-c7cf-11e9-b95f-bc764e2007e4 Received: from mga07.intel.com (unknown [134.134.136.100]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0665c5ec-c7cf-11e9-b95f-bc764e2007e4; Mon, 26 Aug 2019 06:59:19 +0000 (UTC) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Aug 2019 23:59:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,431,1559545200"; d="scan'208";a="196986171" Received: from gao-cwp.sh.intel.com (HELO gao-cwp) ([10.239.159.26]) by fmsmga001.fm.intel.com with ESMTP; 25 Aug 2019 23:59:16 -0700 Date: Mon, 26 Aug 2019 15:03:22 +0800 From: Chao Gao To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Message-ID: <20190826070320.GA11910@gao-cwp> References: <1566177928-19114-1-git-send-email-chao.gao@intel.com> <1566177928-19114-13-git-send-email-chao.gao@intel.com> <20190823081121.khm5622trozzhswe@Air-de-Roger> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190823081121.khm5622trozzhswe@Air-de-Roger> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [Xen-devel] [PATCH v9 12/15] microcode: reduce memory allocation and copy when creating a patch X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Jan Beulich , Ashok Raj , Wei Liu , Andrew Cooper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Archived-At: List-Archive: T24gRnJpLCBBdWcgMjMsIDIwMTkgYXQgMTA6MTE6MjFBTSArMDIwMCwgUm9nZXIgUGF1IE1vbm7D qSB3cm90ZToKPk9uIE1vbiwgQXVnIDE5LCAyMDE5IGF0IDA5OjI1OjI1QU0gKzA4MDAsIENoYW8g R2FvIHdyb3RlOgo+PiBUbyBjcmVhdGUgYSBtaWNyb2NvZGUgcGF0Y2ggZnJvbSBhIHZlbmRvci1z cGVjaWZpYyB1cGRhdGUsCj4+IGFsbG9jYXRlX21pY3JvY29kZV9wYXRjaCgpIGNvcGllZCBldmVy eXRoaW5nIGZyb20gdGhlIHVwZGF0ZS4KPj4gSXQgaXMgbm90IGVmZmljaWVudC4gRXNzZW50aWFs bHksIHdlIGp1c3QgbmVlZCB0byBnbyB0aHJvdWdoCj4+IHVjb2RlcyBpbiB0aGUgYmxvYiwgZmlu ZCB0aGUgb25lIHdpdGggdGhlIG5ld2VzdCByZXZpc2lvbiBhbmQKPj4gaW5zdGFsbCBpdCBpbnRv IHRoZSBtaWNyb2NvZGVfcGF0Y2guIEluIHRoZSBwcm9jZXNzLCBidWZmZXJzCj4+IGxpa2UgbWNf YW1kLCBlcXVpdl9jcHVfdGFibGUgKG9uIEFNRCBzaWRlKSwgYW5kIG1jIChvbiBJbnRlbAo+PiBz aWRlKSBjYW4gYmUgcmV1c2VkLiBtaWNyb2NvZGVfcGF0Y2ggbm93IGlzIGFsbG9jYXRlZCBhZnRl cgo+PiBpdCBpcyBzdXJlIHRoYXQgdGhlcmUgaXMgYSBtYXRjaGluZyB1Y29kZS4KPgo+T2gsIEkg dGhpbmsgdGhpcyBhbnN3ZXJzIG15IHF1ZXN0aW9uIG9uIGEgcHJldmlvdXMgcGF0Y2guCj4KPkZv ciBmdXR1cmUgc2VyaWVzIGl0IHdvdWxkIGJlIG5pY2UgdG8gYXZvaWQgc28gbWFueSByZXdyaXRl cyBpbiB0aGUKPnNhbWUgc2VyaWVzLCBhbGxvY19taWNyb2NvZGVfcGF0Y2ggaXMgYWxyZWFkeSBt b2RpZmllZCBpbiBhIHByZXZpb3VzCj5wYXRjaCwganVzdCB0byBiZSByZW1vdmVkIGhlcmUuIEl0 IGFsc28gbWFrZXMgaXQgaGFyZGVyIHRvIGZvbGxvdwo+d2hhdCdzIGdvaW5nIG9uLgoKR290IGl0 LiBUaGlzIHBhdGNoIGlzIGFkZGVkIGluIHRoaXMgbmV3IHZlcnNpb24uIEFuZCBzb21lIHRyaXZp YWwKcGF0Y2hlcyBhbHJlYWR5IGdvdCByZXZpZXdlZC1ieS4gU28gSSBkb24ndCBtZXJnZSBpdCB3 aXRoIHRoZW0uCgo+PiAgICAgIHdoaWxlICggKGVycm9yID0gZ2V0X3Vjb2RlX2Zyb21fYnVmZmVy X2FtZChtY19hbWQsIGJ1ZiwgYnVmc2l6ZSwKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJm9mZnNldCkpID09IDAgKQo+PiAgICAgIHsKPj4gLSAgICAg ICAgc3RydWN0IG1pY3JvY29kZV9wYXRjaCAqbmV3X3BhdGNoID0gYWxsb2NfbWljcm9jb2RlX3Bh dGNoKG1jX2FtZCk7Cj4+IC0KPj4gLSAgICAgICAgaWYgKCBJU19FUlIobmV3X3BhdGNoKSApCj4+ IC0gICAgICAgIHsKPj4gLSAgICAgICAgICAgIGVycm9yID0gUFRSX0VSUihuZXdfcGF0Y2gpOwo+ PiAtICAgICAgICAgICAgYnJlYWs7Cj4+IC0gICAgICAgIH0KPj4gLQo+PiAgICAgICAgICAvKgo+ PiAtICAgICAgICAgKiBJZiB0aGUgbmV3IHBhdGNoIGNvdmVycyBjdXJyZW50IENQVSwgY29tcGFy ZSBwYXRjaGVzIGFuZCBzdG9yZSB0aGUKPj4gKyAgICAgICAgICogSWYgdGhlIG5ldyB1Y29kZSBj b3ZlcnMgY3VycmVudCBDUFUsIGNvbXBhcmUgdWNvZGVzIGFuZCBzdG9yZSB0aGUKPj4gICAgICAg ICAgICogb25lIHdpdGggaGlnaGVyIHJldmlzaW9uLgo+PiAgICAgICAgICAgKi8KPj4gLSAgICAg ICAgaWYgKCAobWljcm9jb2RlX2ZpdHMobmV3X3BhdGNoLT5tY19hbWQpICE9IE1JU19VQ09ERSkg JiYKPj4gLSAgICAgICAgICAgICAoIXBhdGNoIHx8IChjb21wYXJlX3BhdGNoKG5ld19wYXRjaCwg cGF0Y2gpID09IE5FV19VQ09ERSkpICkKPj4gKyNkZWZpbmUgUkVWX0lEKG1wYikgKCgoc3RydWN0 IG1pY3JvY29kZV9oZWFkZXJfYW1kICopKG1wYikpLT5wcm9jZXNzb3JfcmV2X2lkKQo+PiArICAg ICAgICBpZiAoIChtaWNyb2NvZGVfZml0cyhtY19hbWQpICE9IE1JU19VQ09ERSkgJiYKPj4gKyAg ICAgICAgICAgICAoIXNhdmVkIHx8IChSRVZfSUQobWNfYW1kLT5tcGIpID4gUkVWX0lEKHNhdmVk KSkpICkKPj4gKyN1bmRlZiBSRVZfSUQKPj4gICAgICAgICAgewo+PiAtICAgICAgICAgICAgc3Ry dWN0IG1pY3JvY29kZV9wYXRjaCAqdG1wID0gcGF0Y2g7Cj4+IC0KPj4gLSAgICAgICAgICAgIHBh dGNoID0gbmV3X3BhdGNoOwo+PiAtICAgICAgICAgICAgbmV3X3BhdGNoID0gdG1wOwo+PiArICAg ICAgICAgICAgeGZyZWUoc2F2ZWQpOwo+PiArICAgICAgICAgICAgc2F2ZWQgPSBtY19hbWQtPm1w YjsKPj4gKyAgICAgICAgICAgIHNhdmVkX3NpemUgPSBtY19hbWQtPm1wYl9zaXplOwo+PiAgICAg ICAgICB9Cj4+IC0KPj4gLSAgICAgICAgaWYgKCBuZXdfcGF0Y2ggKQo+PiAtICAgICAgICAgICAg bWljcm9jb2RlX2ZyZWVfcGF0Y2gobmV3X3BhdGNoKTsKPj4gKyAgICAgICAgZWxzZQo+PiArICAg ICAgICAgICAgeGZyZWUobWNfYW1kLT5tcGIpOwoKSXQgbWlnaHQgYmUgYmV0dGVyIHRvIG1vdmUg J21jX2FtZC0+bXBiID0gTlVMTCcgaGVyZS4KCj4+ICAKPj4gICAgICAgICAgaWYgKCBvZmZzZXQg Pj0gYnVmc2l6ZSApCj4+ICAgICAgICAgICAgICBicmVhazsKPj4gQEAgLTU5Myw5ICs1NDgsMjUg QEAgc3RhdGljIHN0cnVjdCBtaWNyb2NvZGVfcGF0Y2ggKmNwdV9yZXF1ZXN0X21pY3JvY29kZShj b25zdCB2b2lkICpidWYsCj4+ICAgICAgICAgICAgICAgKihjb25zdCB1aW50MzJfdCAqKShidWYg KyBvZmZzZXQpID09IFVDT0RFX01BR0lDICkKPj4gICAgICAgICAgICAgIGJyZWFrOwo+PiAgICAg IH0KPj4gLSAgICB4ZnJlZShtY19hbWQtPm1wYik7Cj4+IC0gICAgeGZyZWUobWNfYW1kLT5lcXVp dl9jcHVfdGFibGUpOwo+PiAtICAgIHhmcmVlKG1jX2FtZCk7Cj4+ICsKPj4gKyAgICBpZiAoIHNh dmVkICkKPj4gKyAgICB7Cj4+ICsgICAgICAgIG1jX2FtZC0+bXBiID0gc2F2ZWQ7Cj4+ICsgICAg ICAgIG1jX2FtZC0+bXBiX3NpemUgPSBzYXZlZF9zaXplOwo+PiArICAgICAgICBwYXRjaCA9IHht YWxsb2Moc3RydWN0IG1pY3JvY29kZV9wYXRjaCk7Cj4+ICsgICAgICAgIGlmICggcGF0Y2ggKQo+ PiArICAgICAgICAgICAgcGF0Y2gtPm1jX2FtZCA9IG1jX2FtZDsKPj4gKyAgICAgICAgZWxzZQo+ PiArICAgICAgICB7Cj4+ICsgICAgICAgICAgICBmcmVlX3BhdGNoKG1jX2FtZCk7Cj4+ICsgICAg ICAgICAgICBlcnJvciA9IC1FTk9NRU07Cj4+ICsgICAgICAgIH0KPj4gKyAgICB9Cj4+ICsgICAg ZWxzZQo+PiArICAgIHsKPj4gKyAgICAgICAgbWNfYW1kLT5tcGIgPSBOVUxMOwo+Cj5XaGF0J3Mg dGhlIHBvaW50IGluIHNldHRpbmcgbXBiIHRvIE5VTEwgaWYgeW91IGFyZSBqdXN0IGdvaW5nIHRv IGZyZWUKPm1jX2FtZCBiZWxvdz8KClRvIGF2b2lkIGRvdWJsZSBmcmVlIGhlcmUuIG1jX2FtZC0+ bXBiIGlzIGFsd2F5cyBmcmVlZCBvciBzYXZlZC4KQW5kIGhlcmUgd2Ugd2FudCB0byBmcmVlIG1j X2FtZCBpdHNlbGYgYW5kIG1jX2FtZC0+ZXF1aXZfY3B1X3RhYmxlLgoKPgo+QWxzbywgSSdtIG5v dCBzdXJlIEkgdW5kZXJzdGFuZCB3aHkgeW91IG5lZWQgdG8gZnJlZSBtY19hbWQsIGlzbid0Cj50 aGlzIGJ1ZmYgbWVtb3J5IHRoYXQgc2hvdWxkIGJlIGZyZWVkIGJ5IHRoZSBjYWxsZXI/CgpCdXQg bWNfYW1kIGlzIGFsbG9jYXRlZCBpbiB0aGlzIGZ1bmN0aW9uLgoKPgo+aWU6IGluIHRoZSBJbnRl bCBjb3VudGVycGFydCBiZWxvdyB5b3UgZG9uJ3Qgc2VlbSB0byBmcmVlIHRoZSBtYwo+Y3Vyc29y IHVzZWQgZm9yIHRoZSBnZXRfbmV4dF91Y29kZV9mcm9tX2J1ZmZlciBsb29wLgoKJ21jJyBpcyBz YXZlZCBpZiBpdCBpcyBuZXdlciB0aGFuIGN1cnJlbnQgcGF0Y2ggc3RvcmVkIGluICdzYXZlZCcu Ck90aGVyd2lzZSAnbWMnIGlzIGZyZWVkIGltbWVkaWF0ZWx5LiBTbyB3ZSBkb24ndCBuZWVkIHRv IGZyZWUgaXQKYWdhaW4gYWZ0ZXIgdGhlIHdoaWxlIGxvb3AuCgpUaGFua3MKQ2hhbwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==