From: Wei Liu <wl@xen.org>
To: Chao Gao <chao.gao@intel.com>
Cc: Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
"Spassov, Stanislav" <stanspas@amazon.de>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] pci: clear {host/guest}_maskall field on assign
Date: Thu, 10 Oct 2019 11:23:02 +0100 [thread overview]
Message-ID: <20191010102302.7wpjaad446ooreub@debian> (raw)
In-Reply-To: <20191009111343.GA16457@gao-cwp>
On Wed, Oct 09, 2019 at 07:13:45PM +0800, Chao Gao wrote:
> On Wed, Oct 09, 2019 at 10:33:21AM +0200, Roger Pau Monne wrote:
> >The current implementation of host_maskall makes it sticky across
> >assign and deassign calls, which means that once a guest forces Xen to
> >set host_maskall the maskall bit is not going to be cleared until a
> >call to PHYSDEVOP_prepare_msix is performed. Such call however
> >shouldn't be part of the normal flow when doing PCI passthrough, and
> >hence the flag needs to be cleared when assigning in order to prevent
> >host_maskall being carried over from previous assignations.
> >
> >Note that the entry maskbit is reset when the msix capability is
> >initialized, and the guest_maskall field is also cleared so that the
> >hardware value matches Xen's internal state (hardware maskall =
> >host_maskall | guest_maskall).
> >
> >Also note that doing the reset of host_maskall there would allow the
> >guest to reset such field by enabling and disabling MSIX, which is not
> >intended.
> >
> >Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >---
> >Cc: Chao Gao <chao.gao@intel.com>
> >Cc: "Spassov, Stanislav" <stanspas@amazon.de>
> >Cc: Pasi Kärkkäinen <pasik@iki.fi>
> >---
> >Chao, Stanislav, can you please check if this patch fixes your
> >issues?
>
> Tested-by: Chao Gao <chao.gao@intel.com>
>
> I got the assertion failure below when starting xencommons with the
> newest staging:
>
> Setting domain 0 name, domid and JSON config...
> xen-init-dom0: _libxl_types.c:2163: libxl_domain_build_info_init_type: Assertion `p->type == LIBXL_DOMAIN_TYPE_INVALID' failed.
> /etc/init.d/xencommons: line 54: 2006 Aborted (core dumped) ${LIBEXEC_BIN}/xen-init-dom0 ${XEN_DOM0_UUID}
What is your setup like?
Did you perhaps have some stale libraries?
Wei.
>
> It should be irrelated to this patch. So I apply this patch on
> cd93953538aac and it works.
>
> Thanks
> Chao
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-10-10 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 8:33 [Xen-devel] [PATCH v2] pci: clear {host/guest}_maskall field on assign Roger Pau Monne
2019-10-09 9:49 ` Jan Beulich
2019-10-10 8:47 ` Jürgen Groß
2019-10-09 11:13 ` Chao Gao
2019-10-10 10:23 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010102302.7wpjaad446ooreub@debian \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=chao.gao@intel.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=stanspas@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).