From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: jgross@suse.com, corbet@lwn.net, linux-efi@vger.kernel.org,
hpa@zytor.com, ard.biesheuvel@linaro.org, peterz@infradead.org,
ross.philipson@oracle.com, Daniel Kiper <daniel.kiper@oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
dave.hansen@linux.intel.com, mingo@redhat.com, bp@alien8.de,
luto@kernel.org, eric.snowberg@oracle.com,
xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
tglx@linutronix.de
Subject: Re: [Xen-devel] [PATCH v3 1/3] x86/boot: Introduce the kernel_info
Date: Fri, 11 Oct 2019 14:43:57 -0400 [thread overview]
Message-ID: <20191011184357.GI691@char.us.oracle.com> (raw)
In-Reply-To: <cb5bcff5-e787-82c4-790d-71695291d552@infradead.org>
> >>> +be prefixed with header/magic and its size, e.g.:
> >>> +
> >>> + kernel_info:
> >>> + .ascii "LToP" /* Header, Linux top (structure). */
> >>> + .long kernel_info_var_len_data - kernel_info
> >>> + .long kernel_info_end - kernel_info
> >>> + .long 0x01234567 /* Some fixed size data for the bootloaders. */
> >>> + kernel_info_var_len_data:
> >>> + example_struct: /* Some variable size data for the bootloaders. */
> >>> + .ascii "EsTT" /* Header/Magic. */
> >>> + .long example_struct_end - example_struct
> >>> + .ascii "Struct"
> >>> + .long 0x89012345
> >>> + example_struct_end:
> >>> + example_strings: /* Some variable size data for the bootloaders. */
> >>> + .ascii "EsTs" /* Header/Magic. */
> >>
> >> Where do the Magic values "EsTT" and "EsTs" come from?
> >> where are they defined?
> >
> > EsTT == Example STrucT
> > EsTs == Example STringS
> >
> > Anyway, it can be anything which does not collide with existing variable
> > length data magics. There are none right now. So, it can be anything.
> > Maybe I should add something saying that.
>
> Yes, please.
Or make it very clear they are examples, says "1234" or "ABCD" or such.
>
> thanks.
> --
> ~Randy
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-11 18:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 10:53 [Xen-devel] [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes Daniel Kiper
2019-10-09 10:53 ` [Xen-devel] [PATCH v3 1/3] x86/boot: Introduce the kernel_info Daniel Kiper
2019-10-10 0:43 ` Randy Dunlap
2019-10-10 9:43 ` Daniel Kiper
2019-10-10 14:43 ` Randy Dunlap
2019-10-11 18:43 ` Konrad Rzeszutek Wilk [this message]
2019-10-09 10:53 ` [Xen-devel] [PATCH v3 2/3] x86/boot: Introduce the kernel_info.setup_type_max Daniel Kiper
2019-10-09 10:53 ` [Xen-devel] [PATCH v3 3/3] x86/boot: Introduce the setup_indirect Daniel Kiper
2019-10-16 11:06 ` [Xen-devel] [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes Daniel Kiper
2019-10-23 20:44 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011184357.GI691@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=ard.biesheuvel@linaro.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.kiper@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=eric.snowberg@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=ross.philipson@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).