Re: [Xen-devel] [PATCH 1/1] kdd.c: Add support for initial handshake in KD protocol for Win 7, 8 and 10 (64 bit)

From: Wei Liu <wl@xen.org>
To: Julian Tuminaro <julian.tuminaro@gmail.com>
Cc: wl@xen.org, paul@xen.org, ian.jackson@eu.citrix.com,
	Jenish Rakholiya <rjenish@cmu.edu>,
	tim@xen.org, Julian Tuminaro <jtuminar@andrew.cmu.edu>,
	xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH 1/1] kdd.c: Add support for initial handshake in KD protocol for Win 7, 8 and 10 (64 bit)
Date: Wed, 6 Nov 2019 11:03:55 +0000	[thread overview]
Message-ID: <20191106110355.yxvge52aepy53qz5@debian> (raw)
In-Reply-To: <20191106022427.9088-1-julian.tuminaro@gmail.com>

Hi Julian

Thanks for your patch.

On Tue, Nov 05, 2019 at 09:24:27PM -0500, Julian Tuminaro wrote:
[...]
>  
> +#if 0
> +/**
> + * @brief Temporary function for printing memory dump while debugging
> + * Dumps in the format of QWORD type
> + *
> + * @param s Pointer to the kdd_state structure
> + * @param addr Address to start dumping memory from
> + * @param size Number of bytes to print (automatically aligned to higher
> + * multiple of 8 bytes
> + *
> + * @note TODO: Remove this before pushing to master

:-)

> + * @note TODO: Maybe add level of logging to kdd (using -v option) - The
> + * idea of using printf instead of KDD_LOG was to not print all other unwanted
> + * logging output
> + */
> +static void my_memdump(kdd_state *s, uint64_t addr, int size)

If this function is not used, please leave it out. I generally prefer to
not commit dead code unless absolutely necessary.

Also the code can use a bit of cleanup because it contains a lot of
commented out code which is probably for debugging only.

I'm not familiar with KDD so I will leave the judgement of this patch to
Paul and Tim. Please wait for them to reply before sending out a new
version.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel