From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1288C33C9E for ; Fri, 17 Jan 2020 18:57:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7A2F20748 for ; Fri, 17 Jan 2020 18:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KD3s8FNR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7A2F20748 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=invisiblethingslab.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1isWnZ-0003Et-AQ; Fri, 17 Jan 2020 18:56:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1isWnX-0003Ee-Qa for xen-devel@lists.xenproject.org; Fri, 17 Jan 2020 18:56:48 +0000 X-Inumbo-ID: 1bbcccee-395b-11ea-b5e4-12813bfff9fa Received: from wout3-smtp.messagingengine.com (unknown [64.147.123.19]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1bbcccee-395b-11ea-b5e4-12813bfff9fa; Fri, 17 Jan 2020 18:56:46 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C79A2654; Fri, 17 Jan 2020 13:56:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 17 Jan 2020 13:56:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ZucMv1 i2IIRph2tvAQJkWDJwlXUYTjtd7gNnnNPIRKY=; b=KD3s8FNRi9c3cKlFJ6fv6T MJX5kKaflzl4y/tLA8IY5zX+CQbnKBvXMVA27SEf5mdGDSEFEsLFm+hEKjxMSsc0 Qk6H38iicobLa+XxmbyPH8v88zyOiDqQGuP0atJhJUX/LSRHNBxXbZ95OF98rV9E xwNl9B2jWG/cmqH/1RiMEiN1BZbJjF/vX8DfiApyg5cu7JjceFe1Dashqfxw6MUz TnjnsyVvmkzCz7Trr6syL/JHIeLsU2jiVmomHhtH5O4z1G9pNgIu9FvD7bAaoGjW tTvq3hHLh/N1yZnDIVkvHd70A2bVDeFdbpkMoN2hY98zLhuG5tF7jHRP++M4wnOA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrtdekgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecukfhppeeluddrieehrdefgedrfeef necurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvg hthhhinhhgshhlrggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mail-itl (ip5b412221.dynamic.kabel-deutschland.de [91.65.34.33]) by mail.messagingengine.com (Postfix) with ESMTPA id 9743C8005C; Fri, 17 Jan 2020 13:56:42 -0500 (EST) Date: Fri, 17 Jan 2020 19:56:39 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Rich Persaud Message-ID: <20200117185639.GA1314@mail-itl> References: <887B9537-ABB7-459E-9E99-50AD4DDDBFE2@gmail.com> MIME-Version: 1.0 In-Reply-To: <887B9537-ABB7-459E-9E99-50AD4DDDBFE2@gmail.com> Subject: Re: [Xen-devel] [PATCH v4 11/16] tools: add simple vchan-socket-proxy X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Jan Beulich , xen-devel@lists.xenproject.org Content-Type: multipart/mixed; boundary="===============6828184019617562086==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============6828184019617562086== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="I0oWFe1KborvVxk0" Content-Disposition: inline --I0oWFe1KborvVxk0 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Xen-devel] [PATCH v4 11/16] tools: add simple vchan-socket-proxy On Fri, Jan 17, 2020 at 01:44:20PM -0500, Rich Persaud wrote: > On Jan 14, 2020, at 21:42, Marek Marczykowski-G=C3=B3recki wrote: > > @@ -66,6 +70,7 @@ install: all > > $(INSTALL_PROG) libxenvchan.so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir) > > ln -sf libxenvchan.so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)/libxenvc= han.so.$(MAJOR) > > ln -sf libxenvchan.so.$(MAJOR) $(DESTDIR)$(libdir)/libxenvchan.so > > + $(INSTALL_PROG) vchan-socket-proxy $(DESTDIR)$(bindir) >=20 > Does this need directory creation, to avoid vchan binary being named "bin= "? > + $(INSTALL_DIR) $(DESTDIR)$(bindir) I guess it depends on makefile execution order. I'll add it to be on the safe side. > > +int main(int argc, char **argv) > > +{ > > + int is_server =3D 0; > > + int socket_fd; >=20 > When compiled for OpenEmbedded / OpenXT, gcc complained about socket_fd b= eing uninitialized before possible use. I think gcc is wrong here - in all the paths socket_fd is used, it is initialized under the same conditions (socket_path !=3D "-" and !is_server). But I'll add initializer to mute this warning. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --I0oWFe1KborvVxk0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl4iA2cACgkQ24/THMrX 1ywQbwgAkFWtkx6vVQBGbbtJenF7iqpjXIS2mBrHMG2mrVxdl9ehzXBFixObumn6 n6Gn0R1SyieopFcBhgCHb0GgeVupq3eJSSX6Hm3lM1CYav4f4oOpM5jC5dir+gb4 oIF0R6uC9EGTrYmUJSBWv9/0udiHMBd4CfLfirqlaKVnkP1aX1hWud+xlUrzfTG+ f/ZfxjPuYyQVegTNx3QHouCPd2c9C1LWGxf5nnjY2Ca7NNUL6IchoSOfZQRYsZ4l 25HnSM2QAzG9zjIW57+oPkN81Ob3FcE0aFwK/BD8XQHKjtmLTZo/5fm8IR8H70cQ X4K3xXJMf209WiMeZqOEjH/eO2P6fg== =GFoJ -----END PGP SIGNATURE----- --I0oWFe1KborvVxk0-- --===============6828184019617562086== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============6828184019617562086==--