[Xen-devel] [XEN PATCH 0/3] Default to python3

[Xen-devel] [XEN PATCH 0/3] Default to python3

[Anthony PERARD]

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.python3-default-v1

Hi,

I think it's time for Xen to build with python3 by default.

The main reason for that is that QEMU upstream don't build with python 2.x
anymore, and the python binary selected by Xen build system is the one used
when building qemu-xen. So now osstest failed to build QEMU upstream.

Also, python2 is EOL.

FYI, the hypervisor build system already select python3 by default, this change
the tools side.

Cheers,

Anthony PERARD (3):
  automation: Only build QEMU if Python >= 3.5
  automation: updating container to have python3-config binary
  tools: Default to python3

 automation/build/debian/stretch-i386.dockerfile  | 1 +
 automation/build/debian/stretch.dockerfile       | 1 +
 automation/build/debian/unstable-i386.dockerfile | 1 +
 automation/build/debian/unstable.dockerfile      | 1 +
 automation/build/fedora/29.dockerfile            | 1 +
 automation/build/suse/opensuse-leap.dockerfile   | 1 +
 automation/build/ubuntu/bionic.dockerfile        | 1 +
 automation/build/ubuntu/trusty.dockerfile        | 1 +
 automation/build/ubuntu/xenial.dockerfile        | 1 +
 automation/scripts/build                         | 4 ++--
 tools/configure.ac                               | 2 +-
 11 files changed, 12 insertions(+), 3 deletions(-)

-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [XEN PATCH 1/3] automation: Only build QEMU if Python >= 3.5

[Anthony PERARD]

Recent version of QEMU will not build anymore if Python < 3.5.
That is, QEMU 4.3 not released yet.

That check would also prevent the GitLab CI from building QEMU if
python3 binary isn't present.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/scripts/build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/automation/scripts/build b/automation/scripts/build
index 83c44e6ce758..0cd0f3971de5 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -28,8 +28,8 @@ if [[ "${CC}" == "clang"* ]]; then
     cfgargs+=("--disable-stubdom")
 fi
 
-# Qemu requires Python 2.7 or later
-if python -c "import sys; res = sys.version_info < (2, 7); exit(not(res))"; then
+# Qemu requires Python 3.5 or later
+if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))"; then
     cfgargs+=("--with-system-qemu=/bin/false")
 fi
 
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [XEN PATCH 2/3] automation: updating container to have python3-config binary

[Anthony PERARD]

Those containers have already been updated in GitLab:
- debian/stretch
- debian/stretch-i386
- debian/unstable
- debian/unstable-i386
- fedora/29
- suse/opensuse-leap
- ubuntu/bionic
- ubuntu/trusty
- ubuntu/xenial

The container debian:unstable-arm64v8 haven't been changed.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

I don't know how to update the container for ARM, so it hasn't been
changed.
---
 automation/build/debian/stretch-i386.dockerfile  | 1 +
 automation/build/debian/stretch.dockerfile       | 1 +
 automation/build/debian/unstable-i386.dockerfile | 1 +
 automation/build/debian/unstable.dockerfile      | 1 +
 automation/build/fedora/29.dockerfile            | 1 +
 automation/build/suse/opensuse-leap.dockerfile   | 1 +
 automation/build/ubuntu/bionic.dockerfile        | 1 +
 automation/build/ubuntu/trusty.dockerfile        | 1 +
 automation/build/ubuntu/xenial.dockerfile        | 1 +
 9 files changed, 9 insertions(+)

diff --git a/automation/build/debian/stretch-i386.dockerfile b/automation/build/debian/stretch-i386.dockerfile
index d2e96fafa73e..4797ae344231 100644
--- a/automation/build/debian/stretch-i386.dockerfile
+++ b/automation/build/debian/stretch-i386.dockerfile
@@ -18,6 +18,7 @@ RUN apt-get update && \
         libncurses5-dev \
         libssl-dev \
         python-dev \
+        python3-dev \
         xorg-dev \
         uuid-dev \
         libyajl-dev \
diff --git a/automation/build/debian/stretch.dockerfile b/automation/build/debian/stretch.dockerfile
index 44e6eee07f5c..cfbb2e9b0b60 100644
--- a/automation/build/debian/stretch.dockerfile
+++ b/automation/build/debian/stretch.dockerfile
@@ -16,6 +16,7 @@ RUN apt-get update && \
         libncurses5-dev \
         libssl-dev \
         python-dev \
+        python3-dev \
         xorg-dev \
         uuid-dev \
         libyajl-dev \
diff --git a/automation/build/debian/unstable-i386.dockerfile b/automation/build/debian/unstable-i386.dockerfile
index 07df84224029..1a73b3b1eca3 100644
--- a/automation/build/debian/unstable-i386.dockerfile
+++ b/automation/build/debian/unstable-i386.dockerfile
@@ -18,6 +18,7 @@ RUN apt-get update && \
         libncurses5-dev \
         libssl-dev \
         python-dev \
+        python3-dev \
         xorg-dev \
         uuid-dev \
         libyajl-dev \
diff --git a/automation/build/debian/unstable.dockerfile b/automation/build/debian/unstable.dockerfile
index a1428a3df045..2a834f671912 100644
--- a/automation/build/debian/unstable.dockerfile
+++ b/automation/build/debian/unstable.dockerfile
@@ -16,6 +16,7 @@ RUN apt-get update && \
         libncurses5-dev \
         libssl-dev \
         python-dev \
+        python3-dev \
         xorg-dev \
         uuid-dev \
         libyajl-dev \
diff --git a/automation/build/fedora/29.dockerfile b/automation/build/fedora/29.dockerfile
index 8ad0b2baf70c..5be4a9e2294c 100644
--- a/automation/build/fedora/29.dockerfile
+++ b/automation/build/fedora/29.dockerfile
@@ -14,6 +14,7 @@ RUN dnf -y install \
         zlib-devel \
         openssl-devel \
         python-devel \
+        python3-devel \
         libuuid-devel \
         pkgconfig \
         gettext \
diff --git a/automation/build/suse/opensuse-leap.dockerfile b/automation/build/suse/opensuse-leap.dockerfile
index b68d5b0efba7..c60c13c943f2 100644
--- a/automation/build/suse/opensuse-leap.dockerfile
+++ b/automation/build/suse/opensuse-leap.dockerfile
@@ -56,6 +56,7 @@ RUN zypper install -y --no-recommends \
         pkg-config \
         python \
         python-devel \
+        python3-devel \
         systemd-devel \
         tar \
         transfig \
diff --git a/automation/build/ubuntu/bionic.dockerfile b/automation/build/ubuntu/bionic.dockerfile
index 8e6a5d581f55..712b2e47229c 100644
--- a/automation/build/ubuntu/bionic.dockerfile
+++ b/automation/build/ubuntu/bionic.dockerfile
@@ -16,6 +16,7 @@ RUN apt-get update && \
         libncurses5-dev \
         libssl-dev \
         python-dev \
+        python3-dev \
         xorg-dev \
         uuid-dev \
         libyajl-dev \
diff --git a/automation/build/ubuntu/trusty.dockerfile b/automation/build/ubuntu/trusty.dockerfile
index d43d60c5f51d..397a28061ddd 100644
--- a/automation/build/ubuntu/trusty.dockerfile
+++ b/automation/build/ubuntu/trusty.dockerfile
@@ -16,6 +16,7 @@ RUN apt-get update && \
         libncurses5-dev \
         libssl-dev \
         python-dev \
+        python3-dev \
         xorg-dev \
         uuid-dev \
         libyajl-dev \
diff --git a/automation/build/ubuntu/xenial.dockerfile b/automation/build/ubuntu/xenial.dockerfile
index 66ddf15923fc..ce0e84fa2fb8 100644
--- a/automation/build/ubuntu/xenial.dockerfile
+++ b/automation/build/ubuntu/xenial.dockerfile
@@ -16,6 +16,7 @@ RUN apt-get update && \
         libncurses5-dev \
         libssl-dev \
         python-dev \
+        python3-dev \
         xorg-dev \
         uuid-dev \
         libyajl-dev \
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [XEN PATCH 3/3] tools: Default to python3

[Anthony PERARD]

Main reason, newer version of QEMU doesn't support python 2.x anymore.
Second main reason, python2 is EOL.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Please, rerun ./autogen.sh
---
 tools/configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/configure.ac b/tools/configure.ac
index 8d86c42de8e5..f288d2cc3fdd 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -337,7 +337,7 @@ case "$host_os" in
   freebsd*) ;;
   *) AX_PATH_PROG_OR_FAIL([BASH], [bash]);;
 esac
-AS_IF([test -z "$PYTHON"], [AC_CHECK_PROGS([PYTHON], [python python3 python2], err)])
+AS_IF([test -z "$PYTHON"], [AC_CHECK_PROGS([PYTHON], [python3 python python2], err)])
 AS_IF([test "$PYTHON" = "err"], [AC_MSG_ERROR([No python interpreter found])])
 AS_IF([echo "$PYTHON" | grep -q "^/"], [], [AC_PATH_PROG([PYTHON], [$PYTHON])])
 PYTHONPATH=$PYTHON
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 0/3] Default to python3

[Anthony PERARD]

On Mon, Jan 20, 2020 at 11:50:50AM +0000, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.python3-default-v1
> 
> Hi,
> 
> I think it's time for Xen to build with python3 by default.
> 
> The main reason for that is that QEMU upstream don't build with python 2.x
> anymore, and the python binary selected by Xen build system is the one used
> when building qemu-xen. So now osstest failed to build QEMU upstream.
> 
> Also, python2 is EOL.
> 
> FYI, the hypervisor build system already select python3 by default, this change
> the tools side.

I forgot to say that there's a osstest patch as well:
[OSSTEST PATCH] ts-xen-build-prep: Install python3-dev

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 1/3] automation: Only build QEMU if Python >= 3.5

[Doug Goldstein]

On 1/20/20 5:50 AM, Anthony PERARD wrote:
> Recent version of QEMU will not build anymore if Python < 3.5.
> That is, QEMU 4.3 not released yet.
> 
> That check would also prevent the GitLab CI from building QEMU if
> python3 binary isn't present.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Doug Goldstein <cardoe@cardoe.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 2/3] automation: updating container to have python3-config binary

[Doug Goldstein]

On 1/20/20 5:50 AM, Anthony PERARD wrote:
> Those containers have already been updated in GitLab:
> - debian/stretch
> - debian/stretch-i386
> - debian/unstable
> - debian/unstable-i386
> - fedora/29
> - suse/opensuse-leap
> - ubuntu/bionic
> - ubuntu/trusty
> - ubuntu/xenial
> 
> The container debian:unstable-arm64v8 haven't been changed.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Doug Goldstein <cardoe@cardoe.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 0/3] Default to python3

[Wei Liu]

On Mon, Jan 20, 2020 at 11:52:17AM +0000, Anthony PERARD wrote:
> On Mon, Jan 20, 2020 at 11:50:50AM +0000, Anthony PERARD wrote:
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.python3-default-v1
> > 
> > Hi,
> > 
> > I think it's time for Xen to build with python3 by default.
> > 
> > The main reason for that is that QEMU upstream don't build with python 2.x
> > anymore, and the python binary selected by Xen build system is the one used
> > when building qemu-xen. So now osstest failed to build QEMU upstream.
> > 
> > Also, python2 is EOL.
> > 
> > FYI, the hypervisor build system already select python3 by default, this change
> > the tools side.
> 
> I forgot to say that there's a osstest patch as well:
> [OSSTEST PATCH] ts-xen-build-prep: Install python3-dev

AIUI I don't need to wait for that patch to be applied before applying
this series. Let me know if I'm wrong.

Wei.

> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 0/3] Default to python3

[Anthony PERARD]

On Mon, Jan 27, 2020 at 12:30:21PM +0000, Wei Liu wrote:
> On Mon, Jan 20, 2020 at 11:52:17AM +0000, Anthony PERARD wrote:
> > On Mon, Jan 20, 2020 at 11:50:50AM +0000, Anthony PERARD wrote:
> > > Patch series available in this git branch:
> > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.python3-default-v1
> > > 
> > > Hi,
> > > 
> > > I think it's time for Xen to build with python3 by default.
> > > 
> > > The main reason for that is that QEMU upstream don't build with python 2.x
> > > anymore, and the python binary selected by Xen build system is the one used
> > > when building qemu-xen. So now osstest failed to build QEMU upstream.
> > > 
> > > Also, python2 is EOL.
> > > 
> > > FYI, the hypervisor build system already select python3 by default, this change
> > > the tools side.
> > 
> > I forgot to say that there's a osstest patch as well:
> > [OSSTEST PATCH] ts-xen-build-prep: Install python3-dev
> 
> AIUI I don't need to wait for that patch to be applied before applying
> this series. Let me know if I'm wrong.

It just going to prevent a push :-). All build of staging will fail. So,
the osstest patch is needed before applying the patch 3/3.

Cheers,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 0/3] Default to python3

[Wei Liu]

On Mon, Jan 27, 2020 at 12:36:23PM +0000, Anthony PERARD wrote:
> On Mon, Jan 27, 2020 at 12:30:21PM +0000, Wei Liu wrote:
> > On Mon, Jan 20, 2020 at 11:52:17AM +0000, Anthony PERARD wrote:
> > > On Mon, Jan 20, 2020 at 11:50:50AM +0000, Anthony PERARD wrote:
> > > > Patch series available in this git branch:
> > > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.python3-default-v1
> > > > 
> > > > Hi,
> > > > 
> > > > I think it's time for Xen to build with python3 by default.
> > > > 
> > > > The main reason for that is that QEMU upstream don't build with python 2.x
> > > > anymore, and the python binary selected by Xen build system is the one used
> > > > when building qemu-xen. So now osstest failed to build QEMU upstream.
> > > > 
> > > > Also, python2 is EOL.
> > > > 
> > > > FYI, the hypervisor build system already select python3 by default, this change
> > > > the tools side.
> > > 
> > > I forgot to say that there's a osstest patch as well:
> > > [OSSTEST PATCH] ts-xen-build-prep: Install python3-dev
> > 
> > AIUI I don't need to wait for that patch to be applied before applying
> > this series. Let me know if I'm wrong.
> 
> It just going to prevent a push :-). All build of staging will fail. So,
> the osstest patch is needed before applying the patch 3/3.

Ack. I will push the first two patches first.

BTW, have you updated the docker images in Gitlab CI?

Wei.

> 
> Cheers,
> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 3/3] tools: Default to python3

[Wei Liu]

On Mon, Jan 20, 2020 at 11:50:53AM +0000, Anthony PERARD wrote:
> Main reason, newer version of QEMU doesn't support python 2.x anymore.
> Second main reason, python2 is EOL.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Wei Liu <wl@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 0/3] Default to python3

[Wei Liu]

On Mon, Jan 27, 2020 at 02:40:40PM +0000, Wei Liu wrote:
> On Mon, Jan 27, 2020 at 12:36:23PM +0000, Anthony PERARD wrote:
> > On Mon, Jan 27, 2020 at 12:30:21PM +0000, Wei Liu wrote:
> > > On Mon, Jan 20, 2020 at 11:52:17AM +0000, Anthony PERARD wrote:
> > > > On Mon, Jan 20, 2020 at 11:50:50AM +0000, Anthony PERARD wrote:
> > > > > Patch series available in this git branch:
> > > > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.python3-default-v1
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > I think it's time for Xen to build with python3 by default.
> > > > > 
> > > > > The main reason for that is that QEMU upstream don't build with python 2.x
> > > > > anymore, and the python binary selected by Xen build system is the one used
> > > > > when building qemu-xen. So now osstest failed to build QEMU upstream.
> > > > > 
> > > > > Also, python2 is EOL.
> > > > > 
> > > > > FYI, the hypervisor build system already select python3 by default, this change
> > > > > the tools side.
> > > > 
> > > > I forgot to say that there's a osstest patch as well:
> > > > [OSSTEST PATCH] ts-xen-build-prep: Install python3-dev
> > > 
> > > AIUI I don't need to wait for that patch to be applied before applying
> > > this series. Let me know if I'm wrong.
> > 
> > It just going to prevent a push :-). All build of staging will fail. So,
> > the osstest patch is needed before applying the patch 3/3.
> 
> Ack. I will push the first two patches first.
> 
> BTW, have you updated the docker images in Gitlab CI?

Never mind. You said that in the commit message already.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 0/3] Default to python3

[Anthony PERARD]

On Mon, Jan 27, 2020 at 02:40:40PM +0000, Wei Liu wrote:
> On Mon, Jan 27, 2020 at 12:36:23PM +0000, Anthony PERARD wrote:
> > On Mon, Jan 27, 2020 at 12:30:21PM +0000, Wei Liu wrote:
> > > On Mon, Jan 20, 2020 at 11:52:17AM +0000, Anthony PERARD wrote:
> > > > On Mon, Jan 20, 2020 at 11:50:50AM +0000, Anthony PERARD wrote:
> > > > > Patch series available in this git branch:
> > > > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.python3-default-v1
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > I think it's time for Xen to build with python3 by default.
> > > > > 
> > > > > The main reason for that is that QEMU upstream don't build with python 2.x
> > > > > anymore, and the python binary selected by Xen build system is the one used
> > > > > when building qemu-xen. So now osstest failed to build QEMU upstream.
> > > > > 
> > > > > Also, python2 is EOL.
> > > > > 
> > > > > FYI, the hypervisor build system already select python3 by default, this change
> > > > > the tools side.
> > > > 
> > > > I forgot to say that there's a osstest patch as well:
> > > > [OSSTEST PATCH] ts-xen-build-prep: Install python3-dev
> > > 
> > > AIUI I don't need to wait for that patch to be applied before applying
> > > this series. Let me know if I'm wrong.
> > 
> > It just going to prevent a push :-). All build of staging will fail. So,
> > the osstest patch is needed before applying the patch 3/3.
> 
> Ack. I will push the first two patches first.

osstest should be ready, could you push that last patch?

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH 0/3] Default to python3

[Wei Liu]

On Tue, Feb 11, 2020 at 11:19:02AM +0000, Anthony PERARD wrote:
> On Mon, Jan 27, 2020 at 02:40:40PM +0000, Wei Liu wrote:
> > On Mon, Jan 27, 2020 at 12:36:23PM +0000, Anthony PERARD wrote:
> > > On Mon, Jan 27, 2020 at 12:30:21PM +0000, Wei Liu wrote:
> > > > On Mon, Jan 20, 2020 at 11:52:17AM +0000, Anthony PERARD wrote:
> > > > > On Mon, Jan 20, 2020 at 11:50:50AM +0000, Anthony PERARD wrote:
> > > > > > Patch series available in this git branch:
> > > > > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.python3-default-v1
> > > > > > 
> > > > > > Hi,
> > > > > > 
> > > > > > I think it's time for Xen to build with python3 by default.
> > > > > > 
> > > > > > The main reason for that is that QEMU upstream don't build with python 2.x
> > > > > > anymore, and the python binary selected by Xen build system is the one used
> > > > > > when building qemu-xen. So now osstest failed to build QEMU upstream.
> > > > > > 
> > > > > > Also, python2 is EOL.
> > > > > > 
> > > > > > FYI, the hypervisor build system already select python3 by default, this change
> > > > > > the tools side.
> > > > > 
> > > > > I forgot to say that there's a osstest patch as well:
> > > > > [OSSTEST PATCH] ts-xen-build-prep: Install python3-dev
> > > > 
> > > > AIUI I don't need to wait for that patch to be applied before applying
> > > > this series. Let me know if I'm wrong.
> > > 
> > > It just going to prevent a push :-). All build of staging will fail. So,
> > > the osstest patch is needed before applying the patch 3/3.
> > 
> > Ack. I will push the first two patches first.
> 
> osstest should be ready, could you push that last patch?

Pushed.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel