From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Julien Grall" <jgrall@amazon.com>,
"Jan Beulich" <jbeulich@suse.com>,
"David Woodhouse" <dwmw@amazon.co.uk>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain
Date: Mon, 20 Jan 2020 14:31:42 +0000 [thread overview]
Message-ID: <20200120143142.19820-1-julien@xen.org> (raw)
From: Julien Grall <jgrall@amazon.com>
The structure domain may be bigger than a page size when lock profiling
is enabled. However, the function free_domheap_struct will only free the
first page.
This is not a security issue because struct domain can only be bigger
than a page size for lock profiling. The feature can only be selected
in DEBUG and EXPERT mode.
Fixes: 8916fcf4577 ("x86/domain: compile with lock_profile=y enabled")
Reported-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
xen/arch/x86/domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index 28fefa1f81..a5380b9bab 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -344,7 +344,7 @@ struct domain *alloc_domain_struct(void)
void free_domain_struct(struct domain *d)
{
- free_xenheap_page(d);
+ free_xenheap_pages(d, get_order_from_bytes(sizeof(*d)));
}
struct vcpu *alloc_vcpu_struct(const struct domain *d)
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2020-01-20 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 14:31 Julien Grall [this message]
2020-01-20 14:40 ` [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain Jan Beulich
2020-01-20 14:50 ` Roger Pau Monné
2020-01-22 12:52 ` Andrew Cooper
2020-01-22 13:13 ` Julien Grall
2020-01-22 13:15 ` Andrew Cooper
2020-01-22 13:50 ` Woodhouse, David
2020-01-22 14:23 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120143142.19820-1-julien@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=dwmw@amazon.co.uk \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).