From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B04CC2D0CE for ; Tue, 21 Jan 2020 21:12:42 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69BDA24653 for ; Tue, 21 Jan 2020 21:12:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="irxjw845" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69BDA24653 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=invisiblethingslab.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iu0p3-0006zr-4u; Tue, 21 Jan 2020 21:12:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iu0p1-0006zk-Pn for xen-devel@lists.xenproject.org; Tue, 21 Jan 2020 21:12:27 +0000 X-Inumbo-ID: b4915298-3c92-11ea-9fd7-bc764e2007e4 Received: from wout4-smtp.messagingengine.com (unknown [64.147.123.20]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b4915298-3c92-11ea-9fd7-bc764e2007e4; Tue, 21 Jan 2020 21:12:18 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 53B33613; Tue, 21 Jan 2020 16:12:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 21 Jan 2020 16:12:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=BmA75i cf6gD6deYOJBbbE9gPagvqpxINpgOMfzuwOTk=; b=irxjw845KUFKFSBTtu6MAX tR1/9gbFaOuyQ0jbSZ+1syRcw1cruofVIb/4oTF9oL/ulJ3wLls+qn0sqii/a7+1 mhPWxWlGJ+38Ap+gQM4HOtsTREnuH58Lbxu5+tNg51CB/edAZporyNNA5oa+FPHa lVspW7DMCGnKHbu0FA2/8lxJwsTCEbcX0Fc2PqzaM++r8XP69xTcDFtIYy4rSGLL XAH/eB4RfOaVGUcvH5UoyyUvNNhGc5LTPNXud7NsO/fMS1Y9FbQRmkl0t51ao1rI ZfNDKe1HUqTdbggMFYHmIrORov75wIomPSnLDy8KoaehJEgGHaoNUV7iG+rH7XQA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudekgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucfkphepledurdeihedrfeegrdef feenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg hrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Received: from mail-itl (ip5b412221.dynamic.kabel-deutschland.de [91.65.34.33]) by mail.messagingengine.com (Postfix) with ESMTPA id D8AFD3060A36; Tue, 21 Jan 2020 16:12:15 -0500 (EST) Date: Tue, 21 Jan 2020 22:12:12 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Message-ID: <20200121211212.GP1314@mail-itl> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [Xen-devel] [PATCH v4 04/16] libxl: Allow running qemu-xen in stubdomain X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , xen-devel , Ian Jackson , Wei Liu Content-Type: multipart/mixed; boundary="===============8958961722546624155==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============8958961722546624155== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H8fFO+isr9ADh2Iv" Content-Disposition: inline --H8fFO+isr9ADh2Iv Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Xen-devel] [PATCH v4 04/16] libxl: Allow running qemu-xen in stubdomain On Mon, Jan 20, 2020 at 01:56:51PM -0500, Jason Andryuk wrote: > On Tue, Jan 14, 2020 at 9:41 PM Marek Marczykowski-G=C3=B3recki > wrote: > > > > Do not prohibit anymore using stubdomain with qemu-xen. > > To help distingushing MiniOS and Linux stubdomain, add helper inline > > functions libxl__stubdomain_is_linux() and > > libxl__stubdomain_is_linux_running(). Those should be used where really > > the difference is about MiniOS/Linux, not qemu-xen/qemu-xen-traditional. > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > > > --- > > Changes in v3: > > - new patch, instead of "libxl: Add "stubdomain_version" to > > domain_build_info" > > - helper functions as suggested by Ian Jackson > > --- >=20 > >=20 > > --- a/tools/libxl/libxl_internal.h > > +++ b/tools/libxl/libxl_internal.h > > @@ -2299,6 +2299,23 @@ _hidden int libxl__device_model_version_running(= libxl__gc *gc, uint32_t domid); > > /* Return the system-wide default device model */ > > _hidden libxl_device_model_version libxl__default_device_model(libxl__= gc *gc); > > > > +static inline > > +bool libxl__stubdomain_is_linux_running(libxl__gc *gc, uint32_t domid) >=20 > This is unused in the series, as far as I can tell. Yes, all the calls are commented out, as exact same condition is implied =66rom the context. But I think a canonical function to do that is still useful, if needed anywhere in the codebase in the future. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --H8fFO+isr9ADh2Iv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl4naSwACgkQ24/THMrX 1yy/hQf/Wv8ioRbqPmqqA/ZUumpwWIf1IGieVEJCiVNxtPaaQ4DbxY5ToN6jpjgl BigJVlpANdGAtU8eHaofdrPSZYCwr8bO5JzTEWmMAAulV58D5I6asMA1U5T6pT9d uq1SPJku+lOwKBv3IAWPMMiOpW4YzBAGjkD0atJBCZzw2ZEOoP5jSH6UoDTUKWXC njuF3OsZnmhcUhziLEnKIuOjbyvIIh5WVA2maeJf+1d/SdZcERWiPeRPsjUBLN4f 7sj9zlDb7cZ79Wzu5BrrgP7pnnrHmpvDXK3ZwNlekygjYbOegMbWAWqmWYCF0BbX cITpD1a9DSoSg8d6pfCbiefdKVP6wg== =xwcO -----END PGP SIGNATURE----- --H8fFO+isr9ADh2Iv-- --===============8958961722546624155== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============8958961722546624155==--