From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com> To: Jason Andryuk <jandryuk@gmail.com> Cc: Wei Liu <wl@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Simon Gaiser <simon@invisiblethingslab.com>, Anthony PERARD <anthony.perard@citrix.com>, xen-devel <xen-devel@lists.xenproject.org>, Eric Shelton <eshelton@pobox.com> Subject: Re: [Xen-devel] [PATCH v4 05/16] libxl: Handle Linux stubdomain specific QEMU options. Date: Tue, 21 Jan 2020 22:18:35 +0100 [thread overview] Message-ID: <20200121211835.GQ1314@mail-itl> (raw) In-Reply-To: <CAKf6xpv--A2zUieSAY47L9dppsP43rd=zrJdVB_Rxps3CWTnqQ@mail.gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 3467 bytes --] On Mon, Jan 20, 2020 at 02:24:18PM -0500, Jason Andryuk wrote: > On Tue, Jan 14, 2020 at 9:42 PM Marek Marczykowski-Górecki > <marmarek@invisiblethingslab.com> wrote: > > > > From: Eric Shelton <eshelton@pobox.com> > > > > This patch creates an appropriate command line for the QEMU instance > > running in a Linux-based stubdomain. > > > > NOTE: a number of items are not currently implemented for Linux-based > > stubdomains, such as: > > - save/restore > > - QMP socket > > - graphics output (e.g., VNC) > > > > Signed-off-by: Eric Shelton <eshelton@pobox.com> > > > > Simon: > > * fix disk path > > * fix cdrom path and "format" > > * pass downscript for network interfaces > > Since this is here... > > > Signed-off-by: Simon Gaiser <simon@invisiblethingslab.com> > > [drop Qubes-specific parts] > > ...maybe mention dropping downscript here? Otherwise the commit > message and contents don't match. Ah, indeed. > > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> > > --- > > <snip> > > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > > index 142b960..a6d40b7 100644 > > --- a/tools/libxl/libxl_create.c > > +++ b/tools/libxl/libxl_create.c > > @@ -169,6 +169,31 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, > > } > > } > > > > + if (b_info->type == LIBXL_DOMAIN_TYPE_HVM && > > + libxl_defbool_val(b_info->device_model_stubdomain)) { > > + if (!b_info->stubdomain_kernel) { > > + switch (b_info->device_model_version) { > > + case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL: > > + b_info->stubdomain_kernel = > > + libxl__abs_path(NOGC, "ioemu-stubdom.gz", libxl__xenfirmwaredir_path()); > > + b_info->stubdomain_ramdisk = NULL; > > + break; > > + case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN: > > + b_info->stubdomain_kernel = > > + libxl__abs_path(NOGC, > > + "stubdom-linux-kernel", > > Not to bikeshed, but this came up in a conversation a little while > ago. Stubdom is a generic name, and this code is for a device model. > So some combination of qemu{,-dm}{,-linux}-kernel seems more > descriptive. Minios-based use ioemu-stubdom, so maybe ioemu-stubdom-linux-{kernel,rootfs}? > Having said that, I'm fine with it as is since I don't imagine more > stubdoms showing up. > > > + libxl__xenfirmwaredir_path()); > > + b_info->stubdomain_ramdisk = > > + libxl__abs_path(NOGC, > > + "stubdom-linux-rootfs", > > + libxl__xenfirmwaredir_path()); > > + break; > > + default: > > + abort(); > > Can we return an error instead? For invalid enum value? > > + } > > + } > > + } > > + > > if (!b_info->max_vcpus) > > b_info->max_vcpus = 1; > > if (!b_info->avail_vcpus.size) { > > <snip> > > Reviewed-by: Jason Andryuk <jandryuk@gmail.com> -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-21 21:19 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-15 2:39 [Xen-devel] [PATCH v4 00/16] Add support for qemu-xen runnning in a Linux-based stubdomain Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 01/16] Document ioemu MiniOS stubdomain protocol Marek Marczykowski-Górecki 2020-01-20 18:30 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 02/16] Document ioemu Linux " Marek Marczykowski-Górecki 2020-01-20 18:54 ` Jason Andryuk 2020-01-21 21:08 ` Marek Marczykowski-Górecki 2020-01-22 14:04 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 03/16] libxl: fix qemu-trad cmdline for no sdl/vnc case Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 04/16] libxl: Allow running qemu-xen in stubdomain Marek Marczykowski-Górecki 2020-01-20 18:56 ` Jason Andryuk 2020-01-21 21:12 ` Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 05/16] libxl: Handle Linux stubdomain specific QEMU options Marek Marczykowski-Górecki 2020-01-20 19:24 ` Jason Andryuk 2020-01-21 21:18 ` Marek Marczykowski-Górecki [this message] 2020-01-22 14:25 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 06/16] libxl: write qemu arguments into separate xenstore keys Marek Marczykowski-Górecki 2020-01-20 19:36 ` Jason Andryuk 2020-01-21 21:19 ` Marek Marczykowski-Górecki 2020-01-22 14:39 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 07/16] xl: add stubdomain related options to xl config parser Marek Marczykowski-Górecki 2020-01-20 19:41 ` Jason Andryuk 2020-01-21 21:22 ` Marek Marczykowski-Górecki 2020-01-22 14:39 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 08/16] tools/libvchan: notify server when client is connected Marek Marczykowski-Górecki 2020-01-20 19:44 ` Jason Andryuk 2020-01-21 21:28 ` Marek Marczykowski-Górecki 2020-01-22 14:43 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 09/16] libxl: add save/restore support for qemu-xen in stubdomain Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 10/16] tools: add missing libxenvchan cflags Marek Marczykowski-Górecki 2020-01-20 19:58 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 11/16] tools: add simple vchan-socket-proxy Marek Marczykowski-Górecki 2020-01-15 11:02 ` Jan Beulich 2020-01-16 17:11 ` Marek Marczykowski-Górecki 2020-01-17 8:13 ` Jan Beulich 2020-01-17 18:44 ` Rich Persaud 2020-01-17 18:56 ` Marek Marczykowski-Górecki 2020-01-21 19:43 ` Jason Andryuk 2020-01-21 23:09 ` Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 12/16] libxl: use vchan for QMP access with Linux stubdomain Marek Marczykowski-Górecki 2020-01-21 20:17 ` Jason Andryuk 2020-01-21 23:46 ` Marek Marczykowski-Górecki 2020-01-24 14:05 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 13/16] Regenerate autotools files Marek Marczykowski-Górecki 2020-01-15 21:57 ` Rich Persaud 2020-01-21 20:56 ` Marek Marczykowski-Górecki 2020-01-21 21:28 ` Rich Persaud 2020-01-22 8:57 ` Lars Kurth 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 14/16] libxl: require qemu in dom0 even if stubdomain is in use Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 15/16] libxl: ignore emulated IDE disks beyond the first 4 Marek Marczykowski-Górecki 2020-01-21 20:24 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 16/16] libxl: consider also qemu in stubdomain in libxl__dm_active check Marek Marczykowski-Górecki 2020-01-21 20:25 ` Jason Andryuk 2020-01-22 16:50 ` [Xen-devel] [PATCH v4 00/16] Add support for qemu-xen runnning in a Linux-based stubdomain Jason Andryuk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200121211835.GQ1314@mail-itl \ --to=marmarek@invisiblethingslab.com \ --cc=anthony.perard@citrix.com \ --cc=eshelton@pobox.com \ --cc=ian.jackson@eu.citrix.com \ --cc=jandryuk@gmail.com \ --cc=simon@invisiblethingslab.com \ --cc=wl@xen.org \ --cc=xen-devel@lists.xenproject.org \ --subject='Re: [Xen-devel] [PATCH v4 05/16] libxl: Handle Linux stubdomain specific QEMU options.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).