Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [Xen-devel] [PATCH] libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c
@ 2020-02-13 15:27 Wei Liu
  2020-02-13 15:30 ` Anthony PERARD
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2020-02-13 15:27 UTC (permalink / raw)
  To: Xen Development List
  Cc: Anthony PERARD, Andrew Cooper, Julien Grall, Ian Jackson, Wei Liu

Its last parameter should be libxl_domain_build_info.

Fixes: 1b3cec69 ("tools/libxl: Combine legacy CPUID handling logic")
Signed-off-by: Wei Liu <wl@xen.org>
---
 tools/libxl/libxl_nocpuid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_nocpuid.c b/tools/libxl/libxl_nocpuid.c
index 7776574a0c..3f30e148be 100644
--- a/tools/libxl/libxl_nocpuid.c
+++ b/tools/libxl/libxl_nocpuid.c
@@ -35,7 +35,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid,
 }
 
 void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid,
-                         libxl_domain_config *d_config)
+                         libxl_domain_build_info *info)
 {
 }
 
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Xen-devel] [PATCH] libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c
  2020-02-13 15:27 [Xen-devel] [PATCH] libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c Wei Liu
@ 2020-02-13 15:30 ` Anthony PERARD
  2020-02-13 15:32   ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Anthony PERARD @ 2020-02-13 15:30 UTC (permalink / raw)
  To: Wei Liu; +Cc: Xen Development List, Julien Grall, Ian Jackson, Andrew Cooper

On Thu, Feb 13, 2020 at 03:27:51PM +0000, Wei Liu wrote:
> Its last parameter should be libxl_domain_build_info.
> 
> Fixes: 1b3cec69 ("tools/libxl: Combine legacy CPUID handling logic")
> Signed-off-by: Wei Liu <wl@xen.org>
> ---
>  tools/libxl/libxl_nocpuid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_nocpuid.c b/tools/libxl/libxl_nocpuid.c
> index 7776574a0c..3f30e148be 100644
> --- a/tools/libxl/libxl_nocpuid.c
> +++ b/tools/libxl/libxl_nocpuid.c
> @@ -35,7 +35,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid,
>  }
>  
>  void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid,
> -                         libxl_domain_config *d_config)
> +                         libxl_domain_build_info *info)
>  {
>  }
>  

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Xen-devel] [PATCH] libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c
  2020-02-13 15:30 ` Anthony PERARD
@ 2020-02-13 15:32   ` Wei Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2020-02-13 15:32 UTC (permalink / raw)
  To: Anthony PERARD
  Cc: Xen Development List, Julien Grall, Ian Jackson, Wei Liu, Andrew Cooper

On Thu, Feb 13, 2020 at 03:30:19PM +0000, Anthony PERARD wrote:
> On Thu, Feb 13, 2020 at 03:27:51PM +0000, Wei Liu wrote:
> > Its last parameter should be libxl_domain_build_info.
> > 
> > Fixes: 1b3cec69 ("tools/libxl: Combine legacy CPUID handling logic")
> > Signed-off-by: Wei Liu <wl@xen.org>
> > ---
> >  tools/libxl/libxl_nocpuid.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/libxl/libxl_nocpuid.c b/tools/libxl/libxl_nocpuid.c
> > index 7776574a0c..3f30e148be 100644
> > --- a/tools/libxl/libxl_nocpuid.c
> > +++ b/tools/libxl/libxl_nocpuid.c
> > @@ -35,7 +35,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid,
> >  }
> >  
> >  void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid,
> > -                         libxl_domain_config *d_config)
> > +                         libxl_domain_build_info *info)
> >  {
> >  }
> >  
> 
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks, pushed.

This should unblock Osstest and Gitlab CI.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 15:27 [Xen-devel] [PATCH] libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c Wei Liu
2020-02-13 15:30 ` Anthony PERARD
2020-02-13 15:32   ` Wei Liu

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git