From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v4 7/7] x86/tlb: use Xen L0 assisted TLB flush when available
Date: Tue, 18 Feb 2020 13:42:40 +0100 [thread overview]
Message-ID: <20200218124240.GV4679@Air-de-Roger> (raw)
In-Reply-To: <20200210172829.43604-8-roger.pau@citrix.com>
On Mon, Feb 10, 2020 at 06:28:29PM +0100, Roger Pau Monne wrote:
> @@ -256,6 +257,16 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags)
> if ( (flags & ~FLUSH_ORDER_MASK) &&
> !cpumask_subset(mask, cpumask_of(cpu)) )
> {
> + if ( cpu_has_hypervisor &&
> + !(flags & ~(FLUSH_TLB | FLUSH_TLB_GLOBAL | FLUSH_VA_VALID |
> + FLUSH_ORDER_MASK)) &&
> + !hypervisor_flush_tlb(mask, va, flags & FLUSH_ORDER_MASK) )
This needs to be adjusted to (flags - 1) & FLUSH_ORDER_MASK.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2020-02-18 12:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 17:28 [Xen-devel] [PATCH v4 0/7] x86: improve assisted tlb flush and use it in guest mode Roger Pau Monne
2020-02-10 17:28 ` [Xen-devel] [PATCH v4 1/7] x86/hvm: allow ASID flush when v != current Roger Pau Monne
2020-02-10 17:28 ` [Xen-devel] [PATCH v4 2/7] x86/paging: add TLB flush hooks Roger Pau Monne
2020-02-13 9:02 ` Tim Deegan
2020-02-13 9:03 ` Tim Deegan
2020-02-10 17:28 ` [Xen-devel] [PATCH v4 3/7] x86/hap: improve hypervisor assisted guest TLB flush Roger Pau Monne
2020-02-10 17:28 ` [Xen-devel] [PATCH v4 4/7] x86/tlb: introduce a flush guests TLB flag Roger Pau Monne
2020-02-13 9:02 ` Tim Deegan
2020-02-10 17:28 ` [Xen-devel] [PATCH v4 5/7] x86/tlb: allow disabling the TLB clock Roger Pau Monne
2020-02-10 20:09 ` Wei Liu
2020-02-10 17:28 ` [Xen-devel] [PATCH v4 6/7] xen/guest: prepare hypervisor ops to use alternative calls Roger Pau Monne
2020-02-10 20:10 ` Wei Liu
2020-02-11 9:52 ` Durrant, Paul
2020-02-10 17:28 ` [Xen-devel] [PATCH v4 7/7] x86/tlb: use Xen L0 assisted TLB flush when available Roger Pau Monne
2020-02-10 20:16 ` Wei Liu
2020-02-11 10:34 ` Wei Liu
2020-02-11 14:06 ` Roger Pau Monné
2020-02-11 14:08 ` Wei Liu
2020-02-18 12:42 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218124240.GV4679@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).