From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Jürgen Groß" <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH 2/2] xen: enable BALLOON_MEMORY_HOTPLUG by default
Date: Tue, 24 Mar 2020 16:16:28 +0100 [thread overview]
Message-ID: <20200324151628.GM24458@Air-de-Roger.citrite.net> (raw)
In-Reply-To: <f4ce1d95-c80a-8727-7ddc-9199bb2036c4@suse.com>
On Tue, Mar 24, 2020 at 04:09:35PM +0100, Jürgen Groß wrote:
> On 24.03.20 16:00, Roger Pau Monne wrote:
> > Without it a PVH dom0 is mostly useless, as it would balloon down huge
> > amounts of RAM in order get physical address space to map foreign
> > memory and grants, ultimately leading to an out of memory situation.
> >
> > Such option is also needed for HVM or PVH driver domains, since they
> > also require mapping grants into physical memory regions.
> >
> > Suggested-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Cc: Juergen Gross <jgross@suse.com>
> > Cc: Stefano Stabellini <sstabellini@kernel.org>
> > Cc: xen-devel@lists.xenproject.org
> > ---
> > drivers/xen/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> > index 57ddd6f4b729..c344bcffd89d 100644
> > --- a/drivers/xen/Kconfig
> > +++ b/drivers/xen/Kconfig
> > @@ -13,6 +13,7 @@ config XEN_BALLOON
> > config XEN_BALLOON_MEMORY_HOTPLUG
> > bool "Memory hotplug support for Xen balloon driver"
> > depends on XEN_BALLOON && MEMORY_HOTPLUG
> > + default y
> > help
> > Memory hotplug support for Xen balloon driver allows expanding memory
> > available for the system above limit declared at system startup.
> >
>
> Another variant would be to set: default XEN_BACKEND
>
> This would match the reasoning for switching it on.
I would rather have it always on if possible, as gntdev or privcmd
(when used to map foreign pages from user-space) will also require it,
and they are not gated on XEN_BACKEND AFAICT.
> Either way would be fine with me, so you can add
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks!
Roger.
next prev parent reply other threads:[~2020-03-24 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 15:00 [Xen-devel] [PATCH 1/2] xen: expand BALLOON_MEMORY_HOTPLUG description Roger Pau Monne
2020-03-24 15:00 ` [Xen-devel] [PATCH 2/2] xen: enable BALLOON_MEMORY_HOTPLUG by default Roger Pau Monne
2020-03-24 15:09 ` Jürgen Groß
2020-03-24 15:16 ` Roger Pau Monné [this message]
2020-03-26 17:13 ` Ian Jackson
2020-03-24 15:13 ` [Xen-devel] [PATCH 1/2] xen: expand BALLOON_MEMORY_HOTPLUG description Jürgen Groß
2020-03-24 15:18 ` Roger Pau Monné
2020-03-24 15:20 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324151628.GM24458@Air-de-Roger.citrite.net \
--to=roger.pau@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).