From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCDF2C43331 for ; Thu, 26 Mar 2020 09:22:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B27120719 for ; Thu, 26 Mar 2020 09:22:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="dxSuP/UY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B27120719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHOiU-00071w-W4; Thu, 26 Mar 2020 09:22:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHOiT-00071n-R9 for xen-devel@lists.xenproject.org; Thu, 26 Mar 2020 09:22:21 +0000 X-Inumbo-ID: 4b78d11c-6f43-11ea-8783-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4b78d11c-6f43-11ea-8783-12813bfff9fa; Thu, 26 Mar 2020 09:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1585214541; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=p8sgprJDqKUklDw8JW3drdsx2PRBFIqaAi7+jRxIl0U=; b=dxSuP/UYhxyak9Y1qzqOY6qZodErGOu2BZF004pWSoO8+sVBvClKiGQH ONQBrNNzHNrgq3BO4Oz76TjMsJPrgXCbcW2LjDEqp8PKfdSmw/FtRu95k 6byW0o7w1LQVeefhyup6Gyif15SWNHNeAan0JHTmZLFtH0sokWISgBZ/G U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: d923fPSjPf56WB7vzMrkBQ1b8o8s8L7NT1652GWvQdASu5u1KBri1fej36VEAAogb+E9dV+4aX TDJpKG/3tMrIW9drX9rx9xQ/+/XY5nrwT23LVveJYck+U4aGVXY8uHYB6XOwLe+kUHbMsLFRJn HeVymRO0gjwQxzTJMmPLPnC2BFaWdsSVqRUfwRQhGNVL8Xj7SUo0zRwhy2p4RL6/466aptXUTZ iYm8djxOF08tZqAir1cydsBb0KhUT4Gowc/GpBxY9zYwkYDhXHimbmigB0aAFhRTkt/2Wwax55 dV4= X-SBRS: 2.7 X-MesageID: 15078911 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,307,1580792400"; d="scan'208";a="15078911" Date: Thu, 26 Mar 2020 10:22:13 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "Tian, Kevin" Message-ID: <20200326092213.GK28601@Air-de-Roger> References: <20200325101910.29168-1-roger.pau@citrix.com> <20200325101910.29168-5-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) Subject: Re: [Xen-devel] [PATCH v2 4/4] x86/nvmx: update exit bitmap when using virtual interrupt delivery X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , Jan Beulich , "Nakajima, Jun" , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, Mar 26, 2020 at 03:17:59AM +0000, Tian, Kevin wrote: > > From: Roger Pau Monne > > Sent: Wednesday, March 25, 2020 6:19 PM > > > > Force an update of the EOI exit bitmap in nvmx_update_apicv, because > > the one performed in vmx_intr_assist might not be reached if the > > interrupt is intercepted by nvmx_intr_intercept returning true. > > > > Extract the code to update the exit bitmap from vmx_intr_assist into a > > helper and use it in nvmx_update_apicv. > > > > Signed-off-by: Roger Pau Monné > > --- > > Changes since v1: > > - Reword commit message. > > --- > > xen/arch/x86/hvm/vmx/intr.c | 21 +++++++++++++-------- > > xen/arch/x86/hvm/vmx/vvmx.c | 2 ++ > > xen/include/asm-x86/hvm/vmx/vmx.h | 2 ++ > > 3 files changed, 17 insertions(+), 8 deletions(-) > > > > diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c > > index 49a1295f09..000e14af49 100644 > > --- a/xen/arch/x86/hvm/vmx/intr.c > > +++ b/xen/arch/x86/hvm/vmx/intr.c > > @@ -224,6 +224,18 @@ static int nvmx_intr_intercept(struct vcpu *v, struct > > hvm_intack intack) > > return 0; > > } > > > > +void vmx_sync_exit_bitmap(struct vcpu *v) > > +{ > > + const unsigned int n = ARRAY_SIZE(v->arch.hvm.vmx.eoi_exit_bitmap); > > + unsigned int i; > > + > > + while ( (i = find_first_bit(&v->arch.hvm.vmx.eoi_exitmap_changed, n)) < > > n ) > > + { > > + clear_bit(i, &v->arch.hvm.vmx.eoi_exitmap_changed); > > + __vmwrite(EOI_EXIT_BITMAP(i), v->arch.hvm.vmx.eoi_exit_bitmap[i]); > > + } > > +} > > + > > void vmx_intr_assist(void) > > { > > struct hvm_intack intack; > > @@ -318,7 +330,6 @@ void vmx_intr_assist(void) > > intack.source != hvm_intsrc_vector ) > > { > > unsigned long status; > > - unsigned int i, n; > > > > /* > > * intack.vector is the highest priority vector. So we set eoi_exit_bitmap > > @@ -379,13 +390,7 @@ void vmx_intr_assist(void) > > intack.vector; > > __vmwrite(GUEST_INTR_STATUS, status); > > > > - n = ARRAY_SIZE(v->arch.hvm.vmx.eoi_exit_bitmap); > > - while ( (i = find_first_bit(&v->arch.hvm.vmx.eoi_exitmap_changed, > > - n)) < n ) > > - { > > - clear_bit(i, &v->arch.hvm.vmx.eoi_exitmap_changed); > > - __vmwrite(EOI_EXIT_BITMAP(i), v->arch.hvm.vmx.eoi_exit_bitmap[i]); > > - } > > + vmx_sync_exit_bitmap(v); > > > > pt_intr_post(v, intack); > > } > > diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c > > index 8431c912a1..845dd87f75 100644 > > --- a/xen/arch/x86/hvm/vmx/vvmx.c > > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > > @@ -1418,6 +1418,8 @@ static void nvmx_update_apicv(struct vcpu *v) > > status |= rvi & VMX_GUEST_INTR_STATUS_SUBFIELD_BITMASK; > > __vmwrite(GUEST_INTR_STATUS, status); > > } > > + > > + vmx_sync_exit_bitmap(v); > > Similarly, I'd like to do the sync within the conditional block, when intr > status is actually changed. Otherwise, it becomes checking bitmap change > in every vmentry when apicv is enabled. No - it will only check the bitmap when there's a virtual vmexit (which is where nvmx_update_apicv gets called), not on every vmentry. I can try to do this conditionally on whether GUEST_INTR_STATUS is actually changed. Thanks, Roger.