From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92466C43331 for ; Thu, 26 Mar 2020 14:17:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60218206F8 for ; Thu, 26 Mar 2020 14:17:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="RFFTLhGs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60218206F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHTJX-00081e-CU; Thu, 26 Mar 2020 14:16:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHTJW-00081X-0n for xen-devel@lists.xenproject.org; Thu, 26 Mar 2020 14:16:54 +0000 X-Inumbo-ID: 6fea5af7-6f6c-11ea-87f1-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6fea5af7-6f6c-11ea-87f1-12813bfff9fa; Thu, 26 Mar 2020 14:16:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1585232212; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=TesHsCUYgcxK4YVl/u4XwvPWjveS41a+p8Zw4ZxNTtQ=; b=RFFTLhGsIbSwPrUn4CCzIfDLpOQs0cGaYeKObRD+SygCAz9fO0+jrcAL ssTTh1KG4Om91DBnrSGp6Nbk+YL1GCUnFieMSUq1Fk6YAPFJ3H6rS1NDO c20vtWU4XBWdoM2+Z67Wpl44qPRWt5uhJVPR7IUk6nKM13SBYcianjjgW U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: zjdPUFy9XLZff5bAzHsLgumJZAktGGAb5Ku8yOObXz1d7ezAlgyrTEcpGNT+WArnCFhfhrgjra x4a8xBTStchxfeTErL6aOA5jN30lu+/48WQuj3mL2a+IK0v47lhyo5a/Vubt7NXQQVyXpDARh6 pKLvCWCpZ6mk7r+lkSA/GMRUwz/rX6Z+i+9OVKxNKkMNZ4sArz/D2/JOGlOrDYWx0LQlV5X65g 4aBxI4PvKW0t8tpmczK/7uKUAkWv+yraRabsMuT0McDIeZjWhoOdFYZv2CfYV8Tqag5gIKC0xI Bg8= X-SBRS: 2.7 X-MesageID: 15095812 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,308,1580792400"; d="scan'208";a="15095812" Date: Thu, 26 Mar 2020 14:16:47 +0000 From: Anthony PERARD To: Andrew Cooper Message-ID: <20200326141647.GQ4088@perard.uk.xensource.com> References: <20200326135621.687685-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Xen-devel] [XEN PATCH] build: detect compiler upgrade to rerun kconfig X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , George Dunlap , Jan Beulich , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, Mar 26, 2020 at 02:02:43PM +0000, Andrew Cooper wrote: > On 26/03/2020 13:56, Anthony PERARD wrote: > > This simple comment allows to detect when $(CC) changes version. > > Kconfig will be rerun in this case. (Rerun is forced by > > include/config.auto.cmd which detects changes of CC_VERSION_TEXT :-(, there's a typo here, the path should read "include/config/auto.conf.cmd". > > value). > > > > Signed-off-by: Anthony PERARD > > I'd suggest s/upgrade/change/ in the subject.  When developing with two > different compilers, one half of the transitions will be a downgrade. Change of $(CC) is already been taken care of ;-). "upgrade" is what Linux choose to call it but "change" might be ok too. > Acked-by: Andrew Cooper Thanks, -- Anthony PERARD