From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E9EC43331 for ; Sun, 29 Mar 2020 15:06:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A739E206F6 for ; Sun, 29 Mar 2020 15:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="kw82nO5x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A739E206F6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIZW0-0002S6-Jh; Sun, 29 Mar 2020 15:06:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIZVy-0002Rw-N5 for xen-devel@lists.xenproject.org; Sun, 29 Mar 2020 15:06:18 +0000 X-Inumbo-ID: d7aaf4ca-71ce-11ea-8dc2-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d7aaf4ca-71ce-11ea-8dc2-12813bfff9fa; Sun, 29 Mar 2020 15:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=G5TG6PvSswYxLq0WZax9kWMsErb71loqaeBmAya/O7Y=; b=kw82nO5x4yVig1VdQuARNoOmnU BXrSh+1QwwgldQdc04cODLV04HTxjYwb7F/9XSch54WocIbEgzOMo1DqPE4WDRBGckSZpt7IHP/Ht YTvPhgW3Lebe03JmHfj1D7j5pv1XRmcssicSCSyr5x91NCe0uRDaDKxSa9ZcOpQzeesg=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIZVx-0005MO-PI; Sun, 29 Mar 2020 15:06:17 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jIZVx-0005Jd-DY; Sun, 29 Mar 2020 15:06:17 +0000 Date: Sun, 29 Mar 2020 16:06:14 +0100 From: Wei Liu To: Hongyan Xia Message-ID: <20200329150614.ofsg7tiipxz35ucc@debian> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Subject: Re: [Xen-devel] [PATCH 0/5] use new API for Xen page tables X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , Jan Beulich , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Mar 23, 2020 at 09:41:37AM +0000, Hongyan Xia wrote: > From: Hongyan Xia > > This small series is basically just rewriting functions using the new > API to map and unmap PTEs. Each patch is independent. > > Apart from mapping and unmapping page tables, no other functional change > intended. > The code looks correct to me. I do wonder if you should've put your SoB instead of Rb in some of the patches. Wei.