From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C08AEC83000 for ; Tue, 28 Apr 2020 15:00:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 914B6206D8 for ; Tue, 28 Apr 2020 15:00:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="6/zrzz9b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 914B6206D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTRiU-00022c-VA; Tue, 28 Apr 2020 15:00:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTRiT-00021D-Oi for xen-devel@lists.xenproject.org; Tue, 28 Apr 2020 15:00:09 +0000 X-Inumbo-ID: f3ae3dfe-8960-11ea-ae69-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f3ae3dfe-8960-11ea-ae69-bc764e2007e4; Tue, 28 Apr 2020 15:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=J+NHKJa/jRyEJy0/LP08QbrjXlFQcDFOHxnhibHPQfE=; b=6/zrzz9bCHr8cUroV/z0uHJMpm 30zqYAWmCaqNaVRFIQHCheQUyopBRA4eKHPjn2kGPMT/SHgEng3NlpqfQ45Vx3iIvubs06jn6Zn/N svzrGXhB9EftTC46wAW4GJ6Vc6BT53QlkdO9DAvHK0uoSUgOsnSpqvApamtKPcZR4BGw=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTRiS-0006Q3-0q; Tue, 28 Apr 2020 15:00:08 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jTRiR-0002hr-L7; Tue, 28 Apr 2020 15:00:07 +0000 Date: Tue, 28 Apr 2020 16:00:04 +0100 From: Wei Liu To: Juergen Gross Subject: Re: [PATCH] tools/xenstore: simplify socket initialization Message-ID: <20200428150004.le3ic6rla2erpfnq@debian> References: <20200428145837.6099-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428145837.6099-1-jgross@suse.com> User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Apr 28, 2020 at 04:58:37PM +0200, Juergen Gross wrote: > The setup of file descriptors for the Xenstore sockets is needlessly > complicated: the space is allocated dynamically, while two static > variables really would do the job. > > For tearing down the sockets it is easier to widen the scope of the > file descriptors from function to file. > > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu