From: Wei Liu <wl@xen.org>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 3/3] tools/libxl: disable clang indentation check for the disk parser
Date: Wed, 6 May 2020 14:07:41 +0100 [thread overview]
Message-ID: <20200506130741.lgpi4gduon7cqnup@debian> (raw)
In-Reply-To: <20200505092454.9161-4-roger.pau@citrix.com>
On Tue, May 05, 2020 at 11:24:54AM +0200, Roger Pau Monne wrote:
> Clang 10 complains with:
>
> 13: error: misleading indentation; statement is not part of the previous 'if'
> [-Werror,-Wmisleading-indentation]
> if ( ! yyg->yy_state_buf )
> ^
> libxlu_disk_l.c:1259:9: note: previous statement is here
> if ( ! yyg->yy_state_buf )
> ^
>
> Due to the missing braces in single line statements and the wrong
> indentation. Fix this by disabling the warning for that specific file.
> I haven't found a way to force flex to add braces around single line
> statements in conditional blocks.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wl@xen.org>
prev parent reply other threads:[~2020-05-06 13:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 9:24 [PATCH 0/3] build: fixes for clang 10 Roger Pau Monne
2020-05-05 9:24 ` [PATCH 1/3] x86/mm: do not attempt to convert _PAGE_GNTTAB to a boolean Roger Pau Monne
2020-05-05 13:47 ` Jan Beulich
2020-05-05 14:11 ` Roger Pau Monné
2020-05-05 14:59 ` Jan Beulich
2020-05-05 9:24 ` [PATCH 2/3] configure: also add EXTRA_PREFIX to {CPP/LD}FLAGS Roger Pau Monne
2020-05-06 13:07 ` Wei Liu
2020-05-22 8:41 ` Bertrand Marquis
2020-05-22 9:05 ` Wei Liu
2020-05-22 9:37 ` Bertrand Marquis
2020-05-22 9:59 ` Wei Liu
2020-05-22 11:19 ` Roger Pau Monné
2020-05-22 11:40 ` Bertrand Marquis
2020-05-22 11:41 ` Wei Liu
2020-05-05 9:24 ` [PATCH 3/3] tools/libxl: disable clang indentation check for the disk parser Roger Pau Monne
2020-05-06 13:07 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506130741.lgpi4gduon7cqnup@debian \
--to=wl@xen.org \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).