From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9432FC433DF for ; Mon, 18 May 2020 14:50:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 620F420787 for ; Mon, 18 May 2020 14:50:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vWW4pQUF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 620F420787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=invisiblethingslab.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jah6C-0000Wu-EL; Mon, 18 May 2020 14:50:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jah6A-0000Wh-Pk for xen-devel@lists.xenproject.org; Mon, 18 May 2020 14:50:35 +0000 X-Inumbo-ID: ed1ea68e-9916-11ea-a86f-12813bfff9fa Received: from wout5-smtp.messagingengine.com (unknown [64.147.123.21]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ed1ea68e-9916-11ea-a86f-12813bfff9fa; Mon, 18 May 2020 14:50:33 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 936CE95A; Mon, 18 May 2020 10:50:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 18 May 2020 10:50:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=jPAjWK c5sSWWWN18xk/Zk61bphWCWHeGH9TSk3WjyZI=; b=vWW4pQUFfO+y+lmz6hAOpT KnxFB2g3AlR/UbWqVdXULUV2ByAul76h+wWlaPhS1fJQ+/T2F3XEMO1E4Ze4LCpu lFzbPckX+vdRRbUXIEZqtYzoBavF0uISZET4wFywvYPKAGGD7wtxfCy69D5K0A6X bQejPinyWO/AjbQHzA04x9q3bPQFjRrVrkC9RIo7weDF1jAHkTUvh+H+MifzX+3m J6MQ2XpquRR3P/KuRXNBSduA406QSsr5tH6+6TDynmhQi/lbAuqKqpl7mQe9VxXW 9EJVkRkKtjW5m9wII0OtnpzQOuT82n6jOip5qQCoKhJHBzozhO1hsVZ+rf57nUKg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddthedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucfkpheple durdeihedrfeegrdeffeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrd gtohhm X-ME-Proxy: Received: from mail-itl (ip5b412221.dynamic.kabel-deutschland.de [91.65.34.33]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E56930663ED; Mon, 18 May 2020 10:50:31 -0400 (EDT) Date: Mon, 18 May 2020 16:50:28 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Ian Jackson Subject: Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain Message-ID: <20200518145028.GD98582@mail-itl> References: <20200428040433.23504-1-jandryuk@gmail.com> <20200428040433.23504-10-jandryuk@gmail.com> <24253.29524.798802.978257@mariner.uk.xensource.com> <24258.39029.788968.419649@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk" Content-Disposition: inline In-Reply-To: <24258.39029.788968.419649@mariner.uk.xensource.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Wei Liu , Jason Andryuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --qDbXVdCdHGoSgWSk Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain On Mon, May 18, 2020 at 03:15:17PM +0100, Ian Jackson wrote: > Jason Andryuk writes ("Re: [PATCH v5 09/21] libxl: add save/restore suppo= rt for qemu-xen in stubdomain"): > > On Thu, May 14, 2020 at 12:35 PM Ian Jackson w= rote: > > > It's not stated anywhere here that I can see but I think what is > > > happening here is that your wrapper script knows the qemu savefile > > > pathname and reads it directly. Maybbe a comment would be > > > worthwhile ? > >=20 > > The existing comment "Linux stubdomain connects specific FD to > > STUBDOM_CONSOLE_RESTORE" is trying to state that. > > STUBDOM_CONSOLE_RESTORE is defined as 2 for console 2 (/dev/hvc2), but > > it is only a libxl_internal.h define. >=20 > Err, by "the qemu savefile pathname" I meant the pathname in dom0. > I assume your wrapper script opens that and feeds it to the console. > Is that right ? Not really a wrapper script. On dom0 side it is console backend (qemu) instructed to connect the console to a file, instead of pty. I have implemented similar feature in my xenconsoled patch series sent a while ago (sent along with v2 of this series), but that series needs some more love. On the stubdomain side, it is a script that launches qemu - opens a /dev/hvc2, then pass the FD to qemu via -incoming option (which is really constructed by libxl). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl7CoLMACgkQ24/THMrX 1ywd0gf/YbknnStZlnqO5hAce/czX5KBww8Jk4yDPQzLnxxMfzudLDUz//MPW38x pXxG53WO2Iho42ebTWk5Rn5Q76ManDgUK47HzRDAW9ZSDgw2NKgB1w7p4Jm/XRVK KoXRUta27/pVZu3nN6s9GEcfzJqzk9tKbJ2zXeBNuLjZ4PQPPV0t/1lHeiOTT3pa nX7KlloJOl6GfhPgx9bSnLFnL25UA2lf3XXXc/ql27ob3Bar89kf/iUN3F2VvIp6 TP+oI81PwJG042EVVSmCye/N0KsgAnDzpJUFl0fDKP/KQFuS5qDuhPkcQr//Q9dH 7bJg6JX++PEoMvZEtfYW48BIVF3PKQ== =oGCI -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk--