From: Anchal Agarwal <anchalag@amazon.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "Valentin, Eduardo" <eduval@amazon.com>,
"len.brown@intel.com" <len.brown@intel.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"pavel@ucw.cz" <pavel@ucw.cz>, "hpa@zytor.com" <hpa@zytor.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"Kamata, Munehisa" <kamatam@amazon.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Singh, Balbir" <sblbir@amazon.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"bp@alien8.de" <bp@alien8.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"jgross@suse.com" <jgross@suse.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [PATCH 04/12] x86/xen: add system core suspend and resume callbacks
Date: Mon, 8 Jun 2020 17:09:47 +0000 [thread overview]
Message-ID: <20200608170947.GA4392@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> (raw)
In-Reply-To: <e2073aa4-2410-4630-fee6-4e4abc172876@oracle.com>
On Fri, Jun 05, 2020 at 05:24:37PM -0400, Boris Ostrovsky wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On 6/3/20 6:40 PM, Agarwal, Anchal wrote:
> > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> >
> >
> >
> > On 5/19/20 7:26 PM, Anchal Agarwal wrote:
> > > From: Munehisa Kamata <kamatam@amazon.com>
> > >
> > > Add Xen PVHVM specific system core callbacks for PM suspend and
> > > hibernation support. The callbacks suspend and resume Xen
> > > primitives,like shared_info, pvclock and grant table. Note that
> > > Xen suspend can handle them in a different manner, but system
> > > core callbacks are called from the context.
> >
> >
> > I don't think I understand that last sentence.
> >
> > Looks like it may have cryptic meaning of stating that xen_suspend calls syscore_suspend from xen_suspend
> > So, if these syscore ops gets called during xen_suspend do not do anything. Check if the mode is in xen suspend
> > and return from there. These syscore_ops are specifically for domU hibernation.
> > I must admit, I may have overlooked lack of explanation of some implicit details in the original commit msg.
> >
> > > So if the callbacks
> > > are called from Xen suspend context, return immediately.
> > >
> >
> >
> > > +
> > > +static int xen_syscore_suspend(void)
> > > +{
> > > + struct xen_remove_from_physmap xrfp;
> > > + int ret;
> > > +
> > > + /* Xen suspend does similar stuffs in its own logic */
> > > + if (xen_suspend_mode_is_xen_suspend())
> > > + return 0;
>
>
> With your explanation now making this clearer, is this check really
> necessary? From what I see we are in XEN_SUSPEND mode when
> lock_system_sleep() lock is taken, meaning that we can't initialize
> hibernation.
>
I see. Sounds plausible. I will fix both the code and commit message
for better readability. Thanks for catching this.
>
> > > +
> > > + xrfp.domid = DOMID_SELF;
> > > + xrfp.gpfn = __pa(HYPERVISOR_shared_info) >> PAGE_SHIFT;
> > > +
> > > + ret = HYPERVISOR_memory_op(XENMEM_remove_from_physmap, &xrfp);
> > > + if (!ret)
> > > + HYPERVISOR_shared_info = &xen_dummy_shared_info;
> > > +
> > > + return ret;
> > > +}
> > > +
> > > +static void xen_syscore_resume(void)
> > > +{
> > > + /* Xen suspend does similar stuffs in its own logic */
> > > + if (xen_suspend_mode_is_xen_suspend())
> > > + return;
> > > +
> > > + /* No need to setup vcpu_info as it's already moved off */
> > > + xen_hvm_map_shared_info();
> > > +
> > > + pvclock_resume();
> > > +
> > > + gnttab_resume();
> >
> >
> > Do you call gnttab_suspend() in pm suspend path?
> > No, since it does nothing for HVM guests. The unmap_frames is only applicable for PV guests right?
>
>
> You should call it nevertheless. It will decide whether or not anything
> needs to be done.
Will fix it in V2.
>
>
> -boris
>
Thanks,
Anchal
>
next prev parent reply other threads:[~2020-06-08 17:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 23:24 [PATCH 00/12] Fix PM hibernation in Xen guests Anchal Agarwal
2020-05-19 23:24 ` [PATCH 01/12] xen/manage: keep track of the on-going suspend mode Anchal Agarwal
2020-05-30 22:26 ` Boris Ostrovsky
2020-06-01 21:00 ` Agarwal, Anchal
2020-06-01 22:39 ` Boris Ostrovsky
2020-05-19 23:25 ` [PATCH 02/12] xenbus: add freeze/thaw/restore callbacks support Anchal Agarwal
2020-05-30 22:56 ` Boris Ostrovsky
2020-06-01 23:36 ` Agarwal, Anchal
2020-05-19 23:25 ` [PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume Anchal Agarwal
2020-05-30 23:02 ` Boris Ostrovsky
2020-06-04 23:03 ` Anchal Agarwal
2020-06-05 21:39 ` Boris Ostrovsky
2020-06-08 16:52 ` Anchal Agarwal
2020-06-08 18:49 ` Boris Ostrovsky
2020-05-19 23:26 ` [PATCH 04/12] x86/xen: add system core suspend and resume callbacks Anchal Agarwal
2020-05-30 23:10 ` Boris Ostrovsky
2020-06-03 22:40 ` Agarwal, Anchal
2020-06-05 21:24 ` Boris Ostrovsky
2020-06-08 17:09 ` Anchal Agarwal [this message]
2020-05-19 23:26 ` [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation Anchal Agarwal
2020-05-19 23:29 ` Singh, Balbir
2020-05-19 23:36 ` Agarwal, Anchal
2020-05-19 23:34 ` Anchal Agarwal
2020-05-30 23:17 ` Boris Ostrovsky
2020-06-01 20:46 ` Agarwal, Anchal
2020-05-19 23:27 ` [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation Anchal Agarwal
2020-05-20 5:00 ` kbuild test robot
2020-05-20 5:07 ` kbuild test robot
2020-05-21 23:48 ` Anchal Agarwal
2020-05-22 1:43 ` Singh, Balbir
2020-05-23 12:32 ` kbuild test robot
2020-05-28 12:30 ` Roger Pau Monné
2020-05-19 23:28 ` [PATCH 07/12] xen-netfront: " Anchal Agarwal
2020-05-19 23:28 ` [PATCH 08/12] xen/time: introduce xen_{save,restore}_steal_clock Anchal Agarwal
2020-05-30 23:32 ` Boris Ostrovsky
2020-05-19 23:28 ` [PATCH 09/12] x86/xen: save and restore steal clock Anchal Agarwal
2020-05-30 23:44 ` Boris Ostrovsky
2020-06-04 18:33 ` Anchal Agarwal
2020-05-19 23:29 ` [PATCH 10/12] xen: Introduce wrapper for save/restore sched clock offset Anchal Agarwal
2020-05-19 23:29 ` [PATCH 11/12] xen: Update sched clock offset to avoid system instability in hibernation Anchal Agarwal
2020-05-19 23:29 ` [PATCH 12/12] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA Anchal Agarwal
2020-05-28 17:59 ` [PATCH 00/12] Fix PM hibernation in Xen guests Agarwal, Anchal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608170947.GA4392@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com \
--to=anchalag@amazon.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=eduval@amazon.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kamatam@amazon.com \
--cc=konrad.wilk@oracle.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=roger.pau@citrix.com \
--cc=sblbir@amazon.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).