From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD14C433DF for ; Mon, 15 Jun 2020 11:44:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86B462067B for ; Mon, 15 Jun 2020 11:44:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86B462067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jknXF-0002ko-8l; Mon, 15 Jun 2020 11:44:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jknXE-0002kf-FD for xen-devel@lists.xenproject.org; Mon, 15 Jun 2020 11:44:16 +0000 X-Inumbo-ID: 89484200-aefd-11ea-b7f9-12813bfff9fa Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 89484200-aefd-11ea-b7f9-12813bfff9fa; Mon, 15 Jun 2020 11:44:16 +0000 (UTC) Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: +VCt2J+qFnmXbnirkPW43krISHVsBsidrbcUAhuV+z63IMl+vyqY1cjb5X0Odoyvv5FIoGpH++ Klwuay9ouLxBTBLRHL8CpkQg8ZUa3MkaVzi4G8OAztRXR69xBUZqjdBdtWOhy2mIGkk+Mu1EGR ep/VX8l26GoDNFCbocdoIF8ZVs5cwU2JWDJrPKrezRJHwFUbR1r4v7psvt1du9Lu0/MblpBa7R iv6m+gmejscEMep/q8V8OHoY4oUDj6zx9msqGQWADrwzEmW3uJ04yw7LSneNlllnIcWmwa4fAe 9M0= X-SBRS: 2.7 X-MesageID: 20822063 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,514,1583211600"; d="scan'208";a="20822063" Date: Mon, 15 Jun 2020 13:44:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Subject: Re: [PATCH for-4.14 1/8] x86/hvm: fix vIO-APIC build without IRQ0_SPECIAL_ROUTING Message-ID: <20200615114409.GD735@Air-de-Roger> References: <20200612155640.4101-1-roger.pau@citrix.com> <20200612155640.4101-2-roger.pau@citrix.com> <002b01d642fb$d2e229b0$78a67d10$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <002b01d642fb$d2e229b0$78a67d10$@xen.org> X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, 'Wei Liu' , 'Jan Beulich' , 'Andrew Cooper' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Jun 15, 2020 at 11:00:38AM +0100, Paul Durrant wrote: > > -----Original Message----- > > From: Roger Pau Monne > > Sent: 12 June 2020 16:57 > > To: xen-devel@lists.xenproject.org > > Cc: paul@xen.org; Roger Pau Monne ; Jan Beulich ; Andrew > > Cooper ; Wei Liu > > Subject: [PATCH for-4.14 1/8] x86/hvm: fix vIO-APIC build without IRQ0_SPECIAL_ROUTING > > > > pit_channel0_enabled needs to be guarded with IRQ0_SPECIAL_ROUTING > > since it's only used when the special handling of ISA IRQ 0 is enabled. > > > > No functional change. > > > > Signed-off-by: Roger Pau MonnĂ© > > --- > > xen/arch/x86/hvm/vioapic.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c > > index b87facb0e0..bd41036137 100644 > > --- a/xen/arch/x86/hvm/vioapic.c > > +++ b/xen/arch/x86/hvm/vioapic.c > > @@ -391,10 +391,12 @@ static void ioapic_inj_irq( > > vlapic_set_irq(target, vector, trig_mode); > > } > > > > +#ifdef IRQ0_SPECIAL_ROUTING > > static inline int pit_channel0_enabled(void) > > { > > return pt_active(¤t->domain->arch.vpit.pt0); > > } > > +#endif > > It's only called in two places. How about just manually inlining? That would be fine, as I'm also removing one of the callers in a following patch. Thanks, Roger.