From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D283C433E0 for ; Thu, 30 Jul 2020 10:08:42 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22D6C20809 for ; Thu, 30 Jul 2020 10:08:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="AHg26eu+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22D6C20809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k15Tz-0008KF-On; Thu, 30 Jul 2020 10:08:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k15Tx-0008KA-Il for xen-devel@lists.xenproject.org; Thu, 30 Jul 2020 10:08:13 +0000 X-Inumbo-ID: 93593032-d24c-11ea-8d29-bc764e2007e4 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 93593032-d24c-11ea-8d29-bc764e2007e4; Thu, 30 Jul 2020 10:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596103693; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=yzatxMaE63S7r7J7i/D4AKibgu4cOAE1pxAdd0hTzXI=; b=AHg26eu+ySocCvh0ziXkczWVgqkta3tOiu9X/VZV/atoHI5tfAHH5Z6r bwDLJZ9obnjdADgjSCrlqZagOKqBs97oTxLCxHmydLlk+sLkd8sIv2k8/ 6gu8MI4SmYqY6+i1p8MVhkhG5ruT85+WSffm5q67Yca9SC6F40zPAJBxO Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: GmJmumpcoXIrQKZQKbZASPbHoUjLZf9syUU+kPJbw1bvzqMUryZNXi7Aue6QGo3uy7kxPeU0Kx 5ypbEJxg99F2ioRVN1UuMoN9C9LAFed2d4k3HVz0a1kVJbvJBeRTFk6k0fsoj7owQkrUliBMlQ xvNzmY0FETMDU56dzTvkoBOYHYeIvEbSKj3nN1z4qSnr1Fwe9zjI3qdIl2bLZvlKlWuFzBgCFy KHHPW4fI8dtRpg8SXM9hYjVdkMVUWrERKgVDHVw46SZdroZENZvEqarMu6A3Qel8lMAYatGfMi 8Zc= X-SBRS: 2.7 X-MesageID: 23853738 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,414,1589256000"; d="scan'208";a="23853738" Date: Thu, 30 Jul 2020 12:08:01 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Subject: Re: [PATCH v3] print: introduce a format specifier for pci_sbdf_t Message-ID: <20200730100801.GF7191@Air-de-Roger> References: <20200727103136.53343-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Wei Liu , Paul Durrant , Andrew Cooper , Ian Jackson , George Dunlap , Julien Grall , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, Jul 29, 2020 at 09:28:53PM +0200, Jan Beulich wrote: > On 27.07.2020 12:31, Roger Pau Monne wrote: > > The new format specifier is '%pp', and prints a pci_sbdf_t using the > > seg:bus:dev.func format. Replace all SBDFs printed using > > '%04x:%02x:%02x.%u' to use the new format specifier. > > > > No functional change intended. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Kevin Tian > > Acked-by: Julien Grall > > For just the pieces where Jan is the only maintainer: > > Acked-by: Jan Beulich [...] > In all reality, Roger, it looks to me as if you should have dropped > my ack, as there seems to be nothing left at this point that I'm > the only maintainer of. Yes, just realized that now, I'm sorry. Your Ack happened before Paul became a maintainer of vendor-independent IOMMU code and I completely forgot about it. I think the overall result of having a modifier for printing SBDFs is a win for everyone. TBH I just revived the patch because I think it will be helpful to the Arm folks doing the PCI work, if not I wouldn't have sent it again. Roger.