* [PATCH v1] tools/xen-cpuid: show enqcmd
@ 2020-07-30 16:34 Olaf Hering
2020-07-31 12:03 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2020-07-30 16:34 UTC (permalink / raw)
To: xen-devel
Cc: Olaf Hering, Wei Liu, Andrew Cooper, Ian Jackson, Jan Beulich,
Roger Pau Monné
Translate <29> into a feature string.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
not compile nor runtime tested.
tools/misc/xen-cpuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c
index ac3548dcfe..2446941a47 100644
--- a/tools/misc/xen-cpuid.c
+++ b/tools/misc/xen-cpuid.c
@@ -133,7 +133,7 @@ static const char *const str_7c0[32] =
[22] = "rdpid",
/* 24 */ [25] = "cldemote",
/* 26 */ [27] = "movdiri",
- [28] = "movdir64b",
+ [28] = "movdir64b", [29] = "enqcmd",
[30] = "sgx-lc",
};
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1] tools/xen-cpuid: show enqcmd
2020-07-30 16:34 [PATCH v1] tools/xen-cpuid: show enqcmd Olaf Hering
@ 2020-07-31 12:03 ` Jan Beulich
2020-07-31 12:04 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2020-07-31 12:03 UTC (permalink / raw)
To: Olaf Hering
Cc: xen-devel, Roger Pau Monné, Ian Jackson, Wei Liu, Andrew Cooper
On 30.07.2020 18:34, Olaf Hering wrote:
> Translate <29> into a feature string.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Jan Beulich <jbeulich@suse.com>
Albeit I'm pretty sure there are more missing than just this lone one.
Jan
> --- a/tools/misc/xen-cpuid.c
> +++ b/tools/misc/xen-cpuid.c
> @@ -133,7 +133,7 @@ static const char *const str_7c0[32] =
> [22] = "rdpid",
> /* 24 */ [25] = "cldemote",
> /* 26 */ [27] = "movdiri",
> - [28] = "movdir64b",
> + [28] = "movdir64b", [29] = "enqcmd",
> [30] = "sgx-lc",
> };
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] tools/xen-cpuid: show enqcmd
2020-07-31 12:03 ` Jan Beulich
@ 2020-07-31 12:04 ` Andrew Cooper
2020-07-31 12:15 ` Olaf Hering
2020-07-31 12:21 ` Jan Beulich
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Cooper @ 2020-07-31 12:04 UTC (permalink / raw)
To: Jan Beulich, Olaf Hering
Cc: xen-devel, Ian Jackson, Wei Liu, Roger Pau Monné
On 31/07/2020 13:03, Jan Beulich wrote:
> On 30.07.2020 18:34, Olaf Hering wrote:
>> Translate <29> into a feature string.
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> Albeit I'm pretty sure there are more missing than just this lone one.
And in particular, probably missing from libxl_cpuid.c, which I was
meaning to check when I've got a free moment.
~Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] tools/xen-cpuid: show enqcmd
2020-07-31 12:04 ` Andrew Cooper
@ 2020-07-31 12:15 ` Olaf Hering
2020-07-31 12:24 ` Andrew Cooper
2020-07-31 12:21 ` Jan Beulich
1 sibling, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2020-07-31 12:15 UTC (permalink / raw)
To: Andrew Cooper
Cc: xen-devel, Ian Jackson, Wei Liu, Jan Beulich, Roger Pau Monné
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
Am Fri, 31 Jul 2020 13:04:35 +0100
schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
> And in particular, probably missing from libxl_cpuid.c, which I was
> meaning to check when I've got a free moment.
Will a ever domU see this flag? I just spotted the <29> when comparing 'xen-cpuid' output between recent Xen releases. It shows up just in the 'Known' section at this point.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] tools/xen-cpuid: show enqcmd
2020-07-31 12:15 ` Olaf Hering
@ 2020-07-31 12:24 ` Andrew Cooper
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Cooper @ 2020-07-31 12:24 UTC (permalink / raw)
To: Olaf Hering
Cc: xen-devel, Ian Jackson, Wei Liu, Jan Beulich, Roger Pau Monné
On 31/07/2020 13:15, Olaf Hering wrote:
> Am Fri, 31 Jul 2020 13:04:35 +0100
> schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
>
>> And in particular, probably missing from libxl_cpuid.c, which I was
>> meaning to check when I've got a free moment.
> Will a ever domU see this flag? I just spotted the <29> when comparing 'xen-cpuid' output between recent Xen releases. It shows up just in the 'Known' section at this point.
For future platforms supporting Compute eXpress Link, PCIPassthrough
will be able to give various accelerators to VMs, and the ENQCMD{,S}
instructions is what the guest will use to talk to hardware.
As a set of functionality, think DPDK but with with userspace (or the
guest) able to submit work to hardware directly, through an interface
designed to be safe for this kind of thing.
~Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] tools/xen-cpuid: show enqcmd
2020-07-31 12:04 ` Andrew Cooper
2020-07-31 12:15 ` Olaf Hering
@ 2020-07-31 12:21 ` Jan Beulich
1 sibling, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2020-07-31 12:21 UTC (permalink / raw)
To: Andrew Cooper
Cc: xen-devel, Olaf Hering, Ian Jackson, Wei Liu, Roger Pau Monné
On 31.07.2020 14:04, Andrew Cooper wrote:
> On 31/07/2020 13:03, Jan Beulich wrote:
>> On 30.07.2020 18:34, Olaf Hering wrote:
>>> Translate <29> into a feature string.
>>>
>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>>
>> Albeit I'm pretty sure there are more missing than just this lone one.
>
> And in particular, probably missing from libxl_cpuid.c, which I was
> meaning to check when I've got a free moment.
As it's not just this one, but e.g. also the two movdir* ones,
I thought I'd not require the other side to also be changed,
the more that enqcmd also doesn't get exposed to guests at all
right now.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-31 12:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 16:34 [PATCH v1] tools/xen-cpuid: show enqcmd Olaf Hering
2020-07-31 12:03 ` Jan Beulich
2020-07-31 12:04 ` Andrew Cooper
2020-07-31 12:15 ` Olaf Hering
2020-07-31 12:24 ` Andrew Cooper
2020-07-31 12:21 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).