Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: committers@xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH] Disable mercurial support
Date: Fri, 31 Jul 2020 16:54:44 +0100
Message-ID: <20200731155444.2767-1-ian.jackson@eu.citrix.com> (raw)

This is in order that we can substantially simplify forthcoming
database changes.  If mercurial support were still desired, the right
thing to do would be to rework it now along the lines of this request.
But we haven't used it for some years.

It could be reenabled later, if this work were done then.  (Of course
there might be other bitrot already that we don't know about.)

CC: committers@xenproject.org
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/TestSupport.pm |  5 +++++
 sg-report-flight       | 11 ++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 7eeac49f..faac106f 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -1661,6 +1661,11 @@ sub build_url_vcs ($) {
 	$tree = git_massage_url($tree);
     }
 
+    if ($vcs eq 'hg') {
+	die "mercurial support has rottted";
+	# to reinstate, git grep for "mercurial" and fix everything
+    }
+
     return ($tree, $vcs);
 }
 
diff --git a/sg-report-flight b/sg-report-flight
index 831917a9..49f7ba6a 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -299,7 +299,16 @@ END
                 last;
             }
             my ($wronginfo) = grep {
-                $_->[1]{val} !~ m/^(?: .*: )? $v /x;
+                $_->[1]{val} ne $v;
+                # Was once   $_->[1]{val} !~ m/^(?: .*: )? $v /x;
+		# to support stripping (local) changeset numbers from
+		# mercurial revisions in the val column.  But this
+		# does not work with our index query strategy.  To
+		# reinstate mercurial support, it will be necessary to
+		# either make the index query more complicated (eg an
+		# index on a substring of val) or to arrange for all
+		# the code to not ever store these revision counts in
+		# the db.  The latter is probably more correct.
             } @revisions;
 
             if (defined $wronginfo) {
-- 
2.20.1



                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200731155444.2767-1-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=committers@xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git