From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DCF5C433E0 for ; Tue, 4 Aug 2020 14:16:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EDB822B40 for ; Tue, 4 Aug 2020 14:16:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EDB822B40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xkC-00048E-M9; Tue, 04 Aug 2020 14:16:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xkB-000489-Sz for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:16:43 +0000 X-Inumbo-ID: ffc58760-1966-421c-a441-c030c16ff223 Received: from mail-wm1-f67.google.com (unknown [209.85.128.67]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ffc58760-1966-421c-a441-c030c16ff223; Tue, 04 Aug 2020 14:16:43 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id g8so2841201wmk.3 for ; Tue, 04 Aug 2020 07:16:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=k1GAM4yGJRVX+IjsFYQxKWWU3oYsEc17L61GHIF+wPc=; b=dzqdjaIaVukJ9mEf3FISK6L68tFyRT77cE9cvzWKRIqkuf+7rbRgFvZltA6a+zxCeM /SGHAmL+TSbEWnMF8tWJe1Rw9mzaEhHboZA7m8/95RMtw5pLlQpVAvcC53YNPrt6qARJ K1aV9UP3Rosanm7e2yPOnPubZk/vLjBKcGlDsplA99lwe9HvcRmACIFgh960DRDLVZSG IH3O52EUZNxbI7x1hw7QeIPDiy+vOYLrIazRJ0Wquv31vcQFqWxdHkpTjG6zxF1AjdZt w8dIdyRGVGaScq8FJWlcgOj0LoO2m/Uv0pysed2bs7rcuJ87vFDP8440DTU+UE8lJDwQ 3QhA== X-Gm-Message-State: AOAM530CfjGVHksy1Kg50Am7JREVqjAXJeNWv8crZEJM8RgnJAsBhcuR km66dZetJwkmiwpVFvLjISY= X-Google-Smtp-Source: ABdhPJwpr7tdJnbqlY4UQNBXiNrVbK4mSkw2DiB9ytf+3KXHekG/PpYkiWxNsQqWzjLgBuaSa7yvcw== X-Received: by 2002:a1c:dc8b:: with SMTP id t133mr4189443wmg.148.1596550602310; Tue, 04 Aug 2020 07:16:42 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id c14sm30601284wrw.85.2020.08.04.07.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 07:16:41 -0700 (PDT) Date: Tue, 4 Aug 2020 14:16:39 +0000 From: Wei Liu To: Jan Beulich Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y Message-ID: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: > While this doesn't address the real problem I've run into (attempting to > update r/o source files), not recursing into tools/golang/xenlight/ is > enough to fix the build for me for the moment. I don't currently see why > 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found > it necessary to invoke this build step unconditionally. > Perhaps an oversight? > Signed-off-by: Jan Beulich Acked-by: Wei Liu > --- > I'm also having trouble to see why, besides the idl-gen target in > tools/golang/xenlight/Makefile, the commit also adds such a target to > (and mentions it in [only] a comment in) tools/libxl/Makefile. > > --- a/tools/libxl/Makefile > +++ b/tools/libxl/Makefile > @@ -282,7 +282,9 @@ _libxl_type%.h _libxl_type%_json.h _libx > # about races with tools/golang/xenlight/Makefile:all > .PHONY: idl-external > idl-external: > +ifeq ($(CONFIG_GOLANG),y) > $(MAKE) -C $(XEN_ROOT)/tools/golang/xenlight idl-gen > +endif > > LIBXL_IDLGEN_FILES = _libxl_types.h _libxl_types_json.h _libxl_types_private.h _libxl_types.c \ > _libxl_types_internal.h _libxl_types_internal_json.h _libxl_types_internal_private.h _libxl_types_internal.c