From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 661C6C433E2 for ; Tue, 15 Sep 2020 11:56:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0ABB21D1B for ; Tue, 15 Sep 2020 11:56:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="dIUhUwjW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0ABB21D1B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kI9ZM-0000HH-VZ; Tue, 15 Sep 2020 11:56:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kI9ZL-0000HC-IQ for xen-devel@lists.xenproject.org; Tue, 15 Sep 2020 11:56:19 +0000 X-Inumbo-ID: e5991fdb-b035-4948-aa25-15be40180e51 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e5991fdb-b035-4948-aa25-15be40180e51; Tue, 15 Sep 2020 11:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1600170977; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MQHm4ReQThgSRiYkfoKeh15JRSe8w1STtkjQ620Kgz8=; b=dIUhUwjWzZzall+OyCDES19MdGJvhNAKGBHx1GbmSzEBEarMyzbPjsDH /jGj/auD3VUizKJeoc2zu6i9NuNrneVkXw7seLX3INRgilOjHBCq9TQSL Gt1cJKyYMrsVKuGCgDmFCNWcV6HtyjpBBF5iSdf8rgrypu7NBANpk1Yso g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: p3spvpsFai60Znai4TnShpJhKFdeq15U7iEwyeRON8s6WHVuZMFBex/l1WE4wpP+HdIUob30Sx Q6DU0ffG6woEgTuD0F4isMrzE3V/Z8S8yr7hr+ihCG2wF4HC0rHicZANgVoHvaXPnxJ3IykDYE pvw2mmuhJwO7HybcFRKvdBtQFCHbdOjhx62SG+99P7VmOAbSy0BVaLg+wgtZywxlZAmFYSA111 O6xWoOSYHUqbYv2e/lFApYvP3VluYEJZrvXaX0JMzhgbmdJSk8bc1u+dHkEQMZr79kYRkZCl0l VLM= X-SBRS: 2.7 X-MesageID: 27691002 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,429,1592884800"; d="scan'208";a="27691002" Date: Tue, 15 Sep 2020 13:56:03 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , Wei Liu , Julien Grall , Stefano Stabellini , George Dunlap Subject: Re: [PATCH 1/9] build: use if_changed more consistently (and correctly) for prelink*.o Message-ID: <20200915115603.GL753@Air-de-Roger> References: <75d94bf1-b419-8a82-2d15-fb02e56109d8@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <75d94bf1-b419-8a82-2d15-fb02e56109d8@suse.com> X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To FTLPEX02CL06.citrite.net (10.13.108.179) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Sep 14, 2020 at 12:15:39PM +0200, Jan Beulich wrote: > Switch to $(call if_changed,ld) where possible; presumably not doing so > in e321576f4047 ("xen/build: start using if_changed") right away was an > oversight, as it did for Arm in (just) one case. It failed to add > prelink.o to $(targets), though, causing - judging from the observed > behavior on x86 - undue rebuilds of the final binary (because of > prelink.o getting rebuild for $(cmd_prelink.o) being empty, in turn > because of .prelink.o.cmd not getting read) during "make install-xen". I'm not sure I follow why prelink.o needs to be added to targets, does this offer some kind of protection against rebuilds when doing make install? The switch to if_changed LGTM. Thanks, Roger.