From: Wei Liu <wl@xen.org>
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: xen-devel@lists.xenproject.org,
"Ian Jackson" <iwj@xenproject.org>, "Wei Liu" <wl@xen.org>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Subject: Re: [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process
Date: Tue, 13 Oct 2020 13:26:06 +0000 [thread overview]
Message-ID: <20201013132606.7ff35mmpesklbmcx@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20201012011139.GA82449@mattapan.m5p.com>
On Sun, Oct 11, 2020 at 06:11:39PM -0700, Elliott Mitchell wrote:
> Unexpectedly the environment variable which needs to be passed is
> $LDSHARED and not $LD. Otherwise Python may find the build `ld` instead
> of the host `ld`.
>
> Replace $(LDFLAGS) with $(SHLIB_LDFLAGS) as Python needs shared objects
> it can load at runtime, not executables.
>
> This uses $(CC) instead of $(LD) since Python distutils appends $CFLAGS
> to $LDFLAGS which breaks many linkers.
>
> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> ---
> This is now the *third* time this has been sent to the list. Mark Pryor
> has tested and confirms Python cross-building is working. There is one
> wart left which I'm unsure of the best approach for.
>
> Having looked around a bit, I believe this is a Python 2/3 compatibility
> issue. "distutils" for Python 2 likely lacked a separate $LDSHARED or
> $LD variable, whereas Python 3 does have this. Alas this is pointless
> due to the above (unless you can cause distutils.py to do the final link
> step separately).
I think this is well-reasoned but I don't have time to figure out and
verify the details.
Marek, do you have any comment on this?
> ---
> tools/pygrub/Makefile | 9 +++++----
> tools/python/Makefile | 9 +++++----
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
> index 3063c4998f..37b2146214 100644
> --- a/tools/pygrub/Makefile
> +++ b/tools/pygrub/Makefile
> @@ -3,20 +3,21 @@ XEN_ROOT = $(CURDIR)/../..
> include $(XEN_ROOT)/tools/Rules.mk
>
> PY_CFLAGS = $(CFLAGS) $(PY_NOOPT_CFLAGS)
> -PY_LDFLAGS = $(LDFLAGS) $(APPEND_LDFLAGS)
> +PY_LDFLAGS = $(SHLIB_LDFLAGS) $(APPEND_LDFLAGS)
> INSTALL_LOG = build/installed_files.txt
>
> .PHONY: all
> all: build
> .PHONY: build
> build:
> - CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py build
> + CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py build
>
> .PHONY: install
> install: all
> $(INSTALL_DIR) $(DESTDIR)/$(bindir)
> - CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) \
> - setup.py install --record $(INSTALL_LOG) $(PYTHON_PREFIX_ARG) \
> + CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" \
> + LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py install \
> + --record $(INSTALL_LOG) $(PYTHON_PREFIX_ARG) \
> --root="$(DESTDIR)" --install-scripts=$(LIBEXEC_BIN) --force
> set -e; if [ $(bindir) != $(LIBEXEC_BIN) -a \
> "`readlink -f $(DESTDIR)/$(bindir)`" != \
> diff --git a/tools/python/Makefile b/tools/python/Makefile
> index 8d22c03676..b675f5b4de 100644
> --- a/tools/python/Makefile
> +++ b/tools/python/Makefile
> @@ -5,19 +5,20 @@ include $(XEN_ROOT)/tools/Rules.mk
> all: build
>
> PY_CFLAGS = $(CFLAGS) $(PY_NOOPT_CFLAGS)
> -PY_LDFLAGS = $(LDFLAGS) $(APPEND_LDFLAGS)
> +PY_LDFLAGS = $(SHLIB_LDFLAGS) $(APPEND_LDFLAGS)
> INSTALL_LOG = build/installed_files.txt
>
> .PHONY: build
> build:
> - CC="$(CC)" CFLAGS="$(PY_CFLAGS)" $(PYTHON) setup.py build
> + CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py build
>
> .PHONY: install
> install:
> $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
>
> - CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) \
> - setup.py install --record $(INSTALL_LOG) $(PYTHON_PREFIX_ARG) \
> + CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" \
> + LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py install \
> + --record $(INSTALL_LOG) $(PYTHON_PREFIX_ARG) \
> --root="$(DESTDIR)" --force
>
> $(INSTALL_PYTHON_PROG) scripts/convert-legacy-stream $(DESTDIR)$(LIBEXEC_BIN)
> --
> 2.20.1
>
>
> --
> (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/)
> \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) /
> \_CS\ | _____ -O #include <stddisclaimer.h> O- _____ | / _/
> 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
>
>
next prev parent reply other threads:[~2020-10-13 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 1:11 [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process Elliott Mitchell
2020-10-13 13:26 ` Wei Liu [this message]
2020-10-15 1:02 ` Marek Marczykowski-Górecki
2020-10-15 4:03 ` Elliott Mitchell
2020-10-15 1:01 ` Marek Marczykowski-Górecki
2020-10-16 13:25 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013132606.7ff35mmpesklbmcx@liuwe-devbox-debian-v2 \
--to=wl@xen.org \
--cc=ehem+xen@m5p.com \
--cc=iwj@xenproject.org \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).