xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH v2 17/17] cr-daily-branch: Heuristics for when to do immediate retest flight
Date: Thu, 15 Oct 2020 16:50:19 +0100	[thread overview]
Message-ID: <20201015155019.20705-18-iwj@xenproject.org> (raw)
In-Reply-To: <20201015155019.20705-1-iwj@xenproject.org>

Do not do a retest if it would involve retesting more than 10% of the
original flight, or if it wouldn't get a push even if the retests
pass.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 cr-daily-branch | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/cr-daily-branch b/cr-daily-branch
index 9b1961bd..e54ca227 100755
--- a/cr-daily-branch
+++ b/cr-daily-branch
@@ -497,11 +497,26 @@ while true; do
 	OSSTEST_IMMEDIATE_RETRY=false
 	retry_jobs=$(
 		perl <$mrof -wne '
+			$n_blockers = $1 if m/^nblockers (\d+)\s*$/;
+			$n_jobs     = $1 if m/^njobs (\d+)\s*$/;
 			next unless m/^regression (\S+) /;
 			my $j = $1;
 			next if $j =~ m/^build/;
 			$r{$j}++;
+			sub nope {
+				print STDERR "no retry: @_\n";
+				exit 0;
+			}
 			END {
+				my $n_retry_jobs = scalar(keys %r);
+ 				print STDERR <<"END";
+n_retry_jobs=$n_retry_jobs n_blockers=$n_blockers n_jobs=$n_jobs
+END
+				nope("other blockers") if 
+                                        $n_retry_jobs < $n_blockers;
+				nope("too many regressions") if
+					$n_retry_jobs > 1 &&
+					$n_retry_jobs > $n_jobs/10;
 				print "copy-jobs '$flight' $_ "
 					foreach sort keys %r;
 			}'
-- 
2.20.1



      parent reply	other threads:[~2020-10-15 16:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 15:50 [OSSTEST PATCH v2 00/13] Immediately retry failing tests Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 01/17] Honour OSSTEST_SIMULATE=2 to actually run dummy flight Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 02/17] Honour OSSTEST_SIMULATE_FAIL in sg-run-job Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 03/17] sg-report-flight: Consider all blessings for "never pass" Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 04/17] mg-execute-flight: Do not include the transcript in reports Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 05/17] sg-report-job-history: eval $DAILY_BRANCH_PREEXEC_HOOK Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 06/17] cri-args-hostlists: New debug var $OSSTEST_REPORT_JOB_HISTORY_RUN Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 07/17] cri-args-hostlists: Break out report_flight and publish_logs Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 08/17] sg-report-flight: Break out printout_flightheader Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 09/17] sg-report-flight: Provide --refer-to-flight option Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 10/17] sg-report-flight: Nicer output for " Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 11/17] Introduce real-retry blessing Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 12/17] cri-args-hostlists: Move flight_html_dir variable Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 13/17] cr-daily-branch: Immediately retry failing tests Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 14/17] Honour OSSTEST_SIMULATE_FAIL_RETRY for immediate retries Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 15/17] cr-daily-branch: Do not do immediate retry of failing xtf flights Ian Jackson
2020-10-15 15:50 ` [OSSTEST PATCH v2 16/17] sg-report-flight: Include count of blockers, and of jobs, in mro Ian Jackson
2020-10-15 15:50 ` Ian Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015155019.20705-18-iwj@xenproject.org \
    --to=iwj@xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).