From: Wei Liu <wl@xen.org>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Elliott Mitchell <ehem+xen@m5p.com>,
xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>,
Wei Liu <wl@xen.org>
Subject: Re: [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process
Date: Fri, 16 Oct 2020 13:25:24 +0000 [thread overview]
Message-ID: <20201016132524.wuli37asps4eshce@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20201015010148.GQ151766@mail-itl>
On Thu, Oct 15, 2020 at 03:01:48AM +0200, Marek Marczykowski-Górecki wrote:
> On Sun, Oct 11, 2020 at 06:11:39PM -0700, Elliott Mitchell wrote:
> > Unexpectedly the environment variable which needs to be passed is
> > $LDSHARED and not $LD. Otherwise Python may find the build `ld` instead
> > of the host `ld`.
> >
> > Replace $(LDFLAGS) with $(SHLIB_LDFLAGS) as Python needs shared objects
> > it can load at runtime, not executables.
> >
> > This uses $(CC) instead of $(LD) since Python distutils appends $CFLAGS
> > to $LDFLAGS which breaks many linkers.
> >
> > Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
>
> Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Thanks. Applied.
Wei.
prev parent reply other threads:[~2020-10-16 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 1:11 [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process Elliott Mitchell
2020-10-13 13:26 ` Wei Liu
2020-10-15 1:02 ` Marek Marczykowski-Górecki
2020-10-15 4:03 ` Elliott Mitchell
2020-10-15 1:01 ` Marek Marczykowski-Górecki
2020-10-16 13:25 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016132524.wuli37asps4eshce@liuwe-devbox-debian-v2 \
--to=wl@xen.org \
--cc=ehem+xen@m5p.com \
--cc=iwj@xenproject.org \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).