Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] tools/gdbsx: drop stray recursion into tools/include/
@ 2020-10-15  8:42 Jan Beulich
  2020-10-15 13:17 ` Ian Jackson
  0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2020-10-15  8:42 UTC (permalink / raw)
  To: xen-devel; +Cc: Elena Ufimtseva, Ian Jackson, Wei Liu

Doing so isn't appropriate here - this gets done very early in the build
process. If the directory is mean to to be buildable on its own,
different arrangements would be needed.

The issue has become more pronounced by 47654a0d7320 ("tools/include:
fix (drop) dependencies of when to populate xen/"), but was there before
afaict.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/debugger/gdbsx/xg/Makefile
+++ b/tools/debugger/gdbsx/xg/Makefile
@@ -12,7 +12,7 @@ CFLAGS += $(CFLAGS_xeninclude)
 all: build
 
 .PHONY: build
-build: xen-headers xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
+build: xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
 # build: mk-symlinks xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
 # build: mk-symlinks xg_all.a
 
@@ -21,9 +21,6 @@ xg_all.a: $(XG_OBJS) Makefile $(XG_HDRS)
 #	$(LD) -b elf32-i386 $(LDFLAGS) -r -o $@ $^
 #	$(CC) -m32 -c -o $@ $^
 
-xen-headers:
-	$(MAKE) -C ../../../include
-
 # xg_main.o: xg_main.c Makefile $(XG_HDRS)
 #$(CC) -c $(CFLAGS) -o $@ $<
 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools/gdbsx: drop stray recursion into tools/include/
  2020-10-15  8:42 [PATCH] tools/gdbsx: drop stray recursion into tools/include/ Jan Beulich
@ 2020-10-15 13:17 ` Ian Jackson
  2020-10-16 13:26   ` Wei Liu
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Jackson @ 2020-10-15 13:17 UTC (permalink / raw)
  To: Jan Beulich; +Cc: xen-devel, Elena Ufimtseva, Wei Liu

Jan Beulich writes ("[PATCH] tools/gdbsx: drop stray recursion into tools/include/"):
> Doing so isn't appropriate here - this gets done very early in the build
> process. If the directory is mean to to be buildable on its own,
> different arrangements would be needed.
> 
> The issue has become more pronounced by 47654a0d7320 ("tools/include:
> fix (drop) dependencies of when to populate xen/"), but was there before
> afaict.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools/gdbsx: drop stray recursion into tools/include/
  2020-10-15 13:17 ` Ian Jackson
@ 2020-10-16 13:26   ` Wei Liu
  2020-10-16 13:31     ` Wei Liu
  0 siblings, 1 reply; 4+ messages in thread
From: Wei Liu @ 2020-10-16 13:26 UTC (permalink / raw)
  To: Ian Jackson; +Cc: Jan Beulich, xen-devel, Elena Ufimtseva, Wei Liu

On Thu, Oct 15, 2020 at 02:17:18PM +0100, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH] tools/gdbsx: drop stray recursion into tools/include/"):
> > Doing so isn't appropriate here - this gets done very early in the build
> > process. If the directory is mean to to be buildable on its own,
> > different arrangements would be needed.
> > 
> > The issue has become more pronounced by 47654a0d7320 ("tools/include:
> > fix (drop) dependencies of when to populate xen/"), but was there before
> > afaict.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>

I tried to applied this one but git didn't like it.

Jan, feel free to apply it yourself.

Wei.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools/gdbsx: drop stray recursion into tools/include/
  2020-10-16 13:26   ` Wei Liu
@ 2020-10-16 13:31     ` Wei Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2020-10-16 13:31 UTC (permalink / raw)
  To: Ian Jackson; +Cc: Jan Beulich, xen-devel, Elena Ufimtseva, Wei Liu

On Fri, Oct 16, 2020 at 01:26:49PM +0000, Wei Liu wrote:
> On Thu, Oct 15, 2020 at 02:17:18PM +0100, Ian Jackson wrote:
> > Jan Beulich writes ("[PATCH] tools/gdbsx: drop stray recursion into tools/include/"):
> > > Doing so isn't appropriate here - this gets done very early in the build
> > > process. If the directory is mean to to be buildable on its own,
> > > different arrangements would be needed.
> > > 
> > > The issue has become more pronounced by 47654a0d7320 ("tools/include:
> > > fix (drop) dependencies of when to populate xen/"), but was there before
> > > afaict.
> > > 
> > > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> I tried to applied this one but git didn't like it.
> 
> Jan, feel free to apply it yourself.

This is already applied. Sorry for the noise.

Wei.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15  8:42 [PATCH] tools/gdbsx: drop stray recursion into tools/include/ Jan Beulich
2020-10-15 13:17 ` Ian Jackson
2020-10-16 13:26   ` Wei Liu
2020-10-16 13:31     ` Wei Liu

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git