From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69436C63697 for ; Thu, 19 Nov 2020 14:54:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7B7022255 for ; Thu, 19 Nov 2020 14:54:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xen.org header.i=@xen.org header.b="aUUKccIm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7B7022255 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.30869.61049 (Exim 4.92) (envelope-from ) id 1kflKd-0005k9-92; Thu, 19 Nov 2020 14:54:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 30869.61049; Thu, 19 Nov 2020 14:54:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKd-0005k2-54; Thu, 19 Nov 2020 14:54:43 +0000 Received: by outflank-mailman (input) for mailman id 30869; Thu, 19 Nov 2020 14:54:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKb-0005jw-VR for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 14:54:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKb-0005wS-HP; Thu, 19 Nov 2020 14:54:41 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kflKb-0003Ic-7K; Thu, 19 Nov 2020 14:54:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKb-0005jw-VR for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 14:54:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=IjvAESUItdtzLYryfFbk/PumKSZoZap17L392zxaSg0=; b=aUUKccIm6WEHV+NVl8UJtVbd/h wS19pwTVyB9NKwBiAGs9bUt4ETT++QNdv5qc6gz5S/2fRmRg5hTzKtabD3TCI39swY3G87Mnfo3Ig M+hjKT7o8a/wk/05rRFIB41YPQqYh7H9rpsFlOzOUWBLFEavZzMCWX2DnDIW0IYdjcLc=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKb-0005wS-HP; Thu, 19 Nov 2020 14:54:41 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kflKb-0003Ic-7K; Thu, 19 Nov 2020 14:54:41 +0000 From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] xen/irq: Propagate the error from init_one_desc_irq() in init_irq_data() Date: Thu, 19 Nov 2020 14:54:34 +0000 Message-Id: <20201119145434.28065-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall init_one_desc_irq() can return an error if it is unable to allocate memory. While this is unlikely to happen during boot (called from init_irq_data()), it is better to harden the code by propagting the return value. Spotted by coverity. CID: 106529 Signed-off-by: Julien Grall --- xen/arch/arm/irq.c | 7 ++++++- xen/arch/x86/irq.c | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 3877657a5277..279d221a2b85 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -88,7 +88,12 @@ static int __init init_irq_data(void) for ( irq = NR_LOCAL_IRQS; irq < NR_IRQS; irq++ ) { struct irq_desc *desc = irq_to_desc(irq); - init_one_irq_desc(desc); + int rc; + + rc = init_one_irq_desc(desc); + if ( rc ) + return rc; + desc->irq = irq; desc->action = NULL; } diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 45966947919e..3ebd684415ac 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -428,9 +428,14 @@ int __init init_irq_data(void) for ( irq = 0; irq < nr_irqs_gsi; irq++ ) { + int rc; + desc = irq_to_desc(irq); desc->irq = irq; - init_one_irq_desc(desc); + + rc = init_one_irq_desc(desc); + if ( rc ) + return rc; } for ( ; irq < nr_irqs; irq++ ) irq_to_desc(irq)->irq = irq; -- 2.17.1