From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC964C64E7B for ; Mon, 30 Nov 2020 11:50:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 836262074A for ; Mon, 30 Nov 2020 11:50:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 836262074A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=antioche.eu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.41048.74137 (Exim 4.92) (envelope-from ) id 1kjhhK-0003Rn-HI; Mon, 30 Nov 2020 11:50:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 41048.74137; Mon, 30 Nov 2020 11:50:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kjhhK-0003Rg-EF; Mon, 30 Nov 2020 11:50:26 +0000 Received: by outflank-mailman (input) for mailman id 41048; Mon, 30 Nov 2020 11:50:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kjhhJ-0003Rb-7i for xen-devel@lists.xenproject.org; Mon, 30 Nov 2020 11:50:25 +0000 Received: from chassiron.antioche.eu.org (unknown [2001:41d0:fe9d:1101::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 553e2e2b-eebb-4cdf-a44d-b7a8aa80c1cb; Mon, 30 Nov 2020 11:50:23 +0000 (UTC) Received: from sandettie.soc.lip6.fr (82-64-3-41.subs.proxad.net [82.64.3.41]) by chassiron.antioche.eu.org (8.15.2/8.15.2) with ESMTPS id 0AUBoIsU021271 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Mon, 30 Nov 2020 12:50:19 +0100 (MET) Received: by sandettie.soc.lip6.fr (Postfix, from userid 373) id 266502E9CAC; Mon, 30 Nov 2020 12:50:13 +0100 (MET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 553e2e2b-eebb-4cdf-a44d-b7a8aa80c1cb Date: Mon, 30 Nov 2020 12:50:13 +0100 From: Manuel Bouyer To: Jan Beulich Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , xen-devel@lists.xenproject.org Subject: Re: NetBSD dom0 PVH: hardware interrupts stalls Message-ID: <20201130115013.GF1084@antioche.eu.org> References: <20201127133121.GN1717@antioche.eu.org> <96aa5a9b-3f4a-ce9d-0f41-4a24d409ed55@suse.com> <20201127135929.GR1717@antioche.eu.org> <20201127202211.eqrxloii5x54zode@Air-de-Roger> <20201127214420.GA637@antioche.eu.org> <20201128145311.3gmzq5lnkz6ajdtr@Air-de-Roger> <20201128171430.GB631@antioche.eu.org> <819e859e-0fd2-cdbf-6126-46c924364d12@suse.com> <20201130113527.GE1084@antioche.eu.org> <7e284ec6-a3a3-6c04-ce48-10a8290304d5@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e284ec6-a3a3-6c04-ce48-10a8290304d5@suse.com> X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-4.4.3 (chassiron.antioche.eu.org [151.127.5.145]); Mon, 30 Nov 2020 12:50:19 +0100 (MET) On Mon, Nov 30, 2020 at 12:44:23PM +0100, Jan Beulich wrote: > On 30.11.2020 12:35, Manuel Bouyer wrote: > > On Mon, Nov 30, 2020 at 11:00:23AM +0100, Jan Beulich wrote: > >> On 28.11.2020 18:14, Manuel Bouyer wrote: > >>> On Sat, Nov 28, 2020 at 03:53:11PM +0100, Roger Pau Monné wrote: > >>>>> the trace is at > >>>>> http://www-soc.lip6.fr/~bouyer/xen-log13.txt > >>>> > >>>> Thanks! I think I've found the issue and I'm attaching a possible fix > >>>> (fix.patch) to this email. In any case I've also attached a further > >>>> debug patch, in case the fix turns out to be wrong. Please test the > >>>> fix first, as the debug patch will end up triggering a panic when the > >>>> buffer is full. > >>> > >>> Yes, fix.patch does make the system boot as expected ! > >> > >> May I translate this to a Tested-by? > >> > >> Patch also > >> Reviewed-by: Jan Beulich > >> > >> Thanks much to both of you for all the effort here! > > > > Also, please don't forget the attached patch ! > > Without it, the hypervisor panics. > > Well - this one still needs a proper description and S-o-b. > The other one came in immediately consumable shape right away. The patch was sent by Roger on 12 Nov 2020, in reply to my mail about the panic. The panic is: (XEN) Xen call trace: (XEN) [] R vpci_msix_arch_mask_entry+0x18/0x20 (XEN) [] S drivers/vpci/msix.c#msix_write+0x18a/0x2b0 (XEN) [] S arch/x86/hvm/intercept.c#hvm_mmio_write+0x23/0x3 0 (XEN) [] S hvm_process_io_intercept+0x1e9/0x260 (XEN) [] S hvm_io_intercept+0x1d/0x40 (XEN) [] S arch/x86/hvm/emulate.c#hvmemul_do_io+0x26a/0x4d0 (XEN) [] S drivers/vpci/msix.c#msix_accept+0x9/0x20 (XEN) [] S arch/x86/hvm/emulate.c#hvmemul_do_io_buffer+0x36 /0x70 (XEN) [] S arch/x86/hvm/emulate.c#hvmemul_linear_mmio_access+0x1e5/0x300 (XEN) [] S arch/x86/hvm/emulate.c#linear_write+0x84/0x160 (XEN) [] S arch/x86/hvm/emulate.c#hvmemul_write+0xe8/0x100 (XEN) [] S x86_emulate+0x289dc/0x2cfb0 (XEN) [] S map_domain_page+0x4b/0x600 (XEN) [] S __get_gfn_type_access+0x6a/0x100 (XEN) [] S arch/x86/mm/p2m-ept.c#ept_next_level+0x107/0x150 (XEN) [] S x86_emulate_wrapper+0x21/0x60 (XEN) [] S arch/x86/hvm/emulate.c#_hvm_emulate_one+0x4f/0x220 (XEN) [] S hvmemul_get_seg_reg+0x4d/0x50 (XEN) [] S hvm_emulate_one+0xe/0x10 (XEN) [] S hvm_emulate_one_insn+0x3a/0xf0 (XEN) [] S x86_insn_is_mem_access+0/0x260 (XEN) [] S handle_mmio_with_translation+0x49/0x60 (XEN) [] S hvm_hap_nested_page_fault+0x2c8/0x720 (XEN) [] S arch/x86/hvm/emulate.c#hv(XEN) (XEN) **************************************** (XEN) Panic on CPU 13: (XEN) Assertion 'entry->arch.pirq != INVALID_PIRQ' failed at vmsi.c:843 (XEN) **************************************** This is when it configures the broadcom network interface, which interrupts at "msix3 vec 0". It is the first MSI-X device configured; the previous ones are MSI only. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --