From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/5] x86/build: limit rebuilding of asm-offsets.h
Date: Mon, 28 Dec 2020 13:00:28 +0100 [thread overview]
Message-ID: <20201228120028.f5clmk4jr3jrlo7b@Air-de-Roger> (raw)
In-Reply-To: <d437bdbf-3047-06ad-2fe8-f445cf8b3240@suse.com>
On Wed, Nov 25, 2020 at 09:45:56AM +0100, Jan Beulich wrote:
> This file has a long dependencies list (through asm-offsets.s) and a
> long list of dependents. IOW if any of the former changes, all of the
> latter will be rebuilt, even if there's no actual change to the
> generated file. This is the primary scenario we have the move-if-changed
> macro for.
>
> Since debug information may easily cause the file contents to change in
> benign ways, also avoid emitting this into the output file.
>
> Finally already before this change *.new files needed including in what
> gets removed by the "clean" target.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Perhaps Arm would want doing the same. In fact perhaps the rules should
> be unified by moving to common code?
Having the rule in common code would be my preference, the
prerequisites are slightly different, but I think we can sort this
out?
Thanks, Roger.
next prev parent reply other threads:[~2020-12-28 12:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 8:42 [PATCH 0/5] x86: asm-offsets.h and !PV32 adjustments Jan Beulich
2020-11-25 8:45 ` [PATCH 1/5] x86/build: limit rebuilding of asm-offsets.h Jan Beulich
2020-12-28 12:00 ` Roger Pau Monné [this message]
2021-01-04 13:46 ` Jan Beulich
2020-11-25 8:49 ` [PATCH 2/5] x86/build: limit #include-ing by asm-offsets.c Jan Beulich
2020-12-28 12:54 ` Roger Pau Monné
2021-01-04 13:48 ` Jan Beulich
2020-11-25 8:49 ` [PATCH 3/5] x86/build: restrict contents of asm-offsets.h when !HVM / !PV Jan Beulich
2020-12-28 13:07 ` Roger Pau Monné
2020-11-25 8:50 ` [PATCH 4/5] x86: hypercall vector is unused when !PV32 Jan Beulich
2020-12-28 13:37 ` Roger Pau Monné
2020-11-25 8:51 ` [PATCH 5/5] x86: don't build unused entry code " Jan Beulich
2020-12-28 15:30 ` Roger Pau Monné
2021-01-04 13:56 ` Jan Beulich
2021-01-04 15:53 ` Roger Pau Monné
2021-01-04 16:11 ` Jan Beulich
2021-04-01 7:51 ` Ping: " Jan Beulich
2021-04-01 14:01 ` Roger Pau Monné
2021-04-01 14:20 ` Jan Beulich
2021-04-06 9:52 ` Jan Beulich
2021-04-01 14:31 ` Andrew Cooper
2021-04-01 14:37 ` Jan Beulich
2021-04-06 17:34 ` Andrew Cooper
2021-04-07 7:54 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228120028.f5clmk4jr3jrlo7b@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).