From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wl@xen.org>, Julien Grall <julien@xen.org>
Subject: Re: Ping: [PATCH 2/4] x86/ACPI: fix S3 wakeup vector mapping
Date: Mon, 4 Jan 2021 16:13:46 +0100 [thread overview]
Message-ID: <20210104151346.xclivtwf57t5flrj@Air-de-Roger> (raw)
In-Reply-To: <1594a3cd-05b1-3e81-18fa-f6bd3d7f0667@suse.com>
On Mon, Jan 04, 2021 at 03:03:07PM +0100, Jan Beulich wrote:
> On 29.12.2020 11:54, Roger Pau Monné wrote:
> > My preference however would be for this to use vmap. Could the mapping
> > be established in acpi_fadt_parse_sleep_info instead of having to map
> > and unmap every time in acpi_sleep_prepare?
>
> Establishing a permanent mapping would seem like a waste of resources
> to me, no matter that it's just a single page. In particular if the
> system would never really make any attempt to enter S3.
IMO I would rather have a simpler path going into suspension (ie: not
having to create a mapping to get the vector at all) with the cost of
using one page of virtual address space permanently.
Thanks, Roger.
next prev parent reply other threads:[~2021-01-04 15:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 12:38 [PATCH 0/4] x86: ACPI and DMI table mapping fixes Jan Beulich
2020-11-23 12:39 ` [PATCH 1/4] x86/ACPI: fix mapping of FACS Jan Beulich
2020-11-23 14:30 ` Roger Pau Monné
2020-12-29 10:56 ` Roger Pau Monné
2021-01-04 13:18 ` Jan Beulich
2020-11-23 12:40 ` [PATCH 2/4] x86/ACPI: fix S3 wakeup vector mapping Jan Beulich
2020-11-23 15:24 ` Roger Pau Monné
2020-11-23 15:30 ` Jan Beulich
2020-11-23 16:07 ` Roger Pau Monné
2020-11-23 16:14 ` Andrew Cooper
2020-11-24 11:04 ` Jan Beulich
2020-11-30 13:02 ` Jan Beulich
2020-12-23 15:09 ` Ping: " Jan Beulich
2020-12-29 10:54 ` Roger Pau Monné
2021-01-04 14:03 ` Jan Beulich
2021-01-04 15:13 ` Roger Pau Monné [this message]
2020-12-29 10:51 ` Roger Pau Monné
2021-01-04 14:10 ` Jan Beulich
2020-11-23 12:40 ` [PATCH 3/4] x86/DMI: fix table mapping when one lives above 1Mb Jan Beulich
2020-11-23 15:41 ` Roger Pau Monné
2020-11-23 12:41 ` [PATCH 4/4] x86/ACPI: don't invalidate S5 data when S3 wakeup vector cannot be determined Jan Beulich
2020-11-23 15:44 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104151346.xclivtwf57t5flrj@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).