From: Wei Liu <wl@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 5/5] libxenguest: simplify kernel decompression
Date: Thu, 21 Jan 2021 15:38:00 +0000 [thread overview]
Message-ID: <20210121153800.jfxkwbuk2coqd2lv@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <a94cdffe-d31c-ad83-67f6-f1c25d520dd1@suse.com>
On Tue, Jan 19, 2021 at 04:17:12PM +0100, Jan Beulich wrote:
> In all cases the kernel build makes available the uncompressed size in
> the final 4 bytes of the bzImage payload. Utilize this to avoid
> repeated realloc()ing of the output buffer.
>
> As a side effect this also addresses the previous mistaken return of 0
> (success) from xc_try_{bzip2,lzma,xz}_decode() in case
> xc_dom_register_external() would have failed.
>
> As another side effect this also addresses the first error path of
> _xc_try_lzma_decode() previously bypassing lzma_end().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
I think the code changes are correct:
Acked-by: Wei Liu <wl@xen.org>
But a second pair of eyes would be useful here since this patch is
complex.
Wei.
next prev parent reply other threads:[~2021-01-21 15:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 15:13 [PATCH v2 0/5] zstd decompression for DomU-s + fallout / consolidation Jan Beulich
2021-01-19 15:15 ` [PATCH v2 1/5] libxenguest: support zstd compressed kernels Jan Beulich
2021-01-21 15:01 ` Wei Liu
2021-01-21 15:05 ` Jan Beulich
2021-01-21 15:33 ` Wei Liu
2021-01-19 15:15 ` [PATCH v2 2/5] xen/decompress: make helper symbols static Jan Beulich
2021-01-21 15:01 ` Wei Liu
2021-01-19 15:16 ` [PATCH v2 3/5] libxenguest: "standardize" LZO kernel decompression code Jan Beulich
2021-01-21 15:02 ` Wei Liu
2021-01-25 11:59 ` Ian Jackson
2021-01-25 12:45 ` Jan Beulich
2021-01-25 13:30 ` Ian Jackson
2021-01-19 15:16 ` [PATCH v2 4/5] libxenguest: drop redundant decompression declarations Jan Beulich
2021-01-21 15:02 ` Wei Liu
2021-01-19 15:17 ` [PATCH v2 5/5] libxenguest: simplify kernel decompression Jan Beulich
2021-01-21 15:38 ` Wei Liu [this message]
2021-01-21 15:40 ` [PATCH v2.5 1/5] libxenguest: support zstd compressed kernels Jan Beulich
2021-01-25 11:30 ` Ian Jackson
2021-01-25 12:42 ` Jan Beulich
2021-01-25 13:51 ` Ian Jackson
2021-01-25 14:30 ` Jan Beulich
2021-01-25 14:53 ` Ian Jackson
2021-01-25 15:31 ` Jan Beulich
2021-01-25 16:17 ` Ian Jackson
2021-01-25 17:00 ` Jan Beulich
2021-01-25 17:30 ` Ian Jackson
2021-01-26 7:47 ` Jan Beulich
2021-01-26 12:14 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121153800.jfxkwbuk2coqd2lv@liuwe-devbox-debian-v2 \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).