From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: "Ian Jackson" <iwj@xenproject.org>,
"Edwin Török" <edvin.torok@citrix.com>,
"Christian Lindig" <christian.lindig@citrix.com>,
"Andrew Cooper" <Andrew.Cooper3@citrix.com>,
"Jürgen Groß" <jgross@suse.com>, "Wei Liu" <wl@xen.org>,
"Ian Jackson" <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored
Date: Fri, 22 Jan 2021 15:56:03 +0000 [thread overview]
Message-ID: <20210122155603.23402-7-iwj@xenproject.org> (raw)
In-Reply-To: <20210122155603.23402-1-iwj@xenproject.org>
Previously, we let the Xen build system and startup scripts choose
which xenstored to use. Before we upgraded to Debian buster, that
gave us C xentored tests on ARM. Since then, armhf and arm64 have
both had enough ocaml support and we haven't been testing C xenstored
at all !
Change this, by selecting between C xenstored and Ocaml xenstored
"at random". Actually, this is based on the job name. So the same
job in different branches will use the same xenstored - which helps
avoid confusion.
I have diffed the output of standalone-generate-dump-flight-runvars.
As expected, this addes a variable all_host_xenstored to every job.
To make sure we have enough diversity, I eyeballed the results. In
particular:
* The smoke tests now have 2 C and 2 Ocaml, one of each on
ARM and x86.
* XTF tests have 2 oxenstored and 3 C xenstored.
* The ovmf flight has one of each
* The seabios and libvirt flights look reasonably mixed.
Most other flights have enough jobs that I think things are diverse
enough without looking at them all in detail.
I think this lack of testing needs fixing for the Xen 4.15 release.
So after review I intend to push this to osstest pretest, and may
force push it even if shows regressions.
CC: Edwin Török <edvin.torok@citrix.com>
CC: Christian Lindig <christian.lindig@citrix.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Jürgen Groß <jgross@suse.com>
CC: Wei Liu <wl@xen.org>
Signed-off-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
mfi-common | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/mfi-common b/mfi-common
index 35efd233..2834411f 100644
--- a/mfi-common
+++ b/mfi-common
@@ -509,6 +509,13 @@ job_create_test () {
xenbuildjob="${bfi}build-$xenarch$xsm_suffix"
buildjob="${bfi}build-$dom0arch$xsm_suffix"
+ local xenstored="$xenstored"
+ if [ "$xenstored" = "" ]; then
+ stripy_rand "$job 2" xenstored xenstored oxenstored
+ # Without " <n>", all XTF jobs use oxenstored
+ # With " 1", All OVMF tests use xenstored
+ fi
+
job_create_test_filter_callback \
"$job" "$recipe" "$toolstack" "$xenarch" "$dom0arch" "$@" || return 0
@@ -529,7 +536,8 @@ job_create_test () {
./cs-job-create $flight $job $recipe toolstack=$toolstack \
$RUNVARS $TEST_RUNVARS $global_runvars $most_runvars \
- xenbuildjob=$xenbuildjob buildjob=$buildjob $tsbuildjob "$@"
+ xenbuildjob=$xenbuildjob buildjob=$buildjob \
+ all_host_xenstored=$xenstored $tsbuildjob "$@"
}
usual_debianhvm_image () {
--
2.20.1
next prev parent reply other threads:[~2021-01-22 15:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 15:55 [OSSTEST PATCH 1/7] target_editfile_kvp_replace: Support changing multiple keys Ian Jackson
2021-01-22 15:55 ` [OSSTEST PATCH 2/7] target_editfile_kvp_replace: Add a bit of logging Ian Jackson
2021-01-22 15:55 ` [OSSTEST PATCH 3/7] ts-xen-install: Rename $commons_config_file Ian Jackson
2021-01-22 15:56 ` [OSSTEST PATCH 4/7] ts-xen-install: Break out @commons_config Ian Jackson
2021-01-22 15:56 ` [OSSTEST PATCH 5/7] ts-xen-install: Honour xenstored target var Ian Jackson
2021-01-22 15:56 ` [OSSTEST PATCH 6/7] mfi-common: Provide stripy_rand Ian Jackson
2021-01-22 15:56 ` Ian Jackson [this message]
2021-01-22 16:07 ` [OSSTEST PATCH 7/7] make-flight: Stripy xenstored Andrew Cooper
2021-01-22 16:22 ` Ian Jackson
2021-01-22 16:24 ` Jürgen Groß
2021-01-22 16:26 ` Ian Jackson
2021-01-22 16:29 ` Jürgen Groß
2021-01-22 16:29 ` Andrew Cooper
2021-01-22 17:37 ` [OSSTEST PATCH 7/7] make-flight: Stripy xenstored [and 2 more messages] Ian Jackson
2021-01-22 17:52 ` Andrew Cooper
2021-01-28 14:26 ` Ian Jackson
2021-01-22 16:11 ` [OSSTEST PATCH 7/7] make-flight: Stripy xenstored Christian Lindig
2021-01-22 16:36 ` Andrew Cooper
2021-01-22 16:40 ` Edwin Torok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122155603.23402-7-iwj@xenproject.org \
--to=iwj@xenproject.org \
--cc=Andrew.Cooper3@citrix.com \
--cc=christian.lindig@citrix.com \
--cc=edvin.torok@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).