From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8743FC433DB for ; Sat, 30 Jan 2021 18:29:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCBAE64DCC for ; Sat, 30 Jan 2021 18:29:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCBAE64DCC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=antioche.eu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.78992.143777 (Exim 4.92) (envelope-from ) id 1l5uzN-0008AD-US; Sat, 30 Jan 2021 18:28:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 78992.143777; Sat, 30 Jan 2021 18:28:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l5uzN-0008A6-RP; Sat, 30 Jan 2021 18:28:53 +0000 Received: by outflank-mailman (input) for mailman id 78992; Sat, 30 Jan 2021 18:28:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l5uzN-0008A1-Hj for xen-devel@lists.xenproject.org; Sat, 30 Jan 2021 18:28:53 +0000 Received: from chassiron.antioche.eu.org (unknown [2001:41d0:fe9d:1101::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b1f3288c-d745-44ee-bedf-c9a5af2d1bd1; Sat, 30 Jan 2021 18:28:52 +0000 (UTC) Received: from rochebonne.antioche.eu.org (rochebonne [10.0.0.1]) by chassiron.antioche.eu.org (8.15.2/8.15.2) with ESMTP id 10UISjYA005910; Sat, 30 Jan 2021 19:28:45 +0100 (MET) Received: by rochebonne.antioche.eu.org (Postfix, from userid 1210) id 94875281D; Sat, 30 Jan 2021 19:28:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1f3288c-d745-44ee-bedf-c9a5af2d1bd1 Date: Sat, 30 Jan 2021 19:28:45 +0100 From: Manuel Bouyer To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Anthony PERARD Subject: Re: [PATCH v2] libs/light: make it build without setresuid() Message-ID: <20210130182845.GA2111@antioche.eu.org> References: <20210126224800.1246-1-bouyer@netbsd.org> <20210126224800.1246-11-bouyer@netbsd.org> <69db20b1-b464-cc6d-3b26-711950cc81d7@citrix.com> <20210129230110.GA3543@antioche.eu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (chassiron.antioche.eu.org [151.127.5.145]); Sat, 30 Jan 2021 19:28:46 +0100 (MET) On Fri, Jan 29, 2021 at 11:05:24PM +0000, Andrew Cooper wrote: > On 29/01/2021 23:01, Manuel Bouyer wrote: > > On Fri, Jan 29, 2021 at 10:51:14PM +0000, Andrew Cooper wrote: > >> Given the freeze, and discussions on IRC, I have committed most of this > >> series. > > thanks > > > >> This particular patch doesn't compile, but I fixed it up. > >> > >> Still outstanding are "NetBSD: use system-provided headers", the > > I just sent a v3 of this patch > > You accidentally labelled it v2, but I'm sure we can cope. > > > > >> followon patches requested in "libs/light: pass some infos to qemu", and > > will try to get at it tomorow > > > >> "xenpmd.c: use dynamic allocation" which failed like this: > >> > >> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/996140268 > > It looks like I don't have access to this page, could you share the > > content ? > > urgh - have the permissions broken themselves again... > > xenpmd.c:115:13: error: implicit declaration of function 'asprintf' > [-Werror=implicit-function-declaration] > > It needs an include of stdio.h, and/or some form of #define _GNU_SOURCE. I added the #define, it builds on NetBSD and Linux. I just sent a v3 (as 2 separate patches, sorry I don't know how to easily make it otherwise with git) that should fix it. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --