From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF64C433E0 for ; Mon, 1 Feb 2021 09:39:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7815F64EAE for ; Mon, 1 Feb 2021 09:39:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7815F64EAE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=antioche.eu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.79631.145015 (Exim 4.92) (envelope-from ) id 1l6VgP-0006kd-Pr; Mon, 01 Feb 2021 09:39:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 79631.145015; Mon, 01 Feb 2021 09:39:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6VgP-0006kW-M2; Mon, 01 Feb 2021 09:39:45 +0000 Received: by outflank-mailman (input) for mailman id 79631; Mon, 01 Feb 2021 09:39:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6VgO-0006kQ-ES for xen-devel@lists.xenproject.org; Mon, 01 Feb 2021 09:39:44 +0000 Received: from chassiron.antioche.eu.org (unknown [2001:41d0:fe9d:1101::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 95c75cde-3d39-4f29-b826-75fdddc7ad29; Mon, 01 Feb 2021 09:39:43 +0000 (UTC) Received: from rochebonne.antioche.eu.org (rochebonne [IPv6:2001:41d0:fe9d:1100:221:70ff:fe0c:9885]) by chassiron.antioche.eu.org (8.15.2/8.15.2) with ESMTP id 1119ddUZ004162; Mon, 1 Feb 2021 10:39:39 +0100 (MET) Received: by rochebonne.antioche.eu.org (Postfix, from userid 1210) id 61E18281D; Mon, 1 Feb 2021 10:39:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95c75cde-3d39-4f29-b826-75fdddc7ad29 Date: Mon, 1 Feb 2021 10:39:39 +0100 From: Manuel Bouyer To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Anthony PERARD Subject: Re: [PATCH v2] libs/light: pass some infos to qemu Message-ID: <20210201093939.GB624@antioche.eu.org> References: <20210126224800.1246-1-bouyer@netbsd.org> <20210126224800.1246-12-bouyer@netbsd.org> <20210130115013.GA2101@antioche.eu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (chassiron.antioche.eu.org [IPv6:2001:41d0:fe9d:1100:a00:20ff:fe1c:276e]); Mon, 01 Feb 2021 10:39:39 +0100 (MET) On Mon, Feb 01, 2021 at 09:06:13AM +0100, Roger Pau Monné wrote: > On Sat, Jan 30, 2021 at 12:50:13PM +0100, Manuel Bouyer wrote: > > On Thu, Jan 28, 2021 at 12:08:02PM +0100, Roger Pau Monné wrote: > > > [...] > > > Also, the qemu-ifup script doesn't seem to be part of the NetBSD > > > scripts that are upstream, is this something carried by the NetBSD > > > package? > > > > Actually, the script is part of qemu-xen-traditional: > > tools/qemu-xen-traditional/i386-dm/qemu-ifup-NetBSD > > > > and it's installed as part of 'make install'. The same script can be used > > for both qemu-xen-traditional and qemu-xen as long as we support only > > bridged mode by default. > > > > qemu-xen-traditional did call the script with the bridge name. > > This patch makes qemu-xen call the script with the same parameters, > > and add the XEN_DOMAIN_ID environnement variable. > > > > Is it OK to keep the script from qemu-xen-traditional (and installed as > > part of qemu-xen-traditional) for now ? > > I think you want to move the script into hotplug/NetBSD/ because it > should be possible to install a system without qemu-xen-traditional > (--disable-qemu-traditional) and only qemu-upstream, and the script > will still be needed in that case. I can, but how do I get the ecript removed from qemu-traditional ? It's a different repo, isn't it ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --