From: Manuel Bouyer <bouyer@antioche.eu.org>
To: "Jürgen Groß" <jgross@suse.com>
Cc: xen-devel@lists.xen.org
Subject: Re: xenstored file descriptor leak
Date: Wed, 3 Feb 2021 13:17:38 +0100 [thread overview]
Message-ID: <20210203121738.GA2610@antioche.eu.org> (raw)
In-Reply-To: <8e4f159a-9519-3576-8f6b-3800a0e84500@suse.com>
On Wed, Feb 03, 2021 at 01:13:53PM +0100, Jürgen Groß wrote:
> On 03.02.21 13:03, Manuel Bouyer wrote:
> > On Wed, Feb 03, 2021 at 12:54:23PM +0100, Jürgen Groß wrote:
> > > On 03.02.21 12:48, Manuel Bouyer wrote:
> > > > On Wed, Feb 03, 2021 at 09:21:32AM +0100, Jürgen Groß wrote:
> > > > > [...]
> > > > > This shouldn't happen in case we are closing the socket actively.
> > > > >
> > > > > In the end we should just do a talloc_free(conn) in
> > > > > ignore_connection() if it is a socket based one. This should revert
> > > > > the critical modification of the XSA-115 fixes for sockets while
> > > > > keeping the desired effect for domain connections.
> > > >
> > > > Hello
> > > > here's an updated patch which works for me. Does anyone see a problem
> > > > with it ? If not I will submit it for commit.
> > > >
> > >
> > > Do you really need the first hunk? I would have thought just freeing
> > > conn in ignore_connection() is enough.
> > >
> > > In case you are seeing problems without the first hunk, please say so
> > > in a comment added to this hunk in order to avoid it being removed
> > > sometimes in the future.
> >
> > No I don't need it. From your previous comments I though it was a good idea
> > to keep it, but I can remove it if you think it's better.
>
> Yes, please remove it.
Will do
In the patch I'm going to submit, may I add
Reviewed-by: Jürgen Groß <jgross@suse.com>
?
--
Manuel Bouyer <bouyer@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--
next prev parent reply other threads:[~2021-02-03 12:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 18:37 xenstored file descriptor leak Manuel Bouyer
2021-02-03 6:18 ` Jürgen Groß
2021-02-03 7:57 ` Manuel Bouyer
2021-02-03 8:05 ` Jürgen Groß
2021-02-03 8:16 ` Manuel Bouyer
2021-02-03 8:21 ` Jürgen Groß
2021-02-03 11:48 ` Manuel Bouyer
2021-02-03 11:54 ` Jürgen Groß
2021-02-03 12:03 ` Manuel Bouyer
2021-02-03 12:13 ` Jürgen Groß
2021-02-03 12:17 ` Manuel Bouyer [this message]
2021-02-03 12:21 ` Jürgen Groß
2021-02-03 12:33 ` Manuel Bouyer
2021-02-03 12:42 ` Jürgen Groß
2021-02-03 12:47 ` Manuel Bouyer
2021-02-03 12:58 ` Jürgen Groß
2021-02-03 13:03 ` Manuel Bouyer
2021-02-03 13:11 ` Jürgen Groß
2021-02-03 13:24 ` Manuel Bouyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203121738.GA2610@antioche.eu.org \
--to=bouyer@antioche.eu.org \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).