From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A6CC433DB for ; Thu, 18 Feb 2021 15:23:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BBA461494 for ; Thu, 18 Feb 2021 15:23:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BBA461494 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.86681.162893 (Exim 4.92) (envelope-from ) id 1lCl8q-0006KD-Ey; Thu, 18 Feb 2021 15:22:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 86681.162893; Thu, 18 Feb 2021 15:22:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lCl8q-0006K6-BE; Thu, 18 Feb 2021 15:22:56 +0000 Received: by outflank-mailman (input) for mailman id 86681; Thu, 18 Feb 2021 15:22:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lCl8o-0006K1-Oi for xen-devel@lists.xenproject.org; Thu, 18 Feb 2021 15:22:54 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [63.128.21.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 26227b49-892a-4837-8012-636ba45eecdb; Thu, 18 Feb 2021 15:22:53 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-iWZITrk4M0qFn9y3Kf7wcA-1; Thu, 18 Feb 2021 10:22:49 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2AF131936B66; Thu, 18 Feb 2021 15:22:48 +0000 (UTC) Received: from localhost.localdomain (ovpn-114-28.rdu2.redhat.com [10.10.114.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 48D3C10016DB; Thu, 18 Feb 2021 15:22:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26227b49-892a-4837-8012-636ba45eecdb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613661773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oKW300fgiDXqSH0LNzsHF56e+kWpLknmKKlM0u8WQq0=; b=buT45IyQakZsxhvUkL3keobib3wI6ZghlvAt4L35C3a3eMS4P6tuwLBHBW35imfQM+14Zd +vqhwpfQPNtBuGE1whJxWNCvvqS76kafF31FTbEBPPlJqRc0rjRsOH4p2etB4d9y4axxHi G5vlr5Zlpidqo6BzcEs+tbkPosGGtEM= X-MC-Unique: iWZITrk4M0qFn9y3Kf7wcA-1 Date: Thu, 18 Feb 2021 10:22:41 -0500 From: Cleber Rosa To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Alex =?iso-8859-1?Q?Benn=E9e?= , Willian Rampazzo , julien@xen.org, andre.przywara@arm.com, stefano.stabellini@linaro.org, qemu-devel@nongnu.org, Wainer dos Santos Moschetta , xen-devel@lists.xenproject.org, stefano.stabellini@xilinx.com, stratos-dev@op-lists.linaro.org Subject: Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests Message-ID: <20210218152241.GB433029@localhost.localdomain> References: <20210211171945.18313-1-alex.bennee@linaro.org> <20210211171945.18313-8-alex.bennee@linaro.org> <20210217204654.GA353754@localhost.localdomain> <2948d7db-2168-7c5e-a73e-969a67496daa@redhat.com> MIME-Version: 1.0 In-Reply-To: <2948d7db-2168-7c5e-a73e-969a67496daa@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 18, 2021 at 10:43:54AM +0100, Philippe Mathieu-Daud=E9 wrote: > On 2/17/21 9:46 PM, Cleber Rosa wrote: > > On Thu, Feb 11, 2021 at 05:19:45PM +0000, Alex Benn=E9e wrote: > >> These tests make sure we can boot the Xen hypervisor with a Dom0 > >> kernel using the guest-loader. We currently have to use a kernel I > >> built myself because there are issues using the Debian kernel images. > >> > >> Signed-off-by: Alex Benn=E9e > >> --- > >> MAINTAINERS | 1 + > >> tests/acceptance/boot_xen.py | 117 ++++++++++++++++++++++++++++++++++= + > >> 2 files changed, 118 insertions(+) > >> create mode 100644 tests/acceptance/boot_xen.py >=20 > >> +class BootXen(BootXenBase): > >> + > >> + @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') > >> + def test_arm64_xen_411_and_dom0(self): > >> + """ > >> + :avocado: tags=3Darch:aarch64 > >> + :avocado: tags=3Daccel:tcg > >> + :avocado: tags=3Dcpu:cortex-a57 > >> + :avocado: tags=3Dmachine:virt > >> + """ > >> + xen_url =3D ('https://deb.debian.org/debian/' > >> + 'pool/main/x/xen/' > >> + 'xen-hypervisor-4.11-arm64_4.11.4+37-g3263f257ca-1= _arm64.deb') > >> + xen_sha1 =3D '034e634d4416adbad1212d59b62bccdcda63e62a' > >=20 > > This URL is already giving 404s because of a new pacakge. I found > > this to work (but yeah, won't probably last long): > >=20 > > xen_url =3D ('http://deb.debian.org/debian/' > > 'pool/main/x/xen/' > > 'xen-hypervisor-4.11-arm64_4.11.4+57-g41a822c392-2_a= rm64.deb') > > xen_sha1 =3D 'b5a6810fc67fd50fa36afdfdfe88ce3153dd3a55' >=20 > This is not the same package version... Please understand the developer > has to download the Debian package sources, check again the set of > downstream changes between 37 and 57. Each distrib number might contain > multiple downstream patches. Then the testing has to be done again, > often enabling tracing or doing single-stepping in gdb. This has a > cost in productivity. This is why I insist I prefer to use archived > well tested artifacts, rather than changing package URL randomly. > I understand it's not the same version... but from my different and limited PoV it was the obvious thing to suggest during a review. Of course using stable archived versions is much better (I believe Alex will look into that for these packages). Best, - Cleber. --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeruW64tGuU1eD+m7ZX6NM6XyCfMFAmAuhjkACgkQZX6NM6Xy CfNVdRAAzlG3dNdeqwCKfa6leo0ZGC4j0XorAhWP9lS8UE1QvS6BFUQaO/esZcm+ BOo5YWsmbAg/e8MGu9Q4eZvCnkAPrjDDWQN9/6RYJ2qrBZfE/WOyV38UhR2SkMLz RfgvQpQE075ZgQZed+puHfdWEgwELovkBlFklwDfzQbhp1jgCVaQXHA1pbJjMeVw ryTNfBSRb2hQ7CKkeTL3XKxhzljR4McqaNfWONZJnfxwGGYRX5NJ9FrbsHuyyyZe wjqylXUATtNEswQlUPG5YLwrn20vt7e6V/Oh6Wz+gaZbBXNO9sqRnKu+Hq8pUTEX SbWNwy4s8TUMvFNwedvSJE/C6Xyc6VaocP2eCeOtQhnriraRNG720//4b81Zo0Wv rwd4/va7y+UegpB0W69LdAcw78SQ5Knl1BKr3wGqxa+/ae9TXTs5EnUOzeh2DoYH 3lI6yI+Q4Fk4Sv6M/ailVOMq2jS5zXGnnQkKG55JdCkjp46DIbV/FnNPpI5OdUxL u3E0SytsouftiOG83nNDlqn7GSqJE/wg7qi0FNLZm/IvE1CBhSooPs12mcp1XBkm rpHEB00duys35EY131gkKZ9Cr8FUvpetmzWXxvoE3jPFTZfQeO86zDe/t1UxALZA s9sI2FLvEMO18BsCLOPq/ga6N3gEgUE9ByMmPllTiB75d2UicIs= =XUNL -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--