From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066F9C433B4 for ; Wed, 7 Apr 2021 18:27:48 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFAE7610FB for ; Wed, 7 Apr 2021 18:27:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFAE7610FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.106899.204366 (Exim 4.92) (envelope-from ) id 1lUCto-0006os-Mc; Wed, 07 Apr 2021 18:27:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 106899.204366; Wed, 07 Apr 2021 18:27:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUCto-0006ol-JL; Wed, 07 Apr 2021 18:27:32 +0000 Received: by outflank-mailman (input) for mailman id 106899; Wed, 07 Apr 2021 18:27:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUCtm-0006og-SL for xen-devel@lists.xenproject.org; Wed, 07 Apr 2021 18:27:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUCtl-0003AZ-Jv; Wed, 07 Apr 2021 18:27:29 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUCtl-00082B-7F; Wed, 07 Apr 2021 18:27:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=QU9LxEd/xA9jkmgV1v8fY23G82LJl35wNTL+ArBVMu4=; b=50m9b7Du1v+ESNBZzT9Ca/TN61 21W27JBCWYM0JHo4AUBx/fpyCqEaWHrvFEQiBXS51bCG9quUGHpoNUkUgiWQ8B8AmW4jqPOIaZl8t 9RAHbTEw7x1OPHT8W3mnHF/Ino5WPa5DNHJT8hGq/aVjSRi5JOLHs4Eoy33GT/Y3fldY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7 Date: Wed, 7 Apr 2021 19:27:26 +0100 Message-Id: <20210407182726.26603-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall The compilation will fail when building Xen with clang and CONFIG_DEBUG=y: make[4]: Leaving directory '/oss/xen/xen/common/libelf' INIT_O gunzip.init.o Error: size of gunzip.o:.text is 0x00000019 This is because the function init_allocator() will not be inlined and is not part of the init section. Fix it by marking init_allocator() with INIT. Fixes: 33bc2a8495f7 ("xen/gunzip: Allow perform_gunzip() to be called multiple times") Reported-by: Jan Beulich Signed-off-by: Julien Grall --- xen/common/inflate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/inflate.c b/xen/common/inflate.c index d8c28a3e9593..c593b94d481e 100644 --- a/xen/common/inflate.c +++ b/xen/common/inflate.c @@ -238,7 +238,7 @@ STATIC const ush mask_bits[] = { static unsigned long INITDATA malloc_ptr; static int INITDATA malloc_count; -static void init_allocator(void) +static void INIT init_allocator(void) { malloc_ptr = free_mem_ptr; malloc_count = 0; -- 2.17.1