xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Roman Shaposhnik <roman@zededa.com>
Cc: grub-devel@gnu.org, "Roger Pau Monné" <roger.pau@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: multiboot2 and module2 boot issues via GRUB2
Date: Thu, 8 Apr 2021 18:48:39 +0200	[thread overview]
Message-ID: <20210408164839.t5ulhjswnypbqpnz@tomti.i.net-space.pl> (raw)
In-Reply-To: <a8c7fb60-7a95-1a99-4005-b04bcac4c2be@citrix.com>

On Thu, Apr 01, 2021 at 08:43:46PM +0100, Andrew Cooper via Grub-devel wrote:
> On 01/04/2021 09:44, Roger Pau Monné wrote:
> > On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote:
> >> On 01.04.2021 03:06, Roman Shaposhnik wrote:
> >>> And the obvious next question: is my EVE usecase esoteric enough that
> >>> I should just go ahead and do a custom GRUB patch or is there a more
> >>> general interest in this?
> >> Not sure if it ought to be a grub patch - the issue could as well
> >> be dealt with in Xen, by concatenating modules to form a monolithic
> >> initrd.
> > I would rather have it done in the loader than Xen, mostly because
> > it's a Linux boot specific format, and hence I don't think Xen should
> > have any knowledge about it.
> >
> > If it turns out to be impossible to implement on the loader side we
> > should consider doing it in Xen, but that's not my first option.
>
> Concatenating random things which may or may not be initrds is
> absolutely not something Xen should do.  We don't have enough context to
> do it safely/sensibly.
>
> Honestly, I like the idea of supporting something like this generally in
> grub.  Linux already commonly has initrd preparation prepending an
> uncompressed microcode CPIO archive, and I can see a usability advantage
> from maintaining the initrd fragments separately.
>
> Looking at the grub manual, this behaviour of the `initrd` command isn't
> even documented.  Perhaps that should be fixed first, and then maybe
> `module2_multi` added too?

I am OK with additional Multiboot2 command. Though I would do
s/module2_multi/module2_concat/. Additionally, it should look for "--"
and interpret everything after it as a command line argument for
a concatenated module.

Daniel


  parent reply	other threads:[~2021-04-08 18:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 18:28 multiboot2 and module2 boot issues via GRUB2 Roman Shaposhnik
2021-03-30 19:08 ` Andrew Cooper
2021-04-01  1:06   ` Roman Shaposhnik
2021-04-01  7:31     ` Jan Beulich
2021-04-01  8:44       ` Roger Pau Monné
2021-04-01 19:43         ` Andrew Cooper
2021-04-06  8:19           ` Jan Beulich
2021-04-06 17:37             ` Roman Shaposhnik
2021-04-06 17:51             ` Andrew Cooper
2021-04-06 18:03               ` Roman Shaposhnik
2021-04-06 18:41                 ` Andrew Cooper
2021-04-07 20:50           ` Glenn Washburn
2021-04-08 16:48           ` Daniel Kiper [this message]
2021-03-30 19:35 ` Elliott Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210408164839.t5ulhjswnypbqpnz@tomti.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=andrew.cooper3@citrix.com \
    --cc=grub-devel@gnu.org \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=roman@zededa.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).