From: Henrik Riomar <rio@riomar.se>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Subject: Re: xenstore utils dropped support for -s in 4.15
Date: Sun, 11 Apr 2021 09:17:34 +0200 [thread overview]
Message-ID: <20210411091734.09ef653bf97aa954fecac079@riomar.se> (raw)
In-Reply-To: <215bcc74-baff-6345-73ed-16f7da266a1b@suse.com>
On Sun, 11 Apr 2021 07:34:16 +0200
Juergen Gross <jgross@suse.com> wrote:
> On 11.04.21 00:02, Henrik Riomar wrote:
> > Hi,
> >
> > In Alpine and Debian (probably elsewhere as well), the -s flag removed in these two commits:
> > * https://github.com/xen-project/xen/commit/fa06cb8c38832aafe597d719040ba1d216e367b8
> > * https://github.com/xen-project/xen/commit/c65687ed16d2289ec91036ec2862a4b4bd34ea4f
> > is actually used in the init scripts.
> > Reverting the two commits mentioned above restores a booting system.
> >
> > The -s flag was introduced in 2005 or so, so I guess you can say that dropping it should
> > at least be mentioned in the release notices, and an alternative be described, or
> > -s functionally should be brought back.
>
> The -s served exactly no purpose.
yes its used by dists to check that the socket is actually accessible (without falling back to
direct access to /dev/xen/xenbus).
>
> It was meant to force socket usage. A socket will be used anyway in
> case xenstored is running in dom0, so specifying -s won't change
> anything in this case.
yes reverting the to commits above and using -s, brings back the original behavior, returning
with failure if the socket is not there.
There are two issues here I think:
1. dists actually use -s to check if the daemon is up (and been doing this for a long time)
2. Reads of /dev/xen/xenbus (via xenstore-read -s /), blocks for ever in 4.15
/ Henrik
next prev parent reply other threads:[~2021-04-11 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 22:02 xenstore utils dropped support for -s in 4.15 Henrik Riomar
2021-04-11 5:34 ` Juergen Gross
2021-04-11 7:17 ` Henrik Riomar [this message]
2021-04-11 9:17 ` Juergen Gross
2021-04-19 8:20 ` Henrik Riomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210411091734.09ef653bf97aa954fecac079@riomar.se \
--to=rio@riomar.se \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).