From: Andrew Cooper <andrew.cooper3@citrix.com> To: Xen-devel <xen-devel@lists.xenproject.org> Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>, "Tim Deegan" <tim@xen.org>, "Jan Beulich" <JBeulich@suse.com>, "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org> Subject: [PATCH 6/7] x86/shadow: Make _shadow_prealloc() compile at -Og Date: Mon, 19 Apr 2021 15:01:31 +0100 [thread overview] Message-ID: <20210419140132.16909-7-andrew.cooper3@citrix.com> (raw) In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> When compiling at -Og: In file included from /builds/xen-project/people/andyhhp/xen/xen/include/asm/domain.h:4:0, from /builds/xen-project/people/andyhhp/xen/xen/include/xen/domain.h:8, from /builds/xen-project/people/andyhhp/xen/xen/include/xen/sched.h:11, from /builds/xen-project/people/andyhhp/xen/xen/include/xen/ioreq.h:22, from common.c:23: common.c: In function '_shadow_prealloc': /builds/xen-project/people/andyhhp/xen/xen/include/xen/mm.h:252:55: error: 't' may be used uninitialized in this function [-Werror=maybe-uninitialized] return page != head->next ? pdx_to_page(page->list.prev) : NULL; ^ common.c:933:28: note: 't' was declared here struct page_info *sp, *t; ^ I'm not certain the analysis is correct. 't' is a temporary variable, and is clearly initialised before use in foreach_pinned_shadow(). Either way, initialising it to NULL placates the compiler. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Tim Deegan <tim@xen.org> CC: Jan Beulich <JBeulich@suse.com> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Wei Liu <wl@xen.org> --- xen/arch/x86/mm/shadow/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index b99ca14e71..737e6b365a 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -931,7 +931,7 @@ static inline void trace_shadow_prealloc_unpin(struct domain *d, mfn_t smfn) static void _shadow_prealloc(struct domain *d, unsigned int pages) { struct vcpu *v; - struct page_info *sp, *t; + struct page_info *sp, *t = NULL; mfn_t smfn; int i; -- 2.11.0
next prev parent reply other threads:[~2021-04-19 14:02 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 14:01 [PATCH 0/7] xen: Switch to using -Og for debug builds Andrew Cooper 2021-04-19 14:01 ` [PATCH 1/7] xen/arm: Make make_cpus_node() compile at -Og Andrew Cooper 2021-04-22 18:20 ` Julien Grall 2021-04-19 14:01 ` [PATCH 2/7] x86/shim: Fix compilation " Andrew Cooper 2021-04-19 14:01 ` [PATCH 3/7] x86/sysctl: Make arch_do_sysctl() compile " Andrew Cooper 2021-04-19 14:01 ` [PATCH 4/7] x86/irq: Make create_irq() " Andrew Cooper 2021-04-19 14:01 ` [PATCH 5/7] xen/efi: Make efi_start() " Andrew Cooper 2021-04-19 14:01 ` Andrew Cooper [this message] 2021-04-22 7:52 ` [PATCH 6/7] x86/shadow: Make _shadow_prealloc() " Tim Deegan 2021-04-19 14:01 ` [PATCH 7/7] xen: Use -Og for debug builds when available Andrew Cooper 2021-04-19 15:45 ` [PATCH 0/7] xen: Switch to using -Og for debug builds Jan Beulich 2021-04-21 9:31 ` Andrew Cooper 2021-04-21 9:51 ` Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210419140132.16909-7-andrew.cooper3@citrix.com \ --to=andrew.cooper3@citrix.com \ --cc=JBeulich@suse.com \ --cc=roger.pau@citrix.com \ --cc=tim@xen.org \ --cc=wl@xen.org \ --cc=xen-devel@lists.xenproject.org \ --subject='Re: [PATCH 6/7] x86/shadow: Make _shadow_prealloc() compile at -Og' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).