From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBCBFC433ED for ; Tue, 4 May 2021 13:04:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BBE3611AE for ; Tue, 4 May 2021 13:04:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BBE3611AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.122345.230738 (Exim 4.92) (envelope-from ) id 1lduiN-0000Kl-N0; Tue, 04 May 2021 13:03:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 122345.230738; Tue, 04 May 2021 13:03:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lduiN-0000Ke-JH; Tue, 04 May 2021 13:03:51 +0000 Received: by outflank-mailman (input) for mailman id 122345; Tue, 04 May 2021 13:03:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lduiM-0000Jn-NH for xen-devel@lists.xenproject.org; Tue, 04 May 2021 13:03:50 +0000 Received: from hera.aquilenet.fr (unknown [185.233.100.1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1dfb8e11-3890-4c33-9d0f-d3eadac30016; Tue, 04 May 2021 13:03:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E9C72140; Tue, 4 May 2021 15:03:45 +0200 (CEST) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ka3Jwbg04sll; Tue, 4 May 2021 15:03:45 +0200 (CEST) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0C8B2AF; Tue, 4 May 2021 15:03:44 +0200 (CEST) Received: from samy by begin with local (Exim 4.94) (envelope-from ) id 1lduiF-00Fp58-VK; Tue, 04 May 2021 15:03:43 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1dfb8e11-3890-4c33-9d0f-d3eadac30016 X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Date: Tue, 4 May 2021 15:03:43 +0200 From: Samuel Thibault To: Jason Andryuk Cc: xen-devel@lists.xenproject.org, Daniel De Graaf , Quan Xu Subject: Re: [PATCH 2/9] vtpmmgr: Print error code to aid debugging Message-ID: <20210504130343.dwhvlewrphufjd7d@begin> Mail-Followup-To: Samuel Thibault , Jason Andryuk , xen-devel@lists.xenproject.org, Daniel De Graaf , Quan Xu References: <20210504124842.220445-1-jandryuk@gmail.com> <20210504124842.220445-3-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210504124842.220445-3-jandryuk@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- Authentication-Results: hera.aquilenet.fr X-Rspamd-Server: hera X-Rspamd-Queue-Id: E9C72140 X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] Jason Andryuk, le mar. 04 mai 2021 08:48:35 -0400, a ecrit: > tpm_get_error_name returns "Unknown Error Code" when an error string > is not defined. In that case, we should print the Error Code so it can > be looked up offline. tpm_get_error_name returns a const string, so > just have the two callers always print the error code so it is always > available. > > Signed-off-by: Jason Andryuk Reviewed-by: Samuel Thibault > --- > stubdom/vtpmmgr/tpm.c | 2 +- > stubdom/vtpmmgr/tpm2.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/stubdom/vtpmmgr/tpm.c b/stubdom/vtpmmgr/tpm.c > index 779cddd64e..83b2bc16b2 100644 > --- a/stubdom/vtpmmgr/tpm.c > +++ b/stubdom/vtpmmgr/tpm.c > @@ -109,7 +109,7 @@ > UINT32 rsp_status; \ > UNPACK_OUT(TPM_RSP_HEADER, &rsp_tag, &rsp_len, &rsp_status); \ > if (rsp_status != TPM_SUCCESS) { \ > - vtpmlogerror(VTPM_LOG_TPM, "Failed with return code %s\n", tpm_get_error_name(rsp_status)); \ > + vtpmlogerror(VTPM_LOG_TPM, "Failed with return code %s (%x)\n", tpm_get_error_name(rsp_status), rsp_status); \ > status = rsp_status; \ > goto abort_egress; \ > } \ > diff --git a/stubdom/vtpmmgr/tpm2.c b/stubdom/vtpmmgr/tpm2.c > index c9f1016ab5..655e6d164c 100644 > --- a/stubdom/vtpmmgr/tpm2.c > +++ b/stubdom/vtpmmgr/tpm2.c > @@ -126,7 +126,7 @@ > ptr = unpack_TPM_RSP_HEADER(ptr, \ > &(tag), &(paramSize), &(status));\ > if ((status) != TPM_SUCCESS){ \ > - vtpmlogerror(VTPM_LOG_TPM, "Failed with return code %s\n", tpm_get_error_name(status));\ > + vtpmlogerror(VTPM_LOG_TPM, "Failed with return code %s (%x)\n", tpm_get_error_name(status), (status));\ > goto abort_egress;\ > }\ > } while(0) > -- > 2.30.2 >