From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E78C433ED for ; Tue, 4 May 2021 17:07:48 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05414613AA for ; Tue, 4 May 2021 17:07:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05414613AA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.122607.231259 (Exim 4.92) (envelope-from ) id 1ldyWJ-0001Gj-BB; Tue, 04 May 2021 17:07:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 122607.231259; Tue, 04 May 2021 17:07:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ldyWJ-0001Gc-8D; Tue, 04 May 2021 17:07:39 +0000 Received: by outflank-mailman (input) for mailman id 122607; Tue, 04 May 2021 17:07:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ldyWI-0001GQ-CR for xen-devel@lists.xenproject.org; Tue, 04 May 2021 17:07:38 +0000 Received: from hera.aquilenet.fr (unknown [2a0c:e300::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cc6671eb-9236-4983-b6bb-1b732a0c2503; Tue, 04 May 2021 17:07:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 56B8B365; Tue, 4 May 2021 19:07:36 +0200 (CEST) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bkCf6oQ-HwxQ; Tue, 4 May 2021 19:07:35 +0200 (CEST) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 67417362; Tue, 4 May 2021 19:07:35 +0200 (CEST) Received: from samy by begin with local (Exim 4.94) (envelope-from ) id 1ldyWE-00GOos-JT; Tue, 04 May 2021 19:07:34 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc6671eb-9236-4983-b6bb-1b732a0c2503 X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Date: Tue, 4 May 2021 19:07:34 +0200 From: Samuel Thibault To: Jason Andryuk Cc: xen-devel , Daniel De Graaf , Quan Xu Subject: Re: [PATCH 7/9] vtpmmgr: Flush all transient keys Message-ID: <20210504170734.nc4hfmo5olhlikes@begin> Mail-Followup-To: Samuel Thibault , Jason Andryuk , xen-devel , Daniel De Graaf , Quan Xu References: <20210504124842.220445-1-jandryuk@gmail.com> <20210504124842.220445-8-jandryuk@gmail.com> <20210504131626.h2ylaamk35evw6yg@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- Authentication-Results: hera.aquilenet.fr X-Rspamd-Server: hera X-Rspamd-Queue-Id: 56B8B365 X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] Jason Andryuk, le mar. 04 mai 2021 13:05:33 -0400, a ecrit: > On Tue, May 4, 2021 at 9:16 AM Samuel Thibault > wrote: > > > > Jason Andryuk, le mar. 04 mai 2021 08:48:40 -0400, a ecrit: > > > We're only flushing 2 transients, but there are 3 handles. Use <= to also > > > flush the third handle. > > > > > > The number of transient handles/keys is hardware dependent, so this > > > should query for the limit. And assignment of handles is assumed to be > > > sequential from the minimum. That may not be guaranteed, but seems okay > > > with my tpm2. > > > > > > Signed-off-by: Jason Andryuk > > > > Maybe explicit in the log that TRANSIENT_LAST is actually inclusive? > > In the commit message? Sounds good to me. Yes, please. Samuel